Re: [U-Boot] [PATCH] Exynos: Make sure ps_hold gets set in the SPL
Hi Simon,
On 22 May 2014 01:53, Akshay Saraswat akshay.s@samsung.com wrote:
From: Doug Anderson dianders@chromium.org
Setting ps_hold ought to be one of the first things we do when we first boot up. If we wait until the main u-boot runs we won't set it in time and the PMIC may power us back off.
Moving ps_hold setup into the generic power_init() which should contain code that's currently duplicated in the board_power_init() of several boards.
Signed-off-by: Doug Anderson dianders@chromium.org Signed-off-by: Akshay Saraswat akshay.s@samsung.com
arch/arm/cpu/armv7/exynos/lowlevel_init.c | 6 +++++- arch/arm/cpu/armv7/exynos/power.c | 14 ++++++++++++++ arch/arm/include/asm/arch-exynos/power.h | 8 ++++++++ 3 files changed, 27 insertions(+), 1 deletion(-)
Acked-by: Simon Glass sjg@chromium.org
Also see http://patchwork.ozlabs.org/patch/350693/ but your patch is better.
Shall we keep this one then ?
Regards, Simon
Regards, Akshay Saraswat
Hi Akshay,
On 26 May 2014 03:40, Akshay Saraswat akshay.s@samsung.com wrote:
Hi Simon,
On 22 May 2014 01:53, Akshay Saraswat akshay.s@samsung.com wrote:
From: Doug Anderson dianders@chromium.org
Setting ps_hold ought to be one of the first things we do when we first boot up. If we wait until the main u-boot runs we won't set it in time and the PMIC may power us back off.
Moving ps_hold setup into the generic power_init() which should contain code that's currently duplicated in the board_power_init() of several boards.
Signed-off-by: Doug Anderson dianders@chromium.org Signed-off-by: Akshay Saraswat akshay.s@samsung.com
arch/arm/cpu/armv7/exynos/lowlevel_init.c | 6 +++++- arch/arm/cpu/armv7/exynos/power.c | 14 ++++++++++++++ arch/arm/include/asm/arch-exynos/power.h | 8 ++++++++ 3 files changed, 27 insertions(+), 1 deletion(-)
Acked-by: Simon Glass sjg@chromium.org
Also see http://patchwork.ozlabs.org/patch/350693/ but your patch is better.
Shall we keep this one then ?
Yes.
Regards, Simon
participants (2)
-
Akshay Saraswat -
Simon Glass