[PATCH] binman: doc: fix reference tag placement for Logging section

Move BinmanLogging reference tag after section "Signing FIT container with private key in an image" and just before section "Logging".
Fixes: 0f40e23fd22 ("binman: add documentation for binman sign option") Signed-off-by: Massimo Pegorer massimo.pegorer+oss@gmail.com
--- Note that at the end of section "Replacing files in an image" and just before section "Signing FIT container with private key in an image" there is a line which seems a typo or an incomplete sentence:
Repacking an image involves
--- tools/binman/binman.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/binman/binman.rst b/tools/binman/binman.rst index aeea33fddb..8945b19446 100644 --- a/tools/binman/binman.rst +++ b/tools/binman/binman.rst @@ -1482,7 +1482,6 @@ when it was created.
Repacking an image involves
-.. _`BinmanLogging`:
Signing FIT container with private key in an image -------------------------------------------------- @@ -1501,6 +1500,7 @@ If you want to sign and replace FIT container in place:: which will sign FIT container with private key and replace it immediately inside your image.
+.. _`BinmanLogging`:
Logging -------

On 9/9/23 15:52, Massimo Pegorer wrote:
Move BinmanLogging reference tag after section "Signing FIT container with private key in an image" and just before section "Logging".
Fixes: 0f40e23fd22 ("binman: add documentation for binman sign option") Signed-off-by: Massimo Pegorer massimo.pegorer+oss@gmail.com
Reviewed-by: Heinrich Schuchardt xypron.glpk@gmx.de

Hi Simon, Heinrich,
Il giorno sab 9 set 2023 alle ore 15:52 Massimo Pegorer massimo.pegorer+oss@gmail.com ha scritto:
Move BinmanLogging reference tag after section "Signing FIT container with private key in an image" and just before section "Logging".
Fixes: 0f40e23fd22 ("binman: add documentation for binman sign option") Signed-off-by: Massimo Pegorer massimo.pegorer+oss@gmail.com
Note that at the end of section "Replacing files in an image" and just before section "Signing FIT container with private key in an image" there is a line which seems a typo or an incomplete sentence:
Repacking an image involves
Any comment about this note? Should I remove this line in a v2?
Regards, Massimo
tools/binman/binman.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/binman/binman.rst b/tools/binman/binman.rst index aeea33fddb..8945b19446 100644 --- a/tools/binman/binman.rst +++ b/tools/binman/binman.rst @@ -1482,7 +1482,6 @@ when it was created.
Repacking an image involves
-.. _`BinmanLogging`:
Signing FIT container with private key in an image
@@ -1501,6 +1500,7 @@ If you want to sign and replace FIT container in place:: which will sign FIT container with private key and replace it immediately inside your image.
+.. _`BinmanLogging`:
Logging
-- 2.34.1

Hi Massimo,
On Sun, 10 Sept 2023 at 09:35, Massimo Pegorer massimo.pegorer+oss@gmail.com wrote:
Hi Simon, Heinrich,
Il giorno sab 9 set 2023 alle ore 15:52 Massimo Pegorer massimo.pegorer+oss@gmail.com ha scritto:
Move BinmanLogging reference tag after section "Signing FIT container with private key in an image" and just before section "Logging".
Fixes: 0f40e23fd22 ("binman: add documentation for binman sign option") Signed-off-by: Massimo Pegorer massimo.pegorer+oss@gmail.com
Note that at the end of section "Replacing files in an image" and just before section "Signing FIT container with private key in an image" there is a line which seems a typo or an incomplete sentence:
Repacking an image involves
Any comment about this note? Should I remove this line in a v2?
Yes you can remove it. I suspect I was starting to explain what binman does to repack...
Regards, Simon
participants (3)
-
Heinrich Schuchardt
-
Massimo Pegorer
-
Simon Glass