[U-Boot] [PATCH 1/2] wandboard: Return the error immediately when ipuv3_fb_init() fails

From: Fabio Estevam fabio.estevam@freescale.com
If ipuv3_fb_init() fails, we should return the error immediately.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/wandboard/wandboard.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c index 23a78c1..99150f9 100644 --- a/board/wandboard/wandboard.c +++ b/board/wandboard/wandboard.c @@ -230,8 +230,10 @@ int board_video_skip(void)
ret = ipuv3_fb_init(&hdmi, 0, IPU_PIX_FMT_RGB24);
- if (ret) + if (ret) { printf("HDMI cannot be configured: %d\n", ret); + return ret; + }
imx_enable_hdmi_phy();

From: Fabio Estevam fabio.estevam@freescale.com
When cpu_eth_init() fails we should not return success.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/wandboard/wandboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c index 99150f9..bf9898c 100644 --- a/board/wandboard/wandboard.c +++ b/board/wandboard/wandboard.c @@ -265,7 +265,7 @@ int board_eth_init(bd_t *bis) if (ret) printf("FEC MXC: %s:failed\n", __func__);
- return 0; + return ret; }
int board_early_init_f(void)

On 04/11/2013 01:03, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
When cpu_eth_init() fails we should not return success.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks.
Best regards, Stefano Babic

On 04/11/2013 01:03, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
If ipuv3_fb_init() fails, we should return the error immediately.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks.
Best regards, Stefano Babic
participants (2)
-
Fabio Estevam
-
Stefano Babic