On Tuesday 10 February 2009, carolyn.j.smith@tektronix.com wrote:

This fixes the initialization of the SDRAM_CODT register in the ppc4xx DDR2 initialization code. It also removes use of the SDRAM_CODT_FEEDBACK_RCV_SINGLE_END and SDRAM_CODT_FEEDBACK_DRV_SINGLE_END #define's since they are reserved bits.

Signed-off-by: Carolyn Smith carolyn.smith@tektronix.com

Patch doesn't apply:

Applying: ppc4xx: Fix initialization of the SDRAM_CODT register error: patch failed: cpu/ppc4xx/44x_spd_ddr2.c:1101 error: cpu/ppc4xx/44x_spd_ddr2.c: patch does not apply Patch failed at 0001.

How did you generate this patch? I suggest using "git format-patch".

Please find some other comments below.

---

diff -uprN old/cpu/ppc4xx/44x_spd_ddr2.c new/cpu/ppc4xx/44x_spd_ddr2.c --- old/cpu/ppc4xx/44x_spd_ddr2.c 2009-02-10 09:12:56.000000000 -0800 +++ new/cpu/ppc4xx/44x_spd_ddr2.c 2009-02-10 09:13:34.000000000 -0800 @@ -1101,11 +1101,11 @@ static void program_codt(unsigned long * * Set the SDRAM Controller On Die Termination Register

*-----------------------------------------------------------------*/ mfsdram(SDRAM_CODT, codt);

•   codt |= (SDRAM_CODT_IO_NMODE
  

•            & (~SDRAM_CODT_DQS_SINGLE_END
  

•               & ~SDRAM_CODT_CKSE_SINGLE_END
  

•               & ~SDRAM_CODT_FEEBBACK_RCV_SINGLE_END
  

•               & ~SDRAM_CODT_FEEBBACK_DRV_SINGLE_END));
  

•   codt |= SDRAM_CODT_IO_NMODE;
  

•   codt &= ~(SDRAM_CODT_DQS_SINGLE_END | SDRAM_CODT_CKSE_SINGLE_END);
  

Please remove the empty line between those two codt assignments.

And don't add another empty line here.

    for (dimm_num = 0; dimm_num < num_dimm_banks; dimm_num++) {
            if (dimm_populated[dimm_num] != SDRAM_NONE) {

Please fix and resubmit.

Thanks.

Best regards, Stefan

===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================