[U-Boot] [PATCH] net: gem: Check return value from mealign/malloc

Functions can return NULL in case of error that's why checking return value is needed.
Signed-off-by: Michal Simek michal.simek@xilinx.com ---
Reported by: Coverity (local)
--- drivers/net/zynq_gem.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c index 14564e365e6e..a817f2e5d69b 100644 --- a/drivers/net/zynq_gem.c +++ b/drivers/net/zynq_gem.c @@ -633,10 +633,16 @@ static int zynq_gem_probe(struct udevice *dev)
/* Align rxbuffers to ARCH_DMA_MINALIGN */ priv->rxbuffers = memalign(ARCH_DMA_MINALIGN, RX_BUF * PKTSIZE_ALIGN); + if (!priv->rxbuffers) + return -ENOMEM; + memset(priv->rxbuffers, 0, RX_BUF * PKTSIZE_ALIGN);
/* Align bd_space to MMU_SECTION_SHIFT */ bd_space = memalign(1 << MMU_SECTION_SHIFT, BD_SPACE); + if (!bd_space) + return -ENOMEM; + mmu_set_region_dcache_behaviour((phys_addr_t)bd_space, BD_SPACE, DCACHE_OFF);

On Wed, Jun 13, 2018 at 8:20 AM, Michal Simek michal.simek@xilinx.com wrote:
Functions can return NULL in case of error that's why checking return value is needed.
Signed-off-by: Michal Simek michal.simek@xilinx.com
Acked-by: Joe Hershberger joe.hershberger@ni.com

Hi Michal,
https://patchwork.ozlabs.org/patch/928884/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git
Thanks! -Joe
participants (2)
-
Joe Hershberger
-
Michal Simek