[PATCH v2] imx: ahab: allow to bypass confirmation for ahab_close cmd

Calling ahab_close cmd force the user to interact for confirmation.
This is not user-friendly when using this cmd during factory process.
Allow the user to pass '-y' option to bypass this confirmation.
Signed-off-by: Clément Péron peron.clem@gmail.com --- v2: - Fix commit log
--- arch/arm/mach-imx/imx8/ahab.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/imx8/ahab.c b/arch/arm/mach-imx/imx8/ahab.c index cf3c7d762a74..b0865c2330a2 100644 --- a/arch/arm/mach-imx/imx8/ahab.c +++ b/arch/arm/mach-imx/imx8/ahab.c @@ -301,10 +301,11 @@ static int confirm_close(void) static int do_ahab_close(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { + int confirmed = argc >= 2 && !strcmp(argv[1], "-y"); int err; u16 lc;
- if (!confirm_close()) + if (!confirmed && !confirm_close()) return -EACCES;
err = sc_seco_chip_info(-1, &lc, NULL, NULL, NULL);

Subject: [PATCH v2] imx: ahab: allow to bypass confirmation for ahab_close cmd
Calling ahab_close cmd force the user to interact for confirmation.
This is not user-friendly when using this cmd during factory process.
Allow the user to pass '-y' option to bypass this confirmation.
Signed-off-by: Clément Péron peron.clem@gmail.com
Reviewed-by: Peng Fan peng.fan@nxp.com
v2:
- Fix commit log
arch/arm/mach-imx/imx8/ahab.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/imx8/ahab.c b/arch/arm/mach-imx/imx8/ahab.c index cf3c7d762a74..b0865c2330a2 100644 --- a/arch/arm/mach-imx/imx8/ahab.c +++ b/arch/arm/mach-imx/imx8/ahab.c @@ -301,10 +301,11 @@ static int confirm_close(void) static int do_ahab_close(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) {
- int confirmed = argc >= 2 && !strcmp(argv[1], "-y"); int err; u16 lc;
- if (!confirm_close())
if (!confirmed && !confirm_close()) return -EACCES;
err = sc_seco_chip_info(-1, &lc, NULL, NULL, NULL);
-- 2.25.1

On 21/12/20, Clément Péron wrote:
Calling ahab_close cmd force the user to interact for confirmation.
This is not user-friendly when using this cmd during factory process.
Allow the user to pass '-y' option to bypass this confirmation.
Signed-off-by: Clément Péron peron.clem@gmail.com
Acked-by: Oliver Graute oliver.graute@kococonnector.com

Calling ahab_close cmd force the user to interact for confirmation. This is not user-friendly when using this cmd during factory process. Allow the user to pass '-y' option to bypass this confirmation. Signed-off-by: Clément Péron peron.clem@gmail.com Reviewed-by: Peng Fan peng.fan@nxp.com Acked-by: Oliver Graute oliver.graute@kococonnector.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
participants (4)
-
Clément Péron
-
Oliver Graute
-
Peng Fan
-
sbabic@denx.de