[PATCH] rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s
From: Quentin Schulz quentin.schulz@cherry.de
On Puma v2.1 with a KSZ9031, the Ethernet PHY often doesn't detect the link in the 4-second default timeout.
After some boot-loop test for about a thousand boots, 70% were below 10s, 90% below 15s and 100% below 30s. Let's play it safe and make it 30s so that hopefully all links that should be detected are.
Signed-off-by: Quentin Schulz quentin.schulz@cherry.de --- include/configs/puma_rk3399.h | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/include/configs/puma_rk3399.h b/include/configs/puma_rk3399.h index 969acc89b93..2056a5eb2e4 100644 --- a/include/configs/puma_rk3399.h +++ b/include/configs/puma_rk3399.h @@ -6,6 +6,9 @@ #ifndef __PUMA_RK3399_H #define __PUMA_RK3399_H
+/* Highly variable timeout in getting a link on Puma v2.1 with KSZ9031 */ +#define PHY_ANEG_TIMEOUT 30000 + #include <configs/rk3399_common.h>
#endif
--- base-commit: fe2ce09a0753634543c32cafe85eb87a625f76ca change-id: 20240619-puma-eth-timeout-41be9c243ed7
Best regards,
On Wed, Jun 19, 2024 at 11:55:52AM +0200, Quentin Schulz wrote:
From: Quentin Schulz quentin.schulz@cherry.de
On Puma v2.1 with a KSZ9031, the Ethernet PHY often doesn't detect the link in the 4-second default timeout.
After some boot-loop test for about a thousand boots, 70% were below 10s, 90% below 15s and 100% below 30s. Let's play it safe and make it 30s so that hopefully all links that should be detected are.
Signed-off-by: Quentin Schulz quentin.schulz@cherry.de
include/configs/puma_rk3399.h | 3 +++ 1 file changed, 3 insertions(+)
Please rebase on -next where this is now in Kconfig.
Hi Tom,
On 6/19/24 5:22 PM, Tom Rini wrote:
On Wed, Jun 19, 2024 at 11:55:52AM +0200, Quentin Schulz wrote:
From: Quentin Schulz quentin.schulz@cherry.de
On Puma v2.1 with a KSZ9031, the Ethernet PHY often doesn't detect the link in the 4-second default timeout.
After some boot-loop test for about a thousand boots, 70% were below 10s, 90% below 15s and 100% below 30s. Let's play it safe and make it 30s so that hopefully all links that should be detected are.
Signed-off-by: Quentin Schulz quentin.schulz@cherry.de
include/configs/puma_rk3399.h | 3 +++ 1 file changed, 3 insertions(+)
Please rebase on -next where this is now in Kconfig.
It's technically a bug fix, but well... we've had it forever so one more release is probably not gonna hurt us :) Thanks for the heads up.
BTW, I believe https://source.denx.de/u-boot/u-boot/-/commit/40f5046c221a7b2719c49b51acefe1... made it through this net and should be migrated to defconfig as well in next? SO adding Michal in Cc here to trigger something if required :)
Cheers, Quentin
participants (3)
-
Quentin Schulz -
Quentin Schulz -
Tom Rini