On Fri, Apr 29, 2022 at 10:08 AM Tim Harvey tharvey@gateworks.com wrote:

The IMX8MP SoC FEC needs to have the FEC_QUIRK_ENET_MAC defined.

Fixes: commit 2395625209cc ("board: gateworks: venice: add imx8mp-venice-gw740x support") Signed-off-by: Tim Harvey tharvey@gateworks.com

---

include/configs/imx8mp_venice.h | 4 ++++ 1 file changed, 4 insertions(+)

diff --git a/include/configs/imx8mp_venice.h b/include/configs/imx8mp_venice.h index aa0396db8b83..4120e4cc6bad 100644 --- a/include/configs/imx8mp_venice.h +++ b/include/configs/imx8mp_venice.h @@ -106,4 +106,8 @@ #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16)

+/* FEC */ +#define FEC_QUIRK_ENET_MAC

#endif

2.17.1

Stefano,

Please drop this. FEC_QUIRK_ENET_MAC is defined in the imx-regs includes for imx8.

Regardless, it seems there are several imx8m board include files that are defining FEC_QUIRK_ENET_MAC in their include - I'll send a patch to remove those as they are unnecessary.

Best Regards,

Tim