[U-Boot] [PATCH] net: bugfix: NetSetTimeout assumes CONFIG_SYS_HZ=1000
NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000.
Signed-off-by: Tetsuyuki Kobayashi koba@kmckk.co.jp --- net/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c index 9de7d92..ac9c2c8 100644 --- a/net/net.c +++ b/net/net.c @@ -653,7 +653,7 @@ NetSetTimeout(ulong iv, thand_f *f) "--- NetLoop timeout handler set (%p)\n", f); timeHandler = f; timeStart = get_timer(0); - timeDelta = iv; + timeDelta = iv * CONFIG_SYS_HZ / 1000; } }
Dear Tetsuyuki Kobayashi,
In message 4FE85B87.6090302@kmckk.co.jp you wrote:
NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000.
Your patch is OK per se, but please note that it is a mandatory requirement that CONFIG_SYS_HZ == 1000. So if you have any board where this is not the case, this board needs to be fixed, too.
Best regards,
Wolfgang Denk
Dear Wolfgang Denk,
(07/09/2012 04:58 AM), Wolfgang Denk wrote:
Dear Tetsuyuki Kobayashi,
In message 4FE85B87.6090302@kmckk.co.jp you wrote:
NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000.
Your patch is OK per se, but please note that it is a mandatory requirement that CONFIG_SYS_HZ == 1000. So if you have any board where this is not the case, this board needs to be fixed, too.
Thank you for reviewing my patch.
I didn't know that it is a mandatory requirement that CONFIG_SYS_HZ == 1000. I grep'ed for CONFIG_SYS_HZ in README and under doc/, but I could not find any description about it.
$ grep -r CONFIG_SYS_HZ README doc/* doc/README.LED:(CONFIG_SYS_HZ / <N>) where <N> is the frequency of the blink. Typical values
And I couldn't find that what value should be return in ulong get_timer(ulong base); I hope "how to implement system timer" documented.
Best regards,
Tetsuyuki Kobayashi
Hi Wolfgang,
On Sun, Jul 8, 2012 at 2:58 PM, Wolfgang Denk wd@denx.de wrote:
Dear Tetsuyuki Kobayashi,
In message 4FE85B87.6090302@kmckk.co.jp you wrote:
NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000.
Your patch is OK per se, but please note that it is a mandatory requirement that CONFIG_SYS_HZ == 1000. So if you have any board where this is not the case, this board needs to be fixed, too.
If that is a hard requirement, then I don't see a point to applying this patch. I also don't know why the CONFIG_SYS_HZ variable exists.
Thanks, -Joe
Hi Tetsuyuki,
On Mon, Jun 25, 2012 at 7:37 AM, Tetsuyuki Kobayashi koba@kmckk.co.jp wrote:
NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000.
Signed-off-by: Tetsuyuki Kobayashi koba@kmckk.co.jp
I decided this doesn't hurt and it sort-of documents what "must be" (tm).
Applied, thanks.
-Joe
participants (3)
-
Joe Hershberger -
Tetsuyuki Kobayashi -
Wolfgang Denk