[U-Boot] [PATCH] config: enable CMD_BMP when API+LCD is enabled
From: Stephen Warren swarren@nvidia.com
When both CONFIG_API and CONFIG_LCD are enabled, the API code calls lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems, have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are enabled.
Signed-off-by: Stephen Warren swarren@nvidia.com --- include/config_fallbacks.h | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h index e6fb47be0bd7..b304a4103def 100644 --- a/include/config_fallbacks.h +++ b/include/config_fallbacks.h @@ -71,6 +71,10 @@ #define CONFIG_LIB_RAND #endif
+#if defined(CONFIG_API) && defined(CONFIG_LCD) +#define CONFIG_CMD_BMP +#endif + #ifndef CONFIG_SYS_PROMPT #define CONFIG_SYS_PROMPT "=> " #endif
Hi Stephen,
On 18 April 2014 11:15, Stephen Warren swarren@wwwdotorg.org wrote:
From: Stephen Warren swarren@nvidia.com
When both CONFIG_API and CONFIG_LCD are enabled, the API code calls lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems, have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are enabled.
Signed-off-by: Stephen Warren swarren@nvidia.com
Reviewed-by: Simon Glass sjg@chromium.org
I do wonder whether it might be better to #error in this case?
Regards, Simon
On 04/21/2014 05:31 PM, Simon Glass wrote:
Hi Stephen,
On 18 April 2014 11:15, Stephen Warren swarren@wwwdotorg.org wrote:
From: Stephen Warren swarren@nvidia.com
When both CONFIG_API and CONFIG_LCD are enabled, the API code calls lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems, have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are enabled.
Signed-off-by: Stephen Warren swarren@nvidia.com
Reviewed-by: Simon Glass sjg@chromium.org
I do wonder whether it might be better to #error in this case?
I see it rather like a "select" in Kconfig. (although perhaps this would end up being a depends rather than a select)
On Fri, 18 Apr 2014 11:15:55 -0600 Stephen Warren swarren@wwwdotorg.org wrote:
From: Stephen Warren swarren@nvidia.com
When both CONFIG_API and CONFIG_LCD are enabled, the API code calls lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems, have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are enabled.
Signed-off-by: Stephen Warren swarren@nvidia.com
include/config_fallbacks.h | 4 ++++ 1 file changed, 4 insertions(+)
applied to u-boot-video/master. Thanks!
Anatolij
participants (3)
-
Anatolij Gustschin -
Simon Glass -
Stephen Warren