-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

On 08/29/2013 01:26 PM, Gupta, Pekon wrote:

...

On Thu, Aug 29, 2013 at 04:26:40PM +0530, Pekon Gupta wrote:

...

*changes in v3* [PATCH 1/5] (complete change)

• ecc-scheme is selection is controller by s/w, not CONFIG_NAND_xx
• added omap_select_ecc_scheme(), as common function to handle

all

...

 ecc-scheme related configurations for both board_nand_init() &
 omap_nand_switch_ecc().

• removed un-used defines from asm/arch-am33xx/omap_gpmc.h
• updated doc/REAME.nand

[PATCH 2/5] removed un-used defines from asm/omap_gpmc.h [PATCH 3/5] removed omap_calculate_ecc_bch_sw() and

omap_calculate_ecc()

...

and merged their logic into omap_calculate_ecc_bch()

[PATCH 4/5] updated return error-code in-case of invalid conditions [PATCH 5/5] (new) for board/ti/am335x/README

Note that with the series applied, we see: NAND: nand: selected OMAP_ECC_BCH8_CODE_HW 256 MiB

The first part of string "NAND: " is coming from arch/arm/lib/board.c:582 puts("NAND: "); I'm not sure why it was added, seems legacy code.. And same is copied to all other arch/xx/lib/board.c However as this print is not giving much of info, so can this be removed ?

NAND + size is useful information.

...

I think we should move the selected message to a debug().

Second part of string "nand: selected OMAP_ECC_BCH8_CODE_HW" was specifically added in board_nand_init() because currently there is no way to identify the ECC scheme being used in u-boot. Unless digging into source code and reviewing board file. And many time end-users face ECC scheme mis-match between u-boot and linux when flashing kernel and file-system from u-boot. Thus this print helps in identifying the ECC scheme being used from logs. So, please keep this print "nand: selected <ecc-scheme>" .. ?

I'd rather not as we should have left the mis-match problems in the past. We don't generally offer commands to switch ECC schemes as everyone is using the same now. When we do need to offer switching for legacy reasons that's when we should say what we're on.

- -- Tom