[U-Boot] [PATCH v2] ARM Cortex A8: Remove bogus config.mk entries

Remove bogus config.mk entry, fix newline and remove redundant omap3/config.mk
Signed-off-by: Dirk Behme dirk.behme@googlemail.com ---
Found by Wolfgang Denk, thanks.
Compile tested with ./MAKEALL ARM_CORTEX_A8
Boot tested on BeagleBoard
This makes v1 of this patch obsolete.
cpu/arm_cortexa8/config.mk | 2 -- cpu/arm_cortexa8/omap3/config.mk | 36 ------------------------------------ 2 files changed, 38 deletions(-)
Index: u-boot-main/cpu/arm_cortexa8/config.mk =================================================================== --- u-boot-main.orig/cpu/arm_cortexa8/config.mk +++ u-boot-main/cpu/arm_cortexa8/config.mk @@ -30,7 +30,6 @@ PLATFORM_CPPFLAGS += -march=armv5 # Supply options according to compiler version # # ========================================================================= -PLATFORM_CPPFLAGS +=$(call cc-option) PLATFORM_CPPFLAGS +=$(call cc-option,-mno-thumb-interwork,) PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,\ - $(call cc-option,-malignment-traps,)) \ No newline at end of file + $(call cc-option,-malignment-traps,)) Index: u-boot-main/cpu/arm_cortexa8/omap3/config.mk =================================================================== --- u-boot-main.orig/cpu/arm_cortexa8/omap3/config.mk +++ /dev/null @@ -1,36 +0,0 @@ -# -# (C) Copyright 2002 -# Gary Jennejohn, DENX Software Engineering, garyj@denx.de -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, -# MA 02111-1307 USA -# -PLATFORM_RELFLAGS += -fno-strict-aliasing -fno-common -ffixed-r8 \ - -msoft-float - -# Make ARMv5 to allow more compilers to work, even though its v7a. -PLATFORM_CPPFLAGS += -march=armv5 -# ========================================================================= -# -# Supply options according to compiler version -# -# ========================================================================= -PLATFORM_CPPFLAGS +=$(call cc-option) -PLATFORM_CPPFLAGS +=$(call cc-option,-mno-thumb-interwork,) -PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,\ - $(call cc-option,-malignment-traps,))

Jean-Christophe PLAGNIOL-VILLARD wrote:
On 16:06 Sat 08 Aug , Dirk Behme wrote:
Remove bogus config.mk entry, fix newline and remove redundant omap3/config.mk
do not do this in one step
do this in two step
NACK. It's totally fine to have this in one patch to encapsulate this clean up.
Best regards
Dirk

On 16:36 Sat 08 Aug , Dirk Behme wrote:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 16:06 Sat 08 Aug , Dirk Behme wrote:
Remove bogus config.mk entry, fix newline and remove redundant omap3/config.mk
do not do this in one step
do this in two step
NACK. It's totally fine to have this in one patch to encapsulate this clean up.
NACK you remove a file and fix a generic arch file this need to be done in 2 steps to bisect it
Best Regards, J.

Dear Jean-Christophe,
In message 20090808145901.GB17045@game.jcrosoft.org you wrote:
On 16:36 Sat 08 Aug , Dirk Behme wrote:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 16:06 Sat 08 Aug , Dirk Behme wrote:
Remove bogus config.mk entry, fix newline and remove redundant omap3/config.mk
do not do this in one step
do this in two step
NACK. It's totally fine to have this in one patch to encapsulate this clean up.
NACK you remove a file and fix a generic arch file this need to be done in 2 steps to bisect it
Come on, be reasonable. This actually _is_ an atomic fix for one problem, that affects two files.
If it was not for the Signed-off-by: messages I'd recommend Dirk to post his patches under a pseudonym to avoid triggering your flamewar mode with each and every of his postings.
*Please* calm down and get back to a working mode where we do make some progress with the project instead of having endless silly fighting all over the place.
Best regards,
Wolfgang Denk

Dear Dirk Behme,
In message 1249740407-14109-1-git-send-email-dirk.behme@googlemail.com you wrote:
Remove bogus config.mk entry, fix newline and remove redundant omap3/config.mk
Signed-off-by: Dirk Behme dirk.behme@googlemail.com
Found by Wolfgang Denk, thanks.
Compile tested with ./MAKEALL ARM_CORTEX_A8
Boot tested on BeagleBoard
This makes v1 of this patch obsolete.
cpu/arm_cortexa8/config.mk | 2 -- cpu/arm_cortexa8/omap3/config.mk | 36 ------------------------------------ 2 files changed, 38 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (3)
-
Dirk Behme
-
Jean-Christophe PLAGNIOL-VILLARD
-
Wolfgang Denk