[PATCH] arm: dts: i.mx8x: add #cooling-cells properties
Fix dtb building warnings: Warning (cooling_device_property): /thermal-zones/cpu-thermal0/cooling-maps/map0: Missing property '#cooling-cells' in node /cpus/cpu@0 or bad phandle (referred from cooling-device[0])
Signed-off-by: Anatolij Gustschin agust@denx.de --- arch/arm/dts/fsl-imx8-ca35.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/fsl-imx8-ca35.dtsi b/arch/arm/dts/fsl-imx8-ca35.dtsi index 28bc32c8b7..9af8b1511c 100644 --- a/arch/arm/dts/fsl-imx8-ca35.dtsi +++ b/arch/arm/dts/fsl-imx8-ca35.dtsi @@ -18,6 +18,7 @@ reg = <0x0 0x0>; enable-method = "psci"; next-level-cache = <&A35_L2>; + #cooling-cells = <2>; };
A35_1: cpu@1 { @@ -26,6 +27,7 @@ reg = <0x0 0x1>; enable-method = "psci"; next-level-cache = <&A35_L2>; + #cooling-cells = <2>; };
A35_2: cpu@2 { @@ -34,6 +36,7 @@ reg = <0x0 0x2>; enable-method = "psci"; next-level-cache = <&A35_L2>; + #cooling-cells = <2>; };
A35_3: cpu@3 { @@ -42,6 +45,7 @@ reg = <0x0 0x3>; enable-method = "psci"; next-level-cache = <&A35_L2>; + #cooling-cells = <2>; };
A35_L2: l2-cache0 {
On 18/01/20 16:12, Anatolij Gustschin wrote:
Fix dtb building warnings: Warning (cooling_device_property): /thermal-zones/cpu-thermal0/cooling-maps/map0: Missing property '#cooling-cells' in node /cpus/cpu@0 or bad phandle (referred from cooling-device[0])
Thanks for fixing this.
Signed-off-by: Anatolij Gustschin agust@denx.de
arch/arm/dts/fsl-imx8-ca35.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/fsl-imx8-ca35.dtsi b/arch/arm/dts/fsl-imx8-ca35.dtsi index 28bc32c8b7..9af8b1511c 100644 --- a/arch/arm/dts/fsl-imx8-ca35.dtsi +++ b/arch/arm/dts/fsl-imx8-ca35.dtsi @@ -18,6 +18,7 @@ reg = <0x0 0x0>; enable-method = "psci"; next-level-cache = <&A35_L2>;
#cooling-cells = <2>;};
A35_1: cpu@1 {
@@ -26,6 +27,7 @@ reg = <0x0 0x1>; enable-method = "psci"; next-level-cache = <&A35_L2>;
#cooling-cells = <2>;};
A35_2: cpu@2 {
@@ -34,6 +36,7 @@ reg = <0x0 0x2>; enable-method = "psci"; next-level-cache = <&A35_L2>;
#cooling-cells = <2>;};
A35_3: cpu@3 {
@@ -42,6 +45,7 @@ reg = <0x0 0x3>; enable-method = "psci"; next-level-cache = <&A35_L2>;
#cooling-cells = <2>;};
A35_L2: l2-cache0 {
Reviewed-by: Stefano Babic sbabic@denx.de
Best regards, Stefano Babic
On Sat, Jan 18, 2020 at 12:12 PM Anatolij Gustschin agust@denx.de wrote:
Fix dtb building warnings: Warning (cooling_device_property): /thermal-zones/cpu-thermal0/cooling-maps/map0: Missing property '#cooling-cells' in node /cpus/cpu@0 or bad phandle (referred from cooling-device[0])
Signed-off-by: Anatolij Gustschin agust@denx.de
arch/arm/dts/fsl-imx8-ca35.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/fsl-imx8-ca35.dtsi b/arch/arm/dts/fsl-imx8-ca35.dtsi index 28bc32c8b7..9af8b1511c 100644 --- a/arch/arm/dts/fsl-imx8-ca35.dtsi +++ b/arch/arm/dts/fsl-imx8-ca35.dtsi @@ -18,6 +18,7 @@ reg = <0x0 0x0>; enable-method = "psci"; next-level-cache = <&A35_L2>;
#cooling-cells = <2>;
Yes, this matches arch/arm64/boot/dts/freescale/imx8qxp.dtsi upstream.
Maybe we should sync with upstream at some point.
Reviewed-by: Fabio Estevam festevam@gmail.com
Subject: Re: [PATCH] arm: dts: i.mx8x: add #cooling-cells properties
On Sat, Jan 18, 2020 at 12:12 PM Anatolij Gustschin agust@denx.de wrote:
Fix dtb building warnings: Warning (cooling_device_property):
/thermal-zones/cpu-thermal0/cooling-maps/map0:
Missing property '#cooling-cells' in node /cpus/cpu@0 or bad phandle (referred from cooling-device[0])
Signed-off-by: Anatolij Gustschin agust@denx.de
arch/arm/dts/fsl-imx8-ca35.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/fsl-imx8-ca35.dtsi b/arch/arm/dts/fsl-imx8-ca35.dtsi index 28bc32c8b7..9af8b1511c 100644 --- a/arch/arm/dts/fsl-imx8-ca35.dtsi +++ b/arch/arm/dts/fsl-imx8-ca35.dtsi @@ -18,6 +18,7 @@ reg = <0x0 0x0>; enable-method = "psci"; next-level-cache = <&A35_L2>;
#cooling-cells = <2>;Yes, this matches arch/arm64/boot/dts/freescale/imx8qxp.dtsi upstream.
Maybe we should sync with upstream at some point.
I am still waiting Aisheng to finish the i.MX8QM and dts restructure, Aisheng did a big restructure. If import earlier, we have to import and adapt again.
Thanks, Peng.
Reviewed-by: Fabio Estevam festevam@gmail.com
Fix dtb building warnings: Warning (cooling_device_property): /thermal-zones/cpu-thermal0/cooling-maps/map0: Missing property '#cooling-cells' in node /cpus/cpu@0 or bad phandle (referred from cooling-device[0]) Signed-off-by: Anatolij Gustschin agust@denx.de Reviewed-by: Stefano Babic sbabic@denx.de Reviewed-by: Fabio Estevam festevam@gmail.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
participants (5)
-
Anatolij Gustschin -
Fabio Estevam -
Peng Fan -
sbabic＠denx.de -
Stefano Babic