[U-Boot] [PATCH] EXYNOS: Move includes from setup.h to tzpc_init.c
These should not be in the header since not every C file needs them. Move them to the file that needs them.
Signed-off-by: Simon Glass sjg@chromium.org Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com --- board/samsung/smdk5250/setup.h | 3 --- board/samsung/smdk5250/tzpc_init.c | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/board/samsung/smdk5250/setup.h b/board/samsung/smdk5250/setup.h index 34d8bc3..68f48ea 100644 --- a/board/samsung/smdk5250/setup.h +++ b/board/samsung/smdk5250/setup.h @@ -25,9 +25,6 @@ #ifndef _SMDK5250_SETUP_H #define _SMDK5250_SETUP_H
-#include <config.h> -#include <asm/arch/dmc.h> - /* TZPC : Register Offsets */ #define TZPC0_BASE 0x10100000 #define TZPC1_BASE 0x10110000 diff --git a/board/samsung/smdk5250/tzpc_init.c b/board/samsung/smdk5250/tzpc_init.c index c833541..96e5a6c 100644 --- a/board/samsung/smdk5250/tzpc_init.c +++ b/board/samsung/smdk5250/tzpc_init.c @@ -22,6 +22,8 @@ * MA 02111-1307 USA */
+#include <config.h> +#include <asm/arch/dmc.h> #include <asm/arch/tzpc.h> #include"setup.h"
On Wed, Apr 3, 2013 at 6:11 AM, Rajeshwari Shinde rajeshwari.s@samsung.com wrote:
These should not be in the header since not every C file needs them. Move them to the file that needs them.
Signed-off-by: Simon Glass sjg@chromium.org Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com
Tested on snow.
Acked-by: Simon Glass sjg@chromium.org Tested-by: Simon Glass sjg@chromium.org
board/samsung/smdk5250/setup.h | 3 --- board/samsung/smdk5250/tzpc_init.c | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/board/samsung/smdk5250/setup.h b/board/samsung/smdk5250/setup.h index 34d8bc3..68f48ea 100644 --- a/board/samsung/smdk5250/setup.h +++ b/board/samsung/smdk5250/setup.h @@ -25,9 +25,6 @@ #ifndef _SMDK5250_SETUP_H #define _SMDK5250_SETUP_H
-#include <config.h> -#include <asm/arch/dmc.h>
/* TZPC : Register Offsets */ #define TZPC0_BASE 0x10100000 #define TZPC1_BASE 0x10110000 diff --git a/board/samsung/smdk5250/tzpc_init.c b/board/samsung/smdk5250/tzpc_init.c index c833541..96e5a6c 100644 --- a/board/samsung/smdk5250/tzpc_init.c +++ b/board/samsung/smdk5250/tzpc_init.c @@ -22,6 +22,8 @@
- MA 02111-1307 USA
*/
+#include <config.h> +#include <asm/arch/dmc.h> #include <asm/arch/tzpc.h> #include"setup.h"
-- 1.7.4.4
On 12/05/13 03:19, Simon Glass wrote:
On Wed, Apr 3, 2013 at 6:11 AM, Rajeshwari Shinde rajeshwari.s@samsung.com wrote:
These should not be in the header since not every C file needs them. Move them to the file that needs them.
Signed-off-by: Simon Glass sjg@chromium.org Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com
Tested on snow.
Acked-by: Simon Glass sjg@chromium.org Tested-by: Simon Glass sjg@chromium.org
board/samsung/smdk5250/setup.h | 3 --- board/samsung/smdk5250/tzpc_init.c | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-)
Since tzpc_init.c is moved to arch/arm/cpu/armv7/exynos, this patch is rejected.
commit 72af2fc8504daccd2f8ae2459e3e225e9c2cc512 Author: Inderpal Singh inderpal.singh@linaro.org Date: Thu Apr 4 23:09:19 2013 +0000
exynos: move tzpc_init to armv7/exynos
tzpc_init is common for all exynos5 boards, hence move it to armv7/exynos so that all other boards can use it.
Also update the smdk5250 Makefile and config file.
Signed-off-by: Inderpal Singh inderpal.singh@linaro.org Acked-by: Chander Kashyap chander.kashyap@linaro.org Signed-off-by: Minkyu Kang mk7.kang@samsung.com
Thanks, Minkyu Kang.
participants (3)
-
Minkyu Kang -
Rajeshwari Shinde -
Simon Glass