[PATCH 1/3] cosmetic: README: Fix one CONFIG name
Only replace CONFIF_ by CONFIG_
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com ---
README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/README b/README index 8cfa92fac9..6cb7656fa0 100644 --- a/README +++ b/README @@ -1640,7 +1640,7 @@ The following options need to be configured: - CONFIG_SYS_RCAR_I2C2_SPEED for for the speed channel 2 - CONFIG_SYS_RCAR_I2C3_BASE for setting the register channel 3 - CONFIG_SYS_RCAR_I2C3_SPEED for for the speed channel 3 - - CONFIF_SYS_RCAR_I2C_NUM_CONTROLLERS for number of i2c buses + - CONFIG_SYS_RCAR_I2C_NUM_CONTROLLERS for number of i2c buses
- drivers/i2c/sh_i2c.c: - activate this driver with CONFIG_SYS_I2C_SH
Remove the references in README on CONFIG_SYS_RCAR_I2C_* not use in U-Boot drivers/i2c/rcar_i2c.c, since commit a4d9aafadb31 ("i2c: rcar_i2c: Remove the driver") and commit a06a0ac36d59 ("i2c: rcar_i2c: Add DM and DT capable I2C driver")
Checked by the command: grep -r SYS_RCAR_I2C * And these CONFIG are only defined in arch/arm/mach-rmobile/include/mach/rcar-base.h
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com ---
README | 10 ---------- 1 file changed, 10 deletions(-)
diff --git a/README b/README index 6cb7656fa0..3cc99f0805 100644 --- a/README +++ b/README @@ -1632,16 +1632,6 @@ The following options need to be configured: - activate this driver with CONFIG_SYS_I2C_RCAR - This driver adds 4 i2c buses
- - CONFIG_SYS_RCAR_I2C0_BASE for setting the register channel 0 - - CONFIG_SYS_RCAR_I2C0_SPEED for for the speed channel 0 - - CONFIG_SYS_RCAR_I2C1_BASE for setting the register channel 1 - - CONFIG_SYS_RCAR_I2C1_SPEED for for the speed channel 1 - - CONFIG_SYS_RCAR_I2C2_BASE for setting the register channel 2 - - CONFIG_SYS_RCAR_I2C2_SPEED for for the speed channel 2 - - CONFIG_SYS_RCAR_I2C3_BASE for setting the register channel 3 - - CONFIG_SYS_RCAR_I2C3_SPEED for for the speed channel 3 - - CONFIG_SYS_RCAR_I2C_NUM_CONTROLLERS for number of i2c buses - - drivers/i2c/sh_i2c.c: - activate this driver with CONFIG_SYS_I2C_SH - This driver adds from 2 to 5 i2c buses
On Fri, 10 Apr 2020 at 08:34, Patrick Delaunay patrick.delaunay@st.com wrote:
Remove the references in README on CONFIG_SYS_RCAR_I2C_* not use in U-Boot drivers/i2c/rcar_i2c.c, since commit a4d9aafadb31 ("i2c: rcar_i2c: Remove the driver") and commit a06a0ac36d59 ("i2c: rcar_i2c: Add DM and DT capable I2C driver")
Checked by the command: grep -r SYS_RCAR_I2C * And these CONFIG are only defined in arch/arm/mach-rmobile/include/mach/rcar-base.h
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com
README | 10 ---------- 1 file changed, 10 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
Nice clean-up.
On Fri, Apr 10, 2020 at 04:34:41PM +0200, Patrick Delaunay wrote:
Remove the references in README on CONFIG_SYS_RCAR_I2C_* not use in U-Boot drivers/i2c/rcar_i2c.c, since commit a4d9aafadb31 ("i2c: rcar_i2c: Remove the driver") and commit a06a0ac36d59 ("i2c: rcar_i2c: Add DM and DT capable I2C driver")
Checked by the command: grep -r SYS_RCAR_I2C * And these CONFIG are only defined in arch/arm/mach-rmobile/include/mach/rcar-base.h
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
As this "CONFIG" are never used, CONFIG_SYS_RCAR_I2C*_BASE can be removed without effect and the file config_whitelist.txt is also clean-up.
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com ---
arch/arm/mach-rmobile/include/mach/rcar-base.h | 6 ------ scripts/config_whitelist.txt | 4 ---- 2 files changed, 10 deletions(-)
diff --git a/arch/arm/mach-rmobile/include/mach/rcar-base.h b/arch/arm/mach-rmobile/include/mach/rcar-base.h index a20740679f..811a1183ba 100644 --- a/arch/arm/mach-rmobile/include/mach/rcar-base.h +++ b/arch/arm/mach-rmobile/include/mach/rcar-base.h @@ -78,12 +78,6 @@ #define CONFIG_SYS_I2C_SH_BASE0 0xE6500000 #define CONFIG_SYS_I2C_SH_BASE1 0xE6510000
-/* RCAR-I2C */ -#define CONFIG_SYS_RCAR_I2C0_BASE 0xE6508000 -#define CONFIG_SYS_RCAR_I2C1_BASE 0xE6518000 -#define CONFIG_SYS_RCAR_I2C2_BASE 0xE6530000 -#define CONFIG_SYS_RCAR_I2C3_BASE 0xE6540000 - /* SDHI */ #define CONFIG_SYS_SH_SDHI0_BASE 0xEE100000
diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index 0f747ac0a3..0f9d8cb0d7 100644 --- a/scripts/config_whitelist.txt +++ b/scripts/config_whitelist.txt @@ -3668,10 +3668,6 @@ CONFIG_SYS_QRIO_BR_PRELIM CONFIG_SYS_QRIO_OR_PRELIM CONFIG_SYS_R7780MP_OLD_FLASH CONFIG_SYS_RAMBOOT -CONFIG_SYS_RCAR_I2C0_BASE -CONFIG_SYS_RCAR_I2C1_BASE -CONFIG_SYS_RCAR_I2C2_BASE -CONFIG_SYS_RCAR_I2C3_BASE CONFIG_SYS_RCWH_PCIHOST CONFIG_SYS_READ_SPD CONFIG_SYS_RESET_ADDR
On 4/10/20 4:34 PM, Patrick Delaunay wrote:
As this "CONFIG" are never used, CONFIG_SYS_RCAR_I2C*_BASE can be removed without effect and the file config_whitelist.txt is also clean-up.
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com
arch/arm/mach-rmobile/include/mach/rcar-base.h | 6 ------ scripts/config_whitelist.txt | 4 ---- 2 files changed, 10 deletions(-)
Update the README too, otherwise look good, thanks.
Dear Marek,
From: Marek Vasut marex@denx.de Sent: vendredi 10 avril 2020 18:44
On 4/10/20 4:34 PM, Patrick Delaunay wrote:
As this "CONFIG" are never used, CONFIG_SYS_RCAR_I2C*_BASE can be removed without effect and the file config_whitelist.txt is also clean-up.
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com
arch/arm/mach-rmobile/include/mach/rcar-base.h | 6 ------ scripts/config_whitelist.txt | 4 ---- 2 files changed, 10 deletions(-)
Update the README too, otherwise look good, thanks.
Done in a separate patch as I clean all the CONFIG no more used in this driver
[PATCH 2/3] README: remove references on no more used config CONFIG_SYS_RCAR_I2C*
I didn't add you in CC for the serie, sorry.
http://patchwork.ozlabs.org/project/uboot/list/?series=169619
Regards
Patrick
On Fri, 10 Apr 2020 at 08:34, Patrick Delaunay patrick.delaunay@st.com wrote:
Only replace CONFIF_ by CONFIG_
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com
README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
On Fri, Apr 10, 2020 at 04:34:40PM +0200, Patrick Delaunay wrote:
Only replace CONFIF_ by CONFIG_
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (5)
-
Marek Vasut -
Patrick DELAUNAY -
Patrick Delaunay
-
Simon Glass -
Tom Rini