[U-Boot] [PATCH] s3c64xx: Add ifdef at the S3C64XX only codes

The pheripheral port address(0x70000000 - 0x7fffffff) exists at only S3C64XX cpu. The pheripheral port setup codes should be executed by only S3C64XX cpu.
Signed-off-by: Joonyoung Shim jy0922.shim@samsung.com --- cpu/arm1176/start.S | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/cpu/arm1176/start.S b/cpu/arm1176/start.S index 68a356d..5d9fba9 100644 --- a/cpu/arm1176/start.S +++ b/cpu/arm1176/start.S @@ -190,10 +190,12 @@ mmu_disable: #endif
mmu_disable_phys: +#ifdef CONFIG_S3C64XX /* Peri port setup */ ldr r0, =0x70000000 orr r0, r0, #0x13 mcr p15,0,r0,c15,c2,4 @ 256M (0x70000000 - 0x7fffffff) +#endif
/* * Go setup Memory and board specific bits prior to relocation.

On 2/8/2010 7:55 PM, Joonyoung Shim wrote:
The pheripheral port address(0x70000000 - 0x7fffffff) exists at only S3C64XX cpu. The pheripheral port setup codes should be executed by only S3C64XX cpu.
Signed-off-by: Joonyoung Shim jy0922.shim@samsung.com
cpu/arm1176/start.S | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
Sorry, i missed something. Please use the below patch.
From 89017aa05e1cbb94aeddb3625584eca474d57684 Mon Sep 17 00:00:00 2001
From: Joonyoung Shim jy0922.shim@samsung.com Date: Mon, 8 Feb 2010 20:25:23 +0900 Subject: [PATCH] s3c64xx: Add ifdef at the S3C64XX only codes
The s3c6400.h file is only for S3C64XX cpu and the pheripheral port address(0x70000000 - 0x7fffffff) exists at only S3C64XX cpu, so they should be included by only S3C64XX cpu.
Signed-off-by: Joonyoung Shim jy0922.shim@samsung.com --- cpu/arm1176/cpu.c | 2 ++ cpu/arm1176/start.S | 4 ++++ 2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/cpu/arm1176/cpu.c b/cpu/arm1176/cpu.c index 2c0014f..befa0cd 100644 --- a/cpu/arm1176/cpu.c +++ b/cpu/arm1176/cpu.c @@ -33,7 +33,9 @@
#include <common.h> #include <command.h> +#ifdef CONFIG_S3C64XX #include <asm/arch/s3c6400.h> +#endif #include <asm/system.h>
static void cache_flush (void); diff --git a/cpu/arm1176/start.S b/cpu/arm1176/start.S index 68a356d..e2b6c9b 100644 --- a/cpu/arm1176/start.S +++ b/cpu/arm1176/start.S @@ -35,7 +35,9 @@ #ifdef CONFIG_ENABLE_MMU #include <asm/proc/domain.h> #endif +#ifdef CONFIG_S3C64XX #include <asm/arch/s3c6400.h> +#endif
#if !defined(CONFIG_ENABLE_MMU) && !defined(CONFIG_SYS_PHY_UBOOT_BASE) #define CONFIG_SYS_PHY_UBOOT_BASE CONFIG_SYS_UBOOT_BASE @@ -190,10 +192,12 @@ mmu_disable: #endif
mmu_disable_phys: +#ifdef CONFIG_S3C64XX /* Peri port setup */ ldr r0, =0x70000000 orr r0, r0, #0x13 mcr p15,0,r0,c15,c2,4 @ 256M (0x70000000 - 0x7fffffff) +#endif
/* * Go setup Memory and board specific bits prior to relocation.

Dear Joonyoung Shim,
On 8 February 2010 20:23, Joonyoung Shim jy0922.shim@samsung.com wrote:
On 2/8/2010 7:55 PM, Joonyoung Shim wrote:
The pheripheral port address(0x70000000 - 0x7fffffff) exists at only S3C64XX cpu. The pheripheral port setup codes should be executed by only S3C64XX cpu.
Signed-off-by: Joonyoung Shim jy0922.shim@samsung.com
cpu/arm1176/start.S | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
Sorry, i missed something. Please use the below patch.
From 89017aa05e1cbb94aeddb3625584eca474d57684 Mon Sep 17 00:00:00 2001 From: Joonyoung Shim jy0922.shim@samsung.com Date: Mon, 8 Feb 2010 20:25:23 +0900 Subject: [PATCH] s3c64xx: Add ifdef at the S3C64XX only codes
The s3c6400.h file is only for S3C64XX cpu and the pheripheral port address(0x70000000 - 0x7fffffff) exists at only S3C64XX cpu, so they should be included by only S3C64XX cpu.
Signed-off-by: Joonyoung Shim jy0922.shim@samsung.com
cpu/arm1176/cpu.c | 2 ++ cpu/arm1176/start.S | 4 ++++ 2 files changed, 6 insertions(+), 0 deletions(-)
Please add a version to the subject (like "[PATCH v2]"). So please resend the patch version 2.
Thanks Minkyu Kang
participants (2)
-
Joonyoung Shim
-
Minkyu Kang