[PATCH] net: renesas: Enable TFTP_TSIZE on all Renesas hardware

TFTP transfer size can be used to re-size the TFTP progress bar on single line based on the server reported file size. Enable it by default for Renesas hardware to avoid long scrolling walls of '#' character during long TFTP transfers.
Signed-off-by: Marek Vasut marek.vasut+renesas@mailbox.org --- Cc: Adriano Cordova adrianox@gmail.com Cc: Anand Moon linux.amoon@gmail.com Cc: Baruch Siach baruch@tkos.co.il Cc: Ilias Apalodimas ilias.apalodimas@linaro.org Cc: Jerome Forissier jerome.forissier@linaro.org Cc: Joe Hershberger joe.hershberger@ni.com Cc: Ramon Fried rfried.dev@gmail.com Cc: Tom Rini trini@konsulko.com Cc: u-boot@lists.denx.de --- NOTE: I wonder, shall we simply enable this by default ? --- net/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/Kconfig b/net/Kconfig index b4bb68dd613..24508026200 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -90,7 +90,7 @@ config TFTP_WINDOWSIZE config TFTP_TSIZE bool "Track TFTP transfers based on file size option" depends on CMD_TFTPBOOT - default y if (ARCH_OMAP2PLUS || ARCH_K3) + default y if (ARCH_OMAP2PLUS || ARCH_K3 || ARCH_RENESAS) help By default, TFTP progress bar is increased for each received UDP frame, which can lead into long time being spent for sending

On Wed, Dec 18, 2024 at 08:41:28PM +0100, Marek Vasut wrote:
TFTP transfer size can be used to re-size the TFTP progress bar on single line based on the server reported file size. Enable it by default for Renesas hardware to avoid long scrolling walls of '#' character during long TFTP transfers.
Signed-off-by: Marek Vasut marek.vasut+renesas@mailbox.org
Cc: Adriano Cordova adrianox@gmail.com Cc: Anand Moon linux.amoon@gmail.com Cc: Baruch Siach baruch@tkos.co.il Cc: Ilias Apalodimas ilias.apalodimas@linaro.org Cc: Jerome Forissier jerome.forissier@linaro.org Cc: Joe Hershberger joe.hershberger@ni.com Cc: Ramon Fried rfried.dev@gmail.com Cc: Tom Rini trini@konsulko.com Cc: u-boot@lists.denx.de
NOTE: I wonder, shall we simply enable this by default ?
Any chance you did a size comparison before/after this patch? That'd be handy to know for making this default for everyone.

On 12/18/24 8:43 PM, Tom Rini wrote:
On Wed, Dec 18, 2024 at 08:41:28PM +0100, Marek Vasut wrote:
TFTP transfer size can be used to re-size the TFTP progress bar on single line based on the server reported file size. Enable it by default for Renesas hardware to avoid long scrolling walls of '#' character during long TFTP transfers.
Signed-off-by: Marek Vasut marek.vasut+renesas@mailbox.org
Cc: Adriano Cordova adrianox@gmail.com Cc: Anand Moon linux.amoon@gmail.com Cc: Baruch Siach baruch@tkos.co.il Cc: Ilias Apalodimas ilias.apalodimas@linaro.org Cc: Jerome Forissier jerome.forissier@linaro.org Cc: Joe Hershberger joe.hershberger@ni.com Cc: Ramon Fried rfried.dev@gmail.com Cc: Tom Rini trini@konsulko.com Cc: u-boot@lists.denx.de
NOTE: I wonder, shall we simply enable this by default ?
Any chance you did a size comparison before/after this patch? That'd be handy to know for making this default for everyone.
r8a779f0_spider_defconfig
without: 744640 with: 752824
So maybe this is not for everyone.

On Wed, Dec 18, 2024 at 10:02:36PM +0100, Marek Vasut wrote:
On 12/18/24 8:43 PM, Tom Rini wrote:
On Wed, Dec 18, 2024 at 08:41:28PM +0100, Marek Vasut wrote:
TFTP transfer size can be used to re-size the TFTP progress bar on single line based on the server reported file size. Enable it by default for Renesas hardware to avoid long scrolling walls of '#' character during long TFTP transfers.
Signed-off-by: Marek Vasut marek.vasut+renesas@mailbox.org
Cc: Adriano Cordova adrianox@gmail.com Cc: Anand Moon linux.amoon@gmail.com Cc: Baruch Siach baruch@tkos.co.il Cc: Ilias Apalodimas ilias.apalodimas@linaro.org Cc: Jerome Forissier jerome.forissier@linaro.org Cc: Joe Hershberger joe.hershberger@ni.com Cc: Ramon Fried rfried.dev@gmail.com Cc: Tom Rini trini@konsulko.com Cc: u-boot@lists.denx.de
NOTE: I wonder, shall we simply enable this by default ?
Any chance you did a size comparison before/after this patch? That'd be handy to know for making this default for everyone.
r8a779f0_spider_defconfig
without: 744640 with: 752824
So maybe this is not for everyone.
Indeed, thanks for checking.
participants (3)
-
Marek Vasut
-
Marek Vasut
-
Tom Rini