On 2024-01-04 17:03, Caleb Connolly wrote:

Sometimes, when only one bootdev is available, and it fails to probe, we end up in an infinite loop calling probe() on the same device over and over. With only debug level log output.

Break the loop if we fail to probe the same device twice in a row, and promote the probe failure message to log_warning().

Signed-off-by: Caleb Connolly caleb.connolly@linaro.org

Looks good to me.

Reviewed-by: Dragan Simic dsimic@manjaro.org

---

Resend, actually change log message to WARN loglevel.

boot/bootdev-uclass.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c index d01d603700d9..cd1c2bc06774 100644 --- a/boot/bootdev-uclass.c +++ b/boot/bootdev-uclass.c @@ -636,7 +636,7 @@ int bootdev_next_label(struct bootflow_iter *iter, struct udevice **devp,

int bootdev_next_prio(struct bootflow_iter *iter, struct udevice **devp) {

• struct udevice *dev = *devp;

• struct udevice *dev = *devp, *last_dev = NULL; bool found; int ret;

@@ -686,9 +686,19 @@ int bootdev_next_prio(struct bootflow_iter *iter, struct udevice **devp) } } else { ret = device_probe(dev);

• 	if (!ret)
  

• 		last_dev = dev;
  if (ret) {
  

• 		log_debug("Device '%s' failed to probe\n",
  

• 		log_warning("Device '%s' failed to probe\n",
  		  dev->name);
  

• 		if (last_dev == dev) {
  

• 			/*
  

• 			 * We have already tried this device
  

• 			 * and it failed to probe. Give up.
  

• 			 */
  

• 			return log_msg_ret("probe", ret);
  

• 		}
  

• 		last_dev = dev;
  	dev = NULL;
  }
  

  }