[U-Boot] Warning due to commit 6a516ef15d79

Hi Lothar,
your recent patch :
commit 306dd7dabd6472b8b66ab5106d5a6a516ef15d79 Author: Lothar Waßmann LW@KARO-electronics.de Date: Tue Jun 27 15:23:16 2017 +0200
net: fec_mxc: fix PHY initialization bug with CONFIG_DM_ETH
is cause of warnings in several i.MX boards, such as:
arm: + imx6ul_geam_nand + struct udevice *vqmmc_dev; + ^ + bus = fec_get_miibus(dev, dev_id); + ^ +drivers/net/fec_mxc.c:988:17: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'struct udevice *' + struct mii_dev *fec_get_miibus(uint32_t base_addr, int dev_id) + ^
In fact, dev is a udevice and not an int as the prototype for fec_get_miibus(). Could you take a look, please ? Thanks !
Best regards, Stefano Babic

Hi Stefano,
On Wed, 12 Jul 2017 10:45:21 +0200 Stefano Babic wrote:
Hi Lothar,
your recent patch :
commit 306dd7dabd6472b8b66ab5106d5a6a516ef15d79 Author: Lothar Waßmann LW@KARO-electronics.de Date: Tue Jun 27 15:23:16 2017 +0200
net: fec_mxc: fix PHY initialization bug with CONFIG_DM_ETH
is cause of warnings in several i.MX boards, such as:
arm: + imx6ul_geam_nand
- struct udevice *vqmmc_dev;
^
- bus = fec_get_miibus(dev, dev_id);
^
+drivers/net/fec_mxc.c:988:17: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'struct udevice *'
- struct mii_dev *fec_get_miibus(uint32_t base_addr, int dev_id)
^
In fact, dev is a udevice and not an int as the prototype for fec_get_miibus(). Could you take a look, please ? Thanks !
Should I resend a corrected version, or a fixup on top of this patch?
Lothar Waßmann

Hi Lothar,
On 12/07/2017 13:44, Lothar Waßmann wrote:
Hi Stefano,
On Wed, 12 Jul 2017 10:45:21 +0200 Stefano Babic wrote:
Hi Lothar,
your recent patch :
commit 306dd7dabd6472b8b66ab5106d5a6a516ef15d79 Author: Lothar Waßmann LW@KARO-electronics.de Date: Tue Jun 27 15:23:16 2017 +0200
net: fec_mxc: fix PHY initialization bug with CONFIG_DM_ETH
is cause of warnings in several i.MX boards, such as:
arm: + imx6ul_geam_nand
- struct udevice *vqmmc_dev;
^
- bus = fec_get_miibus(dev, dev_id);
^
+drivers/net/fec_mxc.c:988:17: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'struct udevice *'
- struct mii_dev *fec_get_miibus(uint32_t base_addr, int dev_id)
^
In fact, dev is a udevice and not an int as the prototype for fec_get_miibus(). Could you take a look, please ? Thanks !
Should I resend a corrected version, or a fixup on top of this patch?
I have already merge to let easy to test it. Just send a fixup that I will merge before sending my PR to Tom - thanks !
Best regards, Stefano
participants (2)
-
Lothar Waßmann
-
Stefano Babic