[PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by: Michal Suchanek msuchanek@suse.de ---
This is not tested, my board does not currentl;y boot at all, YMMV --- arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 8 -------- 1 file changed, 8 deletions(-)
diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi index 2d87bea933..fd87102c0b 100644 --- a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi +++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi @@ -20,14 +20,6 @@ rockchip,panel = <&edp_panel>; };
-&i2c0 { - u-boot,dm-pre-reloc; -}; - -&rk808 { - u-boot,dm-pre-reloc; -}; - &sdhci { max-frequency = <25000000>; u-boot,dm-pre-reloc;
On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek msuchanek@suse.de wrote:
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by: Michal Suchanek msuchanek@suse.de
Reviewed-by: Peter Robinson pbrobinson@gmail.com Tested-by: Peter Robinson pbrobinson@gmail.com
Thanks for checking this out, I had noticed a regression and had got as far as bisecting it but not getting to a fix.
Tom: can we get this pulled into 2023.01 please?
Peter
This is not tested, my board does not currentl;y boot at all, YMMV
arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 8 -------- 1 file changed, 8 deletions(-)
diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi index 2d87bea933..fd87102c0b 100644 --- a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi +++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi @@ -20,14 +20,6 @@ rockchip,panel = <&edp_panel>; };
-&i2c0 {
u-boot,dm-pre-reloc;-};
-&rk808 {
u-boot,dm-pre-reloc;-};
&sdhci { max-frequency = <25000000>; u-boot,dm-pre-reloc; -- 2.38.1
On Mon, Dec 05, 2022 at 09:35:41PM +0000, Peter Robinson wrote:
On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek msuchanek@suse.de wrote:
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by: Michal Suchanek msuchanek@suse.de
Reviewed-by: Peter Robinson pbrobinson@gmail.com Tested-by: Peter Robinson pbrobinson@gmail.com
Thanks for checking this out, I had noticed a regression and had got as far as bisecting it but not getting to a fix.
Tom: can we get this pulled into 2023.01 please?
Probably should be, yes. Kever, are there any other rockchip must-fixes for v2023.01? I can take this directly if you don't have others and/or don't want to make up a PR, thanks!
Hi,
On Tue, 6 Dec 2022 at 11:25, Tom Rini trini@konsulko.com wrote:
On Mon, Dec 05, 2022 at 09:35:41PM +0000, Peter Robinson wrote:
On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek msuchanek@suse.de wrote:
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by: Michal Suchanek msuchanek@suse.de
Reviewed-by: Peter Robinson pbrobinson@gmail.com Tested-by: Peter Robinson pbrobinson@gmail.com
Thanks for checking this out, I had noticed a regression and had got as far as bisecting it but not getting to a fix.
Tom: can we get this pulled into 2023.01 please?
Probably should be, yes. Kever, are there any other rockchip must-fixes for v2023.01? I can take this directly if you don't have others and/or don't want to make up a PR, thanks!
There is also this one:
https://patchwork.ozlabs.org/project/uboot/patch/20220928024046.2657593-1-sj...
Regards, Simon
Hi Simon,
On 2022/12/6 07:55, Simon Glass wrote:
Hi,
On Tue, 6 Dec 2022 at 11:25, Tom Rini trini@konsulko.com wrote:
On Mon, Dec 05, 2022 at 09:35:41PM +0000, Peter Robinson wrote:
On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek msuchanek@suse.de wrote:
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by: Michal Suchanek msuchanek@suse.de
Reviewed-by: Peter Robinson pbrobinson@gmail.com Tested-by: Peter Robinson pbrobinson@gmail.com
Thanks for checking this out, I had noticed a regression and had got as far as bisecting it but not getting to a fix.
Tom: can we get this pulled into 2023.01 please?
Probably should be, yes. Kever, are there any other rockchip must-fixes for v2023.01? I can take this directly if you don't have others and/or don't want to make up a PR, thanks!
There is also this one:
https://patchwork.ozlabs.org/project/uboot/patch/20220928024046.2657593-1-sj...
This patch has been merge into mainline at about 21th Oct.
I forgot to update the patch status in patchwork system.
Thanks,
- Kever
Regards, Simon
Hi Tom,
On 2022/12/6 06:25, Tom Rini wrote:
On Mon, Dec 05, 2022 at 09:35:41PM +0000, Peter Robinson wrote:
On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek msuchanek@suse.de wrote:
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by: Michal Suchanek msuchanek@suse.de
Reviewed-by: Peter Robinson pbrobinson@gmail.com Tested-by: Peter Robinson pbrobinson@gmail.com
Thanks for checking this out, I had noticed a regression and had got as far as bisecting it but not getting to a fix.
Tom: can we get this pulled into 2023.01 please?
Probably should be, yes. Kever, are there any other rockchip must-fixes for v2023.01? I can take this directly if you don't have others and/or don't want to make up a PR, thanks!
I will take these fixes, and send a PR to you later.
Thanks,
- Kever
On 2022/12/3 20:31, Michal Suchanek wrote:
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by: Michal Suchanek msuchanek@suse.de
Reviewed-by: Kever Yang kever.yang@rock-chips.com
Thanks, - Kever
This is not tested, my board does not currentl;y boot at all, YMMV
arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 8 -------- 1 file changed, 8 deletions(-)
diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi index 2d87bea933..fd87102c0b 100644 --- a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi +++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi @@ -20,14 +20,6 @@ rockchip,panel = <&edp_panel>; };
-&i2c0 {
- u-boot,dm-pre-reloc;
-};
-&rk808 {
- u-boot,dm-pre-reloc;
-};
- &sdhci { max-frequency = <25000000>; u-boot,dm-pre-reloc;
participants (5)
-
Kever Yang -
Michal Suchanek -
Peter Robinson -
Simon Glass -
Tom Rini