[U-Boot] [common/cmd_ini.c:137]: (error) Uninitialized variable: line
Hello,
cppcheck reports:
[common/cmd_ini.c:137]: (error) Uninitialized variable: line
can you please have a look? Thanks!
Best regards,
Wolfgang Denk
On Thu, Nov 06, 2014 at 01:32:59PM +0100, Wolfgang Denk wrote:
Hello,
cppcheck reports:
[common/cmd_ini.c:137]: (error) Uninitialized variable: line
can you please have a look? Thanks!
trini@bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --version Cppcheck 1.52 trini@bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --force --inline-suppr common/cmd_ini.c Checking common/cmd_ini.c... Checking common/cmd_ini.c: CONFIG_INI_ALLOW_MULTILINE... Checking common/cmd_ini.c: CONFIG_INI_CASE_INSENSITIVE... Checking common/cmd_ini.c: CONFIG_INI_MAX_LINE... Checking common/cmd_ini.c: CONFIG_INI_MAX_NAME... Checking common/cmd_ini.c: CONFIG_INI_MAX_SECTION...
And I don't see anything. I did this since manually inspecting things and the code looks correct here but I could see cppcheck failing to figure it out (and I could see the code being optimized, we pass line as a pointer but then also return that back..).
Dear Tom,
In message 20141106161600.GQ24724@bill-the-cat you wrote:
trini@bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --version Cppcheck 1.52
-> cppcheck --version Cppcheck 1.63
trini@bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --force --inline-suppr common/cmd_ini.c Checking common/cmd_ini.c... Checking common/cmd_ini.c: CONFIG_INI_ALLOW_MULTILINE... Checking common/cmd_ini.c: CONFIG_INI_CASE_INSENSITIVE... Checking common/cmd_ini.c: CONFIG_INI_MAX_LINE... Checking common/cmd_ini.c: CONFIG_INI_MAX_NAME... Checking common/cmd_ini.c: CONFIG_INI_MAX_SECTION...
-> cppcheck --force --inline-suppr common/cmd_ini.c Checking common/cmd_ini.c... Checking common/cmd_ini.c: CONFIG_INI_ALLOW_MULTILINE... Checking common/cmd_ini.c: CONFIG_INI_CASE_INSENSITIVE... Checking common/cmd_ini.c: CONFIG_INI_MAX_LINE... [common/cmd_ini.c:137]: (error) Uninitialized variable: line Checking common/cmd_ini.c: CONFIG_INI_MAX_NAME... Checking common/cmd_ini.c: CONFIG_INI_MAX_SECTION...
Same result with Cppcheck 1.67
And I don't see anything. I did this since manually inspecting things and the code looks correct here but I could see cppcheck failing to figure it out (and I could see the code being optimized, we pass line as a pointer but then also return that back..).
To me it looks as if it complained due to possibly incorrect CONFIG_INI_MAX_LINE settings?
Best regards,
Wolfgang Denk
On Thu, Nov 06, 2014 at 07:10:54PM +0100, Wolfgang Denk wrote:
Dear Tom,
In message 20141106161600.GQ24724@bill-the-cat you wrote:
trini@bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --version Cppcheck 1.52
-> cppcheck --version Cppcheck 1.63
Ah, OK.
trini@bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --force --inline-suppr common/cmd_ini.c Checking common/cmd_ini.c... Checking common/cmd_ini.c: CONFIG_INI_ALLOW_MULTILINE... Checking common/cmd_ini.c: CONFIG_INI_CASE_INSENSITIVE... Checking common/cmd_ini.c: CONFIG_INI_MAX_LINE... Checking common/cmd_ini.c: CONFIG_INI_MAX_NAME... Checking common/cmd_ini.c: CONFIG_INI_MAX_SECTION...
-> cppcheck --force --inline-suppr common/cmd_ini.c Checking common/cmd_ini.c... Checking common/cmd_ini.c: CONFIG_INI_ALLOW_MULTILINE... Checking common/cmd_ini.c: CONFIG_INI_CASE_INSENSITIVE... Checking common/cmd_ini.c: CONFIG_INI_MAX_LINE... [common/cmd_ini.c:137]: (error) Uninitialized variable: line Checking common/cmd_ini.c: CONFIG_INI_MAX_NAME... Checking common/cmd_ini.c: CONFIG_INI_MAX_SECTION...
Same result with Cppcheck 1.67
And I don't see anything. I did this since manually inspecting things and the code looks correct here but I could see cppcheck failing to figure it out (and I could see the code being optimized, we pass line as a pointer but then also return that back..).
To me it looks as if it complained due to possibly incorrect CONFIG_INI_MAX_LINE settings?
Could be, but that'd be a compile-time failure if it's defined but not to a numerical value.
participants (2)
-
Tom Rini -
Wolfgang Denk