[U-Boot] [PATCH 1/4] x86: serial.dtsi: Add UART interrupt property
This patch adds the interrupt property for the legacy 0x3f8 NS16550 UART on standard x86 platforms. This can be used to enable the RX interrupt buffer support of the ns16550 driver, so that even very long lines can be pasted in the U-Boot console shell.
Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Bin Meng bmeng.cn@gmail.com --- arch/x86/dts/serial.dtsi | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/x86/dts/serial.dtsi b/arch/x86/dts/serial.dtsi index 22f7b54fed..3d0c40783f 100644 --- a/arch/x86/dts/serial.dtsi +++ b/arch/x86/dts/serial.dtsi @@ -6,5 +6,6 @@ reg-shift = <0>; clock-frequency = <1843200>; current-speed = <115200>; + interrupts = <4>; }; };
This patch adds the interrupt property for the PCI HS-UART NS16550 UART on Bay Trail x86 platforms. This can be used to enable the RX interrupt buffer support of the ns16550 driver, so that even very long lines can be pasted in the U-Boot console shell.
Please note that in general the interrupt number should be read from the PCI config registers by the UART driver. But since the UART driver is called very early in the init process, these PCI config registers are not initialized yet at this time. And since the PCI interrupt configuration is also fixed in the dfi-bt700.dtsi file, adding this one interrupt property to the UART DT node will not cause any problems with dynamic interrupt assignments resulting in a different interrupt number for this PCI device.
Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Bin Meng bmeng.cn@gmail.com --- arch/x86/dts/dfi-bt700.dtsi | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/x86/dts/dfi-bt700.dtsi b/arch/x86/dts/dfi-bt700.dtsi index b62e00ff1f..1ccdf5d24b 100644 --- a/arch/x86/dts/dfi-bt700.dtsi +++ b/arch/x86/dts/dfi-bt700.dtsi @@ -115,6 +115,7 @@ reg-shift = <2>; clock-frequency = <58982400>; current-speed = <115200>; + interrupts = <7>; };
pch@1f,0 {
On Tue, Aug 15, 2017 at 5:33 PM, Stefan Roese sr@denx.de wrote:
This patch adds the interrupt property for the PCI HS-UART NS16550 UART on Bay Trail x86 platforms. This can be used to enable the RX interrupt buffer support of the ns16550 driver, so that even very long lines can be pasted in the U-Boot console shell.
Please note that in general the interrupt number should be read from the PCI config registers by the UART driver. But since the UART driver is called very early in the init process, these PCI config registers are not initialized yet at this time. And since the PCI interrupt configuration is also fixed in the dfi-bt700.dtsi file, adding this one interrupt property to the UART DT node will not cause any problems with dynamic interrupt assignments resulting in a different interrupt number for this PCI device.
Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Bin Meng bmeng.cn@gmail.com
arch/x86/dts/dfi-bt700.dtsi | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
To support more input characters (longer stings pasted into the U-Boot prompt) without dropping, lets selects the recently added UART RX interrupt buffer for these boards.
Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Bin Meng bmeng.cn@gmail.com --- board/congatec/conga-qeval20-qa3-e3845/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/board/congatec/conga-qeval20-qa3-e3845/Kconfig b/board/congatec/conga-qeval20-qa3-e3845/Kconfig index e1fae737ac..9ca24489e8 100644 --- a/board/congatec/conga-qeval20-qa3-e3845/Kconfig +++ b/board/congatec/conga-qeval20-qa3-e3845/Kconfig @@ -25,6 +25,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select SPI_FLASH_STMICRO imply SPI_FLASH_SPANSION imply SPI_FLASH_WINBOND + select SERIAL_IRQ_BUFFER
config PCIE_ECAM_BASE default 0xe0000000
On Tue, Aug 15, 2017 at 5:33 PM, Stefan Roese sr@denx.de wrote:
To support more input characters (longer stings pasted into the U-Boot prompt) without dropping, lets selects the recently added UART RX interrupt buffer for these boards.
Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Bin Meng bmeng.cn@gmail.com
board/congatec/conga-qeval20-qa3-e3845/Kconfig | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
To support more input characters (longer stings pasted into the U-Boot prompt) without dropping, lets selects the recently added UART RX interrupt buffer for these boards.
Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Bin Meng bmeng.cn@gmail.com --- board/dfi/dfi-bt700/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/board/dfi/dfi-bt700/Kconfig b/board/dfi/dfi-bt700/Kconfig index 4b6c3fc56c..c253e1911d 100644 --- a/board/dfi/dfi-bt700/Kconfig +++ b/board/dfi/dfi-bt700/Kconfig @@ -25,6 +25,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select SPI_FLASH_STMICRO imply SPI_FLASH_SPANSION imply SPI_FLASH_WINBOND + select SERIAL_IRQ_BUFFER
config PCIE_ECAM_BASE default 0xe0000000
On Tue, Aug 15, 2017 at 5:34 PM, Stefan Roese sr@denx.de wrote:
To support more input characters (longer stings pasted into the U-Boot prompt) without dropping, lets selects the recently added UART RX interrupt buffer for these boards.
Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Bin Meng bmeng.cn@gmail.com
board/dfi/dfi-bt700/Kconfig | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
On Tue, Aug 15, 2017 at 5:33 PM, Stefan Roese sr@denx.de wrote:
This patch adds the interrupt property for the legacy 0x3f8 NS16550 UART on standard x86 platforms. This can be used to enable the RX interrupt buffer support of the ns16550 driver, so that even very long lines can be pasted in the U-Boot console shell.
Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Bin Meng bmeng.cn@gmail.com
arch/x86/dts/serial.dtsi | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com Tested-by: Bin Meng bmeng.cn@gmail.com
participants (2)
-
Bin Meng -
Stefan Roese