[U-Boot] [PATCH] configs: Rename roc-rk3399-pc -> roc-pc-rk3399 defconfig
roc-rk3399-pc_defconfig is committed in below
commit <8a681f4c5aa15db51ad0209734859c9fe7c29cfd> ("rockchip: rk3399: Add ROC-RK3399-PC support")
which doesn't follow the existing defconfigs on rk3399.
So, rename as followed with other rk3399 defconfigs.
Cc: Levin Du djw@t-chip.com.cn Signed-off-by: Jagan Teki jagan@amarulasolutions.com --- board/rockchip/evb_rk3399/MAINTAINERS | 2 +- configs/{roc-rk3399-pc_defconfig => roc-pc-rk3399_defconfig} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename configs/{roc-rk3399-pc_defconfig => roc-pc-rk3399_defconfig} (100%)
diff --git a/board/rockchip/evb_rk3399/MAINTAINERS b/board/rockchip/evb_rk3399/MAINTAINERS index f8299d9460..17dfafb743 100644 --- a/board/rockchip/evb_rk3399/MAINTAINERS +++ b/board/rockchip/evb_rk3399/MAINTAINERS @@ -52,7 +52,7 @@ F: arch/arm/dts/rk3399-orangepi-u-boot.dtsi ROC-RK3399-PC M: Levin Du djw@t-chip.com.cn S: Maintained -F: configs/roc-rk3399-pc_defconfig +F: configs/roc-pc-rk3399_defconfig F: arch/arm/dts/rk3399-roc-pc-u-boot.dtsi
ROCK-PI-4 diff --git a/configs/roc-rk3399-pc_defconfig b/configs/roc-pc-rk3399_defconfig similarity index 100% rename from configs/roc-rk3399-pc_defconfig rename to configs/roc-pc-rk3399_defconfig
On Sat, Nov 02, 2019 at 10:19:02AM +0530, Jagan Teki wrote:
roc-rk3399-pc_defconfig is committed in below
commit <8a681f4c5aa15db51ad0209734859c9fe7c29cfd> ("rockchip: rk3399: Add ROC-RK3399-PC support")
which doesn't follow the existing defconfigs on rk3399.
So, rename as followed with other rk3399 defconfigs.
Cc: Levin Du djw@t-chip.com.cn Signed-off-by: Jagan Teki jagan@amarulasolutions.com
This strikes me as wrong, as the existing name is the actual name of the board.
https://libre.computer/products/boards/roc-rk3399-pc/
Jonathan Kollasch
The mainline uses 'rk3399-*', so there're rk3399-firefly.dts, rk3399-roc-pc.dts, rk3399-khadas-edge.dts, etc. Shall we follow the kernel convention, or add another roc-pc-rk3399 to the matrix? I prefer to keep it as it is.
"Jonathan A. Kollasch" jakllsch@kollasch.net writes:
On Sat, Nov 02, 2019 at 10:19:02AM +0530, Jagan Teki wrote:
roc-rk3399-pc_defconfig is committed in below
commit <8a681f4c5aa15db51ad0209734859c9fe7c29cfd> ("rockchip: rk3399:
Add ROC-RK3399-PC support")
which doesn't follow the existing defconfigs on rk3399.
So, rename as followed with other rk3399 defconfigs.
Cc: Levin Du djw@t-chip.com.cn Signed-off-by: Jagan Teki jagan@amarulasolutions.com
This strikes me as wrong, as the existing name is the actual name of the board.
https://libre.computer/products/boards/roc-rk3399-pc/
Jonathan Kollasch _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
The mainline uses 'rk3399-*', so there're rk3399-firefly.dts, rk3399-roc-pc.dts, rk3399-khadas-edge.dts, etc. Shall we follow the kernel convention, or adding another roc-pc-rk3399 to the matrix?
-- Best Regards, Levin Du
On 2019/11/2 下午12:49, Jagan Teki wrote:
roc-rk3399-pc_defconfig is committed in below
commit <8a681f4c5aa15db51ad0209734859c9fe7c29cfd> ("rockchip: rk3399: Add ROC-RK3399-PC support")
which doesn't follow the existing defconfigs on rk3399.
So, rename as followed with other rk3399 defconfigs.
Cc: Levin Du djw@t-chip.com.cn Signed-off-by: Jagan Teki jagan@amarulasolutions.com
The board name is roc-rk3399-pc, but we do update this in dts as {soc}-{board}.dts
and {board}-{soc}_defconfig for all boards already have, so
Reviewed-by: Kever Yang kever.yang@rock-chips.com
Thanks, - Kever
board/rockchip/evb_rk3399/MAINTAINERS | 2 +- configs/{roc-rk3399-pc_defconfig => roc-pc-rk3399_defconfig} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename configs/{roc-rk3399-pc_defconfig => roc-pc-rk3399_defconfig} (100%)
diff --git a/board/rockchip/evb_rk3399/MAINTAINERS b/board/rockchip/evb_rk3399/MAINTAINERS index f8299d9460..17dfafb743 100644 --- a/board/rockchip/evb_rk3399/MAINTAINERS +++ b/board/rockchip/evb_rk3399/MAINTAINERS @@ -52,7 +52,7 @@ F: arch/arm/dts/rk3399-orangepi-u-boot.dtsi ROC-RK3399-PC M: Levin Du djw@t-chip.com.cn S: Maintained -F: configs/roc-rk3399-pc_defconfig +F: configs/roc-pc-rk3399_defconfig F: arch/arm/dts/rk3399-roc-pc-u-boot.dtsi
ROCK-PI-4 diff --git a/configs/roc-rk3399-pc_defconfig b/configs/roc-pc-rk3399_defconfig similarity index 100% rename from configs/roc-rk3399-pc_defconfig rename to configs/roc-pc-rk3399_defconfig
On 2019/11/13 下午5:13, Kever Yang wrote:
On 2019/11/2 下午12:49, Jagan Teki wrote:
roc-rk3399-pc_defconfig is committed in below
commit <8a681f4c5aa15db51ad0209734859c9fe7c29cfd> ("rockchip: rk3399: Add ROC-RK3399-PC support")
which doesn't follow the existing defconfigs on rk3399.
So, rename as followed with other rk3399 defconfigs.
Cc: Levin Du djw@t-chip.com.cn Signed-off-by: Jagan Teki jagan@amarulasolutions.com
The board name is roc-rk3399-pc, but we do update this in dts as {soc}-{board}.dts
and {board}-{soc}_defconfig for all boards already have, so
Reviewed-by: Kever Yang kever.yang@rock-chips.com
Applied to u-boot-rockchip master.
Thanks, - Kever
Thanks,
- Kever
board/rockchip/evb_rk3399/MAINTAINERS | 2 +- configs/{roc-rk3399-pc_defconfig => roc-pc-rk3399_defconfig} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename configs/{roc-rk3399-pc_defconfig => roc-pc-rk3399_defconfig} (100%)
diff --git a/board/rockchip/evb_rk3399/MAINTAINERS b/board/rockchip/evb_rk3399/MAINTAINERS index f8299d9460..17dfafb743 100644 --- a/board/rockchip/evb_rk3399/MAINTAINERS +++ b/board/rockchip/evb_rk3399/MAINTAINERS @@ -52,7 +52,7 @@ F: arch/arm/dts/rk3399-orangepi-u-boot.dtsi ROC-RK3399-PC M: Levin Du djw@t-chip.com.cn S: Maintained -F: configs/roc-rk3399-pc_defconfig +F: configs/roc-pc-rk3399_defconfig F: arch/arm/dts/rk3399-roc-pc-u-boot.dtsi ROCK-PI-4 diff --git a/configs/roc-rk3399-pc_defconfig b/configs/roc-pc-rk3399_defconfig similarity index 100% rename from configs/roc-rk3399-pc_defconfig rename to configs/roc-pc-rk3399_defconfig
Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
participants (5)
-
djw＠archiso.i-did-not-set--mail-host-address--so-tickle-me -
Jagan Teki -
Jonathan A. Kollasch -
Kever Yang -
Levin Du