[U-Boot] [PATCH] Odroid-XU3: Undefine TRACE CONFIGs in Odroid XU3
This patch undefines Trace configs in Odroidx XU3. Trace configs are defined in exynos5-common.h
Signed-off-by: Inha Song ideal.song@samsung.com --- include/configs/odroid_xu3.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h index c395020..f427fe2 100644 --- a/include/configs/odroid_xu3.h +++ b/include/configs/odroid_xu3.h @@ -23,6 +23,11 @@
#define TZPC_BASE_OFFSET 0x10000
+/* TRACE configs are defined in exynos5-common */ +#undef CONFIG_TRACE +#undef CONFIG_CMD_TRACE +#undef CONFIG_TRACE_EARLY + #define CONFIG_CMD_MMC
#define CONFIG_NR_DRAM_BANKS 8
On Thu, 2015-03-12 at 14:32 +0900, Inha Song wrote:
This patch undefines Trace configs in Odroidx XU3. Trace configs are defined in exynos5-common.h
Would be great to explain why you want to disable trace on this specific board but leave it enabled on all other exynos5 boards?
Signed-off-by: Inha Song ideal.song@samsung.com
include/configs/odroid_xu3.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h index c395020..f427fe2 100644 --- a/include/configs/odroid_xu3.h +++ b/include/configs/odroid_xu3.h @@ -23,6 +23,11 @@
#define TZPC_BASE_OFFSET 0x10000
+/* TRACE configs are defined in exynos5-common */ +#undef CONFIG_TRACE +#undef CONFIG_CMD_TRACE +#undef CONFIG_TRACE_EARLY
#define CONFIG_CMD_MMC
#define CONFIG_NR_DRAM_BANKS 8
Hi,
On 12 March 2015 at 00:27, Sjoerd Simons sjoerd.simons@collabora.co.uk wrote:
On Thu, 2015-03-12 at 14:32 +0900, Inha Song wrote:
This patch undefines Trace configs in Odroidx XU3. Trace configs are defined in exynos5-common.h
Would be great to explain why you want to disable trace on this specific board but leave it enabled on all other exynos5 boards?
Can I suggest putting an #ifdef FTRACE around the #define options as with sandbox.h?
Signed-off-by: Inha Song ideal.song@samsung.com
include/configs/odroid_xu3.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h index c395020..f427fe2 100644 --- a/include/configs/odroid_xu3.h +++ b/include/configs/odroid_xu3.h @@ -23,6 +23,11 @@
#define TZPC_BASE_OFFSET 0x10000
+/* TRACE configs are defined in exynos5-common */ +#undef CONFIG_TRACE +#undef CONFIG_CMD_TRACE +#undef CONFIG_TRACE_EARLY
#define CONFIG_CMD_MMC
#define CONFIG_NR_DRAM_BANKS 8
Regards, Simon
Hi, Simon,
On Thu, 12 Mar 2015 15:11:05 -0700 Simon Glass sjg@chromium.org wrote:
Hi,
On 12 March 2015 at 00:27, Sjoerd Simons sjoerd.simons@collabora.co.uk wrote:
On Thu, 2015-03-12 at 14:32 +0900, Inha Song wrote:
This patch undefines Trace configs in Odroidx XU3. Trace configs are defined in exynos5-common.h
Would be great to explain why you want to disable trace on this specific board but leave it enabled on all other exynos5 boards?
Can I suggest putting an #ifdef FTRACE around the #define options as with sandbox.h?
Tracing is always enabled with FTRACE. Right? So that, We need to add #ifdef FTRACE in exynos5-common.h as you mentioned.
I will send exynos5-common.h patch.
Best Regards, Inha Song.
Signed-off-by: Inha Song ideal.song@samsung.com
include/configs/odroid_xu3.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h index c395020..f427fe2 100644 --- a/include/configs/odroid_xu3.h +++ b/include/configs/odroid_xu3.h @@ -23,6 +23,11 @@
#define TZPC_BASE_OFFSET 0x10000
+/* TRACE configs are defined in exynos5-common */ +#undef CONFIG_TRACE +#undef CONFIG_CMD_TRACE +#undef CONFIG_TRACE_EARLY
#define CONFIG_CMD_MMC
#define CONFIG_NR_DRAM_BANKS 8
Regards, Simon
participants (3)
-
Inha Song -
Simon Glass -
Sjoerd Simons