[U-Boot-Users] RTL8169 driver not work on PPC8241
Hi, My ethernet can not work based on RTL8169 and MPC8241. I try to use TFTP command to load files. But It can not send out the packets. I found it caused by TxDescriptor not work. Since the owner bit on TxDescriptor can not auto clean by descriptor in the function rtl_send( ). When compile RTL8169.C, a function "virt_to_bus( )" lost. So i define it as the following #undef virt_to_bus #define virt_to_bus(x) ((unsigned long)x)
Can any one advise me if this definition ok? Or anything I should check?
Thanks
Roger Yang
Hi Roger,
Attached file is a new driver for RTL8169. Please try.
Masami Komiya
Roger Yang(楊仁存) wrote:
Hi, My ethernet can not work based on RTL8169 and MPC8241. I try to use TFTP command to load files. But It can not send out the packets. I found it caused by TxDescriptor not work. Since the owner bit on TxDescriptor can not auto clean by descriptor in the function rtl_send( ). When compile RTL8169.C, a function "virt_to_bus( )" lost. So i define it as the following
#undef virt_to_bus #define virt_to_bus(x) ((unsigned long)x)
Can any one advise me if this definition ok? Or anything I should check?
Thanks
Roger Yang
Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=D...
U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
In message 457EDE2D.9030801@sonare.it you wrote:
Attached file is a new driver for RTL8169.
Ummm... "new" driver is a bit strong given the fact that you changed less than 5 % of the lines in the driver.
May I ask you to submit your changes as a proper patch, with expla- nations which problems you are fixing and why you change the code the way you change it?
Best regards,
Wolfgang Denk
Wolfgang Denk wrote:
In message 457EDE2D.9030801@sonare.it you wrote:
Attached file is a new driver for RTL8169.
Ummm... "new" driver is a bit strong given the fact that you changed less than 5 % of the lines in the driver.
Sorry, I made a mistake for the another driver.
May I ask you to submit your changes as a proper patch, with expla- nations which problems you are fixing and why you change the code the way you change it?
Changes are: 1. Disable "wait for auto-negotiation process" in rtl_init() to reduce the setup time. 2. Delete TX/RX buffer copy to increase performance. 3. virt_to_bus() to phys_to_bus() for PPC user 4. Code clean up
Best regards,
Masami Komiya
In message 457FA2E0.2090309@sonare.it you wrote:
May I ask you to submit your changes as a proper patch, with expla- nations which problems you are fixing and why you change the code the way you change it?
Changes are:
- Disable "wait for auto-negotiation process" in rtl_init() to reduce the setup time.
Don't you think this may cause problems on some systems?
- Delete TX/RX buffer copy to increase performance.
Don't you think this may cause problems on some systems?
Best regards,
Wolfgang Denk
participants (3)
-
Masami Komiya -
Roger Yang(楊仁存) -
Wolfgang Denk