[U-Boot] [PATCH] sunxi: make mksunxiboot available to tools-only builds
This tool is potentially useful on host systems. In particular I'd like to make use of it at build time from the sunxi-tools package in Debian.
Signed-off-by: Ian Campbell ijc@hellion.org.uk --- tools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile index 61b2048..6095299 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -129,7 +129,7 @@ hostprogs-$(CONFIG_MX23) += mxsboot hostprogs-$(CONFIG_MX28) += mxsboot HOSTCFLAGS_mxsboot.o := -pedantic
-hostprogs-$(CONFIG_SUNXI) += mksunxiboot +hostprogs-y += mksunxiboot
hostprogs-$(CONFIG_NETCONSOLE) += ncb hostprogs-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1
Hi,
On 07/28/2014 09:29 PM, Ian Campbell wrote:
This tool is potentially useful on host systems. In particular I'd like to make use of it at build time from the sunxi-tools package in Debian.
Yes that makes sense.
Signed-off-by: Ian Campbell ijc@hellion.org.uk
Acked-by: Hans de Goede hdegoede@redhat.com
Regards,
Hans
tools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile index 61b2048..6095299 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -129,7 +129,7 @@ hostprogs-$(CONFIG_MX23) += mxsboot hostprogs-$(CONFIG_MX28) += mxsboot HOSTCFLAGS_mxsboot.o := -pedantic
-hostprogs-$(CONFIG_SUNXI) += mksunxiboot +hostprogs-y += mksunxiboot
hostprogs-$(CONFIG_NETCONSOLE) += ncb hostprogs-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1
Hello Ian,
On 28-07-14 21:29, Ian Campbell wrote:
This tool is potentially useful on host systems. In particular I'd like to make use of it at build time from the sunxi-tools package in Debian.
No this does not make sense. Why should a MAKEALL for powerpc build mksunxiboot hundreds of times, while it not using it, while you ship a arch specific package in Debian?
Can't you just put this under HOST_TOOLS_ALL and ship an u-boot-tools package or something?
Regards, Jeroen
On Mon, 2014-07-28 at 22:22 +0200, Jeroen Hofstee wrote:
Hello Ian,
On 28-07-14 21:29, Ian Campbell wrote:
This tool is potentially useful on host systems. In particular I'd like to make use of it at build time from the sunxi-tools package in Debian.
No this does not make sense. Why should a MAKEALL for powerpc build mksunxiboot hundreds of times, while it not using it, while you ship a arch specific package in Debian?
Hrm, I incorrectly thought that hostprogs-y covered more stuff but I was wrong.
Can't you just put this under HOST_TOOLS_ALL and ship an u-boot-tools package or something?
The problem with HOST_TOOLS_ALL is that it requires a configured tree.
At the moment we have tools-only which does not require a configured tree but only includes a minimal set of tools and tools-all (HOST_TOOLS_ALL) which does require a configured tree but in addition to the tools which the config implies also builds all "config-independent" tools as well.
Debian currently builds tools-only into a u-boot-tools package and the various target specific files into another package. I'd like to get mksunxiboot into the u-boot-tools package (or perhaps u-boot-tools-sunxi) so it is available even on non-sunxi (or even non-ARM) systems.
Perhaps what is needed is a third target between tools-only and tools-all which builds all config-independent tools without requiring a config? e.g. tools-all-only? Or maybe it would be possible to relax tools-all such that it doesn't require a configured tree.
Any opinions on those two options? FWIW the first option would end up looking something like below, I've not prototyped the second one yet.
Ian.
On Tue, 2014-07-29 at 09:30 +0100, Ian Campbell wrote:
Any opinions on those two options? FWIW the first option would end up looking something like below, I've not prototyped the second one yet.
Hit the wrong button, oops. Here's the scratch patch:
diff --git a/Makefile b/Makefile index ca212b5..01c3416 100644 - - a/Makefile + + b/Makefile @@ -417,7 +417,7 @@ timestamp_h := include/generated/timestamp_autogenerated.h
no-dot-config-targets := clean clobber mrproper distclean \ help %docs check% coccicheck \ - ubootversion backup tools-only + ubootversion backup tools-only tools-all-only
config-targets := 0 mixed-targets := 0 @@ -1186,6 +1186,10 @@ env: scripts_basic tools-only: scripts_basic $(version_h) $(timestamp_h) $(Q)$(MAKE) $(build)=tools
+tools-all-only: export HOST_TOOLS_ALL=y +tools-all-only: scripts_basic $(version_h) $(timestamp_h) + $(Q)$(MAKE) $(build)=tools + tools-all: export HOST_TOOLS_ALL=y tools-all: env tools ;
diff --git a/tools/Makefile b/tools/Makefile index 61b2048..0100af3 100644 - - a/tools/Makefile + + b/tools/Makefile @@ -13,6 +13,7 @@ CONFIG_CMD_NET = y CONFIG_XWAY_SWAP_BYTES = y CONFIG_NETCONSOLE = y CONFIG_SHA1_CHECK_UB_IMG = y +CONFIG_SUNXI = y endif
subdir-$(HOST_TOOLS_ALL) += easylogo
participants (3)
-
Hans de Goede -
Ian Campbell -
Jeroen Hofstee