[U-Boot] Annoying make debug messages at v2013.10-rc3
Hello Albert.
Commit 27af930e modified top Makefile as follows:
--- a/Makefile +++ b/Makefile @@ -838,7 +838,7 @@ unconfig:
sinclude $(obj).boards.depend $(obj).boards.depend: boards.cfg - @awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@ + @awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE) -d" }' $< > $@
# # Functions to generate common board directory names
I thought adding -d option is not what you intended.
So, I posted a patch "[U-Boot] Makefile: Do not show make debug messages" to delete -d option again. Does my patch seem to be OK?
I am really suffering from lots of debug messages like follows:
$ make CROSS_COMPILE=arm-linux-gnueabi- omap4_panda Configuring for omap4_panda board... make -d GNU Make 3.81 Copyright (C) 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
This program built for x86_64-pc-linux-gnu Reading makefiles... Reading makefile `Makefile'... Reading makefile `include/autoconf.mk.dep' (search path) (don't care) (no ~ expansion)... Reading makefile `include/autoconf.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `include/config.mk' (search path) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/config.mk' (search path) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/include/generated/cc_options.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/include/autoconf.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/include/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/arch/arm/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/arch/arm/cpu/armv7/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/arch/arm/cpu/armv7/omap4/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/board/ti/panda/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `.boards.depend' (search path) (don't care) (no ~ expansion)... Updating makefiles.... Considering target file `.boards.depend'. Considering target file `boards.cfg'. Looking for an implicit rule for `boards.cfg'. Trying pattern rule with stem `boards.cfg'. Trying implicit prerequisite `boards.cfg.o'. Trying pattern rule with stem `boards.cfg'. .....
Best Regards Masahiro Yamada
Hi Masahiro,
On Wed, 18 Sep 2013 13:00:18 +0900, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Hello Albert.
Commit 27af930e modified top Makefile as follows:
--- a/Makefile +++ b/Makefile @@ -838,7 +838,7 @@ unconfig: sinclude $(obj).boards.depend $(obj).boards.depend: boards.cfg - @awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@ + @awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE) -d" }' $< > $@ # # Functions to generate common board directory namesI thought adding -d option is not what you intended.
So, I posted a patch "[U-Boot] Makefile: Do not show make debug messages" to delete -d option again. Does my patch seem to be OK?
Yes. BTW, you do not need to double patches with explanatory mails. Any explanations that you want to add but not be put in the commit, just put them below the commit message delimiter, the "---" line.
Tom: do you want to pick this and Axel Lin's bang and Roger Meier's checkpatch fixes, or do I pick them in u-boot-arm?
Best Regards Masahiro Yamada
Amicalement,
Hi Albert.
Yes. BTW, you do not need to double patches with explanatory mails. Any explanations that you want to add but not be put in the commit, just put them below the commit message delimiter, the "---" line.
You are right. This thread was redundant. Going forward I will do that. Thanks!
Best Regards Masahiro Yamada
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/19/2013 02:39 AM, Albert ARIBAUD wrote:
Hi Masahiro,
On Wed, 18 Sep 2013 13:00:18 +0900, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Hello Albert.
Commit 27af930e modified top Makefile as follows:
--- a/Makefile +++ b/Makefile @@ -838,7 +838,7 @@ unconfig: sinclude $(obj).boards.depend $(obj).boards.depend: boards.cfg - @awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@ + @awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE) -d" }' $< > $@ # # Functions to generate common board directory namesI thought adding -d option is not what you intended.
So, I posted a patch "[U-Boot] Makefile: Do not show make debug messages" to delete -d option again. Does my patch seem to be OK?
Yes. BTW, you do not need to double patches with explanatory mails. Any explanations that you want to add but not be put in the commit, just put them below the commit message delimiter, the "---" line.
Tom: do you want to pick this and Axel Lin's bang and Roger Meier's checkpatch fixes, or do I pick them in u-boot-arm?
Please grab them for u-boot-arm/master, thanks
- -- Tom
Hi Masahiro,
On Wed, 18 Sep 2013 13:00:18 +0900, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Hello Albert.
Commit 27af930e modified top Makefile as follows:
--- a/Makefile +++ b/Makefile @@ -838,7 +838,7 @@ unconfig: sinclude $(obj).boards.depend $(obj).boards.depend: boards.cfg - @awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@ + @awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE) -d" }' $< > $@ # # Functions to generate common board directory namesI thought adding -d option is not what you intended.
So, I posted a patch "[U-Boot] Makefile: Do not show make debug messages" to delete -d option again. Does my patch seem to be OK?
I am really suffering from lots of debug messages like follows:
$ make CROSS_COMPILE=arm-linux-gnueabi- omap4_panda Configuring for omap4_panda board... make -d GNU Make 3.81 Copyright (C) 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
This program built for x86_64-pc-linux-gnu Reading makefiles... Reading makefile `Makefile'... Reading makefile `include/autoconf.mk.dep' (search path) (don't care) (no ~ expansion)... Reading makefile `include/autoconf.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `include/config.mk' (search path) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/config.mk' (search path) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/include/generated/cc_options.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/include/autoconf.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/include/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/arch/arm/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/arch/arm/cpu/armv7/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/arch/arm/cpu/armv7/omap4/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `/home/yamada/workspace/u-boot/board/ti/panda/config.mk' (search path) (don't care) (no ~ expansion)... Reading makefile `.boards.depend' (search path) (don't care) (no ~ expansion)... Updating makefiles.... Considering target file `.boards.depend'. Considering target file `boards.cfg'. Looking for an implicit rule for `boards.cfg'. Trying pattern rule with stem `boards.cfg'. Trying implicit prerequisite `boards.cfg.o'. Trying pattern rule with stem `boards.cfg'. .....
Can you repost according to the patch posting guidelines at http://www.denx.de/wiki/U-Boot/Patches so that the patch shows up properly on patchwork and attributed to you?
Basically, generate the patch with git format-patch -s, and send it with git send-email.
Best Regards Masahiro Yamada
Amicalement,
Hi Masahiro,
On Thu, 19 Sep 2013 14:49:52 +0200, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Can you repost according to the patch posting guidelines at
My bad--you had posted correctly. :)
Amicalement,
participants (3)
-
Albert ARIBAUD -
Masahiro Yamada -
Tom Rini