[PATCH] dm: core: Use full printf() format when possible
Use a more accurate check for determining if the full format string will be handled correctly, since SPL_USE_TINY_PRINTF can be disabled.
Signed-off-by: Samuel Holland samuel@sholland.org ---
drivers/core/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/core/dump.c b/drivers/core/dump.c index 1c1f7e4d30..4997862478 100644 --- a/drivers/core/dump.c +++ b/drivers/core/dump.c @@ -17,7 +17,7 @@ static void show_devices(struct udevice *dev, int depth, int last_flag) u32 flags = dev_get_flags(dev);
/* print the first 20 characters to not break the tree-format. */ - printf(IS_ENABLED(CONFIG_SPL_BUILD) ? " %s %d [ %c ] %s " : + printf(CONFIG_IS_ENABLED(USE_TINY_PRINTF) ? " %s %d [ %c ] %s " : " %-10.10s %3d [ %c ] %-20.20s ", dev->uclass->uc_drv->name, dev_get_uclass_index(dev, NULL), flags & DM_FLAG_ACTIVATED ? '+' : ' ', dev->driver->name);
On Sat, 21 Jan 2023 at 16:30, Samuel Holland samuel@sholland.org wrote:
Use a more accurate check for determining if the full format string will be handled correctly, since SPL_USE_TINY_PRINTF can be disabled.
Signed-off-by: Samuel Holland samuel@sholland.org
drivers/core/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
On Sat, 21 Jan 2023 at 16:30, Samuel Holland samuel@sholland.org wrote:
Use a more accurate check for determining if the full format string will be handled correctly, since SPL_USE_TINY_PRINTF can be disabled.
Signed-off-by: Samuel Holland samuel@sholland.org
drivers/core/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot-dm, thanks!
participants (2)
-
Samuel Holland -
Simon Glass