[U-Boot] [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
Enable the errata-a005697 for ls1012a
Signed-off-by: Changming Huang jerry.huang@nxp.com --- drivers/usb/common/fsl-errata.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c index 0dc3dd8..59a69a1 100644 --- a/drivers/usb/common/fsl-errata.c +++ b/drivers/usb/common/fsl-errata.c @@ -139,6 +139,10 @@ bool has_erratum_a005697(void) case SVR_9132: return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1); #endif +#ifdef CONFIG_ARM + case SVR_LS1012A: + return IS_SVR_REV(svr, 1, 0); +#endif } return false; }
Any comment for this patch?
Best Regards Jerry Huang
-----Original Message----- From: Changming Huang [mailto:jerry.huang@nxp.com] Sent: Thursday, November 24, 2016 3:14 PM To: york sun york.sun@nxp.com; u-boot@lists.denx.de Cc: Jerry Huang jerry.huang@nxp.com Subject: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
Enable the errata-a005697 for ls1012a
Signed-off-by: Changming Huang jerry.huang@nxp.com --- drivers/usb/common/fsl-errata.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c index 0dc3dd8..59a69a1 100644 --- a/drivers/usb/common/fsl-errata.c +++ b/drivers/usb/common/fsl-errata.c @@ -139,6 +139,10 @@ bool has_erratum_a005697(void) case SVR_9132: return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1); #endif +#ifdef CONFIG_ARM + case SVR_LS1012A: + return IS_SVR_REV(svr, 1, 0); +#endif } return false; } -- 1.7.9.5
On 11/29/2016 06:39 PM, Jerry Huang wrote:
Any comment for this patch?
Looks simple enough.
York
Best Regards Jerry Huang
-----Original Message----- From: Changming Huang [mailto:jerry.huang@nxp.com] Sent: Thursday, November 24, 2016 3:14 PM To: york sun york.sun@nxp.com; u-boot@lists.denx.de Cc: Jerry Huang jerry.huang@nxp.com Subject: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
Enable the errata-a005697 for ls1012a
Signed-off-by: Changming Huang jerry.huang@nxp.com
drivers/usb/common/fsl-errata.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c index 0dc3dd8..59a69a1 100644 --- a/drivers/usb/common/fsl-errata.c +++ b/drivers/usb/common/fsl-errata.c @@ -139,6 +139,10 @@ bool has_erratum_a005697(void) case SVR_9132: return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1); #endif +#ifdef CONFIG_ARM
- case SVR_LS1012A:
return IS_SVR_REV(svr, 1, 0);+#endif } return false; } -- 1.7.9.5
On 11/29/2016 06:39 PM, Jerry Huang wrote:
Any comment for this patch?
Best Regards Jerry Huang
-----Original Message----- From: Changming Huang [mailto:jerry.huang@nxp.com] Sent: Thursday, November 24, 2016 3:14 PM To: york sun york.sun@nxp.com; u-boot@lists.denx.de Cc: Jerry Huang jerry.huang@nxp.com Subject: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
Enable the errata-a005697 for ls1012a
Signed-off-by: Changming Huang jerry.huang@nxp.com
drivers/usb/common/fsl-errata.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c index 0dc3dd8..59a69a1 100644 --- a/drivers/usb/common/fsl-errata.c +++ b/drivers/usb/common/fsl-errata.c @@ -139,6 +139,10 @@ bool has_erratum_a005697(void) case SVR_9132: return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1); #endif +#ifdef CONFIG_ARM
- case SVR_LS1012A:
return IS_SVR_REV(svr, 1, 0);+#endif }
Actually this patch has a problem with the SVR. SVR_LS1012A is defined in arch/arm/include/asm/arch-fsl-layerscape/soc.h. You will see compiling errors for LS1021A, eg ls1021atwr_nor.
York
York, I don't know the file " arch/arm/include/asm/arch-fsl-layerscape/soc.h " is not included for ls1021a, maybe ls1021a is one special ARM SoC. Now I will add one macro " CONFIG_LS1012A " to resolve this issue.
Best Regards Jerry Huang
-----Original Message----- From: york sun Sent: Thursday, December 01, 2016 3:10 AM To: Jerry Huang jerry.huang@nxp.com; u-boot@lists.denx.de Subject: Re: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
On 11/29/2016 06:39 PM, Jerry Huang wrote:
Any comment for this patch?
Best Regards Jerry Huang
-----Original Message----- From: Changming Huang [mailto:jerry.huang@nxp.com] Sent: Thursday, November 24, 2016 3:14 PM To: york sun york.sun@nxp.com; u-boot@lists.denx.de Cc: Jerry Huang jerry.huang@nxp.com Subject: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
Enable the errata-a005697 for ls1012a
Signed-off-by: Changming Huang jerry.huang@nxp.com
drivers/usb/common/fsl-errata.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c index 0dc3dd8..59a69a1 100644 --- a/drivers/usb/common/fsl-errata.c +++ b/drivers/usb/common/fsl-errata.c @@ -139,6 +139,10 @@ bool has_erratum_a005697(void) case SVR_9132: return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1); #endif +#ifdef CONFIG_ARM
- case SVR_LS1012A:
return IS_SVR_REV(svr, 1, 0);+#endif }
Actually this patch has a problem with the SVR. SVR_LS1012A is defined in arch/arm/include/asm/arch-fsl-layerscape/soc.h. You will see compiling errors for LS1021A, eg ls1021atwr_nor.
York
participants (3)
-
Changming Huang -
Jerry Huang
-
york sun