[U-Boot] [PATCH 0/2 v3] No need for parade bridge on peach-pi
With current u-boot-samsung HEAD on a peach-pi the following error is printed: exynos_lcd_power_on: ps8625_init() failed
Which is not surprising given that chip does not exist on these boards.
Changes since v2: * Move the parade_init function to its own header file Changes since v1: * Only change the DTS for peach-pi not the default config. Further configuration changes will be done seperately * Use the approach as suggested by Ajay Kumar to fix compilation without parade support
Sjoerd Simons (2): Exynos5800: The Peach-Pi board does not have a Parade video bridge exynos5420: fix compilation without parade video
arch/arm/dts/exynos5800-peach-pi.dts | 5 ----- arch/arm/include/asm/arch-exynos/system.h | 3 --- board/samsung/smdk5420/smdk5420.c | 1 + include/parade.h | 18 ++++++++++++++++++ 4 files changed, 19 insertions(+), 8 deletions(-) create mode 100644 include/parade.h
Unlike the Peach-Pit board, there is no parade edp to lvds bridge on the Pi. So drop it from device-tree
Signed-off-by: Sjoerd Simons sjoerd.simons@collabora.co.uk Acked-by: Simon Glass sjg@chromium.org Tested-by: Simon Glass sjg@chromium.org --- Changes since v2: Add Ack/Tested by from Simon Glass Changes since v1: Only modify the DTB
arch/arm/dts/exynos5800-peach-pi.dts | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/arch/arm/dts/exynos5800-peach-pi.dts b/arch/arm/dts/exynos5800-peach-pi.dts index 8aedf8e..2f9d2db 100644 --- a/arch/arm/dts/exynos5800-peach-pi.dts +++ b/arch/arm/dts/exynos5800-peach-pi.dts @@ -63,11 +63,6 @@ reg = <0x20>; compatible = "maxim,max98090-codec"; }; - - edp-lvds-bridge@48 { - compatible = "parade,ps8625"; - reg = <0x48>; - }; };
sound@3830000 {
Not all exynos 5420 based devices with an LCD also have a parade LVDS bridge. So make sure compilation doesn't break if CONFIG_LCD is enabled and CONFIG_VIDEO_PARADE is not.
As a side-effect move the parade functions from the exynos system header file to its own file.
Signed-off-by: Sjoerd Simons sjoerd.simons@collabora.co.uk --- Changes since V2: Take the opportunity to move parade_init to it's own include file. As requested by Minkyu Kang Changes since V1: New patch
arch/arm/include/asm/arch-exynos/system.h | 3 --- board/samsung/smdk5420/smdk5420.c | 1 + include/parade.h | 18 ++++++++++++++++++ 3 files changed, 19 insertions(+), 3 deletions(-) create mode 100644 include/parade.h
diff --git a/arch/arm/include/asm/arch-exynos/system.h b/arch/arm/include/asm/arch-exynos/system.h index 320763f..4968d3d 100644 --- a/arch/arm/include/asm/arch-exynos/system.h +++ b/arch/arm/include/asm/arch-exynos/system.h @@ -41,7 +41,4 @@ void set_usbhost_mode(unsigned int mode); void set_system_display_ctrl(void); int exynos_lcd_early_init(const void *blob);
-/* Initialize the Parade dP<->LVDS bridge if present */ -int parade_init(const void *blob); - #endif /* _EXYNOS4_SYSTEM_H */ diff --git a/board/samsung/smdk5420/smdk5420.c b/board/samsung/smdk5420/smdk5420.c index a691222..55f0ea2 100644 --- a/board/samsung/smdk5420/smdk5420.c +++ b/board/samsung/smdk5420/smdk5420.c @@ -9,6 +9,7 @@ #include <asm/io.h> #include <i2c.h> #include <lcd.h> +#include <parade.h> #include <spi.h> #include <errno.h> #include <asm/gpio.h> diff --git a/include/parade.h b/include/parade.h new file mode 100644 index 0000000..887f56d --- /dev/null +++ b/include/parade.h @@ -0,0 +1,18 @@ +/* + * (C) Copyright 2012 Samsung Electronics + * Donghwa Lee dh09.lee@samsung.com + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +#ifndef __PARADE_H__ +#define __PARADE_H__ + +/* Initialize the Parade dP<->LVDS bridge if present */ +#ifdef CONFIG_VIDEO_PARADE +int parade_init(const void *blob); +#else +static inline int parade_init(const void *blob) { return -1; } +#endif + +#endif /* __PARADE_H__ */
On 06/12/14 02:12, Sjoerd Simons wrote:
With current u-boot-samsung HEAD on a peach-pi the following error is printed: exynos_lcd_power_on: ps8625_init() failed
Which is not surprising given that chip does not exist on these boards.
Changes since v2:
- Move the parade_init function to its own header file
Changes since v1:
- Only change the DTS for peach-pi not the default config. Further configuration changes will be done seperately
- Use the approach as suggested by Ajay Kumar to fix compilation without parade support
Sjoerd Simons (2): Exynos5800: The Peach-Pi board does not have a Parade video bridge exynos5420: fix compilation without parade video
arch/arm/dts/exynos5800-peach-pi.dts | 5 ----- arch/arm/include/asm/arch-exynos/system.h | 3 --- board/samsung/smdk5420/smdk5420.c | 1 + include/parade.h | 18 ++++++++++++++++++ 4 files changed, 19 insertions(+), 8 deletions(-) create mode 100644 include/parade.h
applied to u-boot-samsung.
Thanks, Minkyu Kang.
participants (2)
-
Minkyu Kang -
Sjoerd Simons