Re: [U-Boot] [linux-sunxi] [PATCH v2 1/2] sunxi: Rename bananapi board as bananapi m1
Hi,
On Tue, May 30, 2017 at 5:58 AM, Karsten Merker merker@debian.org wrote:
On Tue, May 30, 2017 at 01:06:54AM +0530, Jagan Teki wrote:
From: Jagan Teki jagan@amarulasolutions.com
from BPI(BIPAI KEJI LIMITED) products the Bananapi board is named as 'Bananapi M1' and this is the starting bananapi board from M1 series.
So rename the board defconfig, dts and suffix 'M1' on model for the same so-that next sequence on bananapi starts like M1 Plus, M2 and so.on
Hello,
the equivalent change in the kernel has been NACKed by me as with the proposed change the installation of a newer kernel would break a large number of existing end user systems (which rely on the old dts file name and on the old model string).
U-Boot should keep the same dts as the kernel, so this effectively means a NACK to this change for u-boot as well.
Do the distros also keep a list of defconfig targets to build for U-boot? It seems that way for Debian. I imagine just changing the defconfig names would be troublesome for the maintainers.
ChenYu
On Tue, May 30, 2017 at 09:31:13AM +0800, Chen-Yu Tsai wrote:
Hi,
On Tue, May 30, 2017 at 5:58 AM, Karsten Merker merker@debian.org wrote:
On Tue, May 30, 2017 at 01:06:54AM +0530, Jagan Teki wrote:
From: Jagan Teki jagan@amarulasolutions.com
from BPI(BIPAI KEJI LIMITED) products the Bananapi board is named as 'Bananapi M1' and this is the starting bananapi board from M1 series.
So rename the board defconfig, dts and suffix 'M1' on model for the same so-that next sequence on bananapi starts like M1 Plus, M2 and so.on
Hello,
the equivalent change in the kernel has been NACKed by me as with the proposed change the installation of a newer kernel would break a large number of existing end user systems (which rely on the old dts file name and on the old model string).
U-Boot should keep the same dts as the kernel, so this effectively means a NACK to this change for u-boot as well.
Do the distros also keep a list of defconfig targets to build for U-boot? It seems that way for Debian. I imagine just changing the defconfig names would be troublesome for the maintainers.
Not only the distros, but all the buildsystems too. This is really something we shouldn't change, ever.
Maxime
participants (2)
-
Chen-Yu Tsai -
Maxime Ripard