[PATCH] buildman: Pass -Werror to the host compiler too
The host compiler is not failing on warnings at present, when the -E flag is used in buildman. Add the required flag to fix this.
Signed-off-by: Simon Glass sjg@chromium.org ---
tools/buildman/builderthread.py | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index 879ff138ad7..635865c21c8 100644 --- a/tools/buildman/builderthread.py +++ b/tools/buildman/builderthread.py @@ -253,6 +253,7 @@ class BuilderThread(threading.Thread): args.extend(['-j', str(self.builder.num_jobs)]) if self.builder.warnings_as_errors: args.append('KCFLAGS=-Werror') + args.append('HOSTCFLAGS=-Werror') if self.builder.allow_missing: args.append('BINMAN_ALLOW_MISSING=1') if self.builder.no_lto:
On Fri, Apr 28, 2023 at 01:50:48PM -0600, Simon Glass wrote:
The host compiler is not failing on warnings at present, when the -E flag is used in buildman. Add the required flag to fix this.
Signed-off-by: Simon Glass sjg@chromium.org
Since I reported this with a CI build that didn't fail, I can see now it does work: https://source.denx.de/u-boot/u-boot/-/jobs/619681
Tested-by: Tom Rini trini@konsulko.com
On Fri, Apr 28, 2023 at 01:50:48PM -0600, Simon Glass wrote:
The host compiler is not failing on warnings at present, when the -E flag is used in buildman. Add the required flag to fix this.
Signed-off-by: Simon Glass sjg@chromium.org Tested-by: Tom Rini trini@konsulko.com
Applied to u-boot/master, thanks!
participants (2)
-
Simon Glass -
Tom Rini