[U-Boot] [PATCH] Let target 'cscope' follow symbolic links
Without telling 'find' to follow symbolic links, files under include/asm and arch/$(ARCH)/include/asm/arch are not added to the cscope file list.
Signed-off-by: Horst Kronstorfer hkronsto@frequentis.com --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile index e56fa02..deff642 100644 --- a/Makefile +++ b/Makefile @@ -479,7 +479,7 @@ etags: etags -a -o $(obj)etags `find $(TAG_SUBDIRS) \ -name '*.[chS]' -print` cscope: - find $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files + find -L $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files cscope -b -q -k
SYSTEM_MAP = \
Hi Horst,
Without telling 'find' to follow symbolic links, files under include/asm and arch/$(ARCH)/include/asm/arch are not added to the cscope file list.
While your point seems valid, I see three occurrences of such a find pattern and you fix only one. May I ask you to fix all of them so users of tags and etags are not left behind?
Thanks! Detlev
-----Original Message----- From: Detlev Zundel [mailto:dzu@denx.de] Sent: Freitag, 15. Juli 2011 09:34 To: KRONSTORFER Horst Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] Let target 'cscope' follow symbolic links
Hi Horst,
Without telling 'find' to follow symbolic links, files under include/asm and arch/$(ARCH)/include/asm/arch are not added to the cscope file list.
While your point seems valid, I see three occurrences of such a find pattern and you fix only one. May I ask you to fix all of them so users of tags and etags are not left behind?
you're right ... will do!
br -h
Thanks! Detlev
-- A zen-buddhist walked into a pizza shop and said, "Make me one with everything." -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu@denx.de
From: Horst Kronstorfer hkronsto@frequentis.com
Without telling 'find' to follow symbolic links, files under include/asm and arch/$(ARCH)/include/asm/arch are not added to the indexing file list.
Signed-off-by: Horst Kronstorfer hkronsto@frequentis.com
Changes for v2: - Apply this change to all source cross-reference targets --- Makefile | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile index e56fa02..e86a81a 100644 --- a/Makefile +++ b/Makefile @@ -471,15 +471,17 @@ TAG_SUBDIRS = $(SUBDIRS) TAG_SUBDIRS += $(dir $(__LIBS)) TAG_SUBDIRS += include
+FIND := find -L + tags ctags: - ctags -w -o $(obj)ctags `find $(TAG_SUBDIRS) \ + ctags -w -o $(obj)ctags `$(FIND) $(TAG_SUBDIRS) \ -name '*.[chS]' -print`
etags: - etags -a -o $(obj)etags `find $(TAG_SUBDIRS) \ + etags -a -o $(obj)etags `$(FIND) $(TAG_SUBDIRS) \ -name '*.[chS]' -print` cscope: - find $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files + $(FIND) $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files cscope -b -q -k
SYSTEM_MAP = \
Hi Horst,
From: Horst Kronstorfer hkronsto@frequentis.com
Without telling 'find' to follow symbolic links, files under include/asm and arch/$(ARCH)/include/asm/arch are not added to the indexing file list.
Signed-off-by: Horst Kronstorfer hkronsto@frequentis.com
Changes for v2: - Apply this change to all source cross-reference targets
This needs to go below the '---' as it is not part of the git commit message.
Makefile | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile index e56fa02..e86a81a 100644 --- a/Makefile +++ b/Makefile @@ -471,15 +471,17 @@ TAG_SUBDIRS = $(SUBDIRS) TAG_SUBDIRS += $(dir $(__LIBS)) TAG_SUBDIRS += include
+FIND := find -L
I really dislike this approach. I would never expect a variable $(FIND) to already include options. So if you want to go that way then also introduce FINDFLAGS.
Thanks Detlev
From: Horst Kronstorfer hkronsto@frequentis.com
Tell 'find' to follow symbolic links, so that files under include/asm and arch/$(ARCH)/include/asm/arch are added to the indexing file list.
Signed-off-by: Horst Kronstorfer hkronsto@frequentis.com --- Changes for v2: - Apply this change to all source cross-reference targets Changes for v3: - Introduce FINDFLAGS
Makefile | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile index e56fa02..bc51428 100644 --- a/Makefile +++ b/Makefile @@ -471,15 +471,19 @@ TAG_SUBDIRS = $(SUBDIRS) TAG_SUBDIRS += $(dir $(__LIBS)) TAG_SUBDIRS += include
+FIND := find +FINDFLAGS := -L + tags ctags: - ctags -w -o $(obj)ctags `find $(TAG_SUBDIRS) \ + ctags -w -o $(obj)ctags `$(FIND) $(FINDFLAGS) $(TAG_SUBDIRS) \ -name '*.[chS]' -print`
etags: - etags -a -o $(obj)etags `find $(TAG_SUBDIRS) \ + etags -a -o $(obj)etags `$(FIND) $(FINDFLAGS) $(TAG_SUBDIRS) \ -name '*.[chS]' -print` cscope: - find $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files + $(FIND) $(FINDFLAGS) $(TAG_SUBDIRS) -name '*.[chS]' -print > \ + cscope.files cscope -b -q -k
SYSTEM_MAP = \
Hi,
From: Horst Kronstorfer hkronsto@frequentis.com
Tell 'find' to follow symbolic links, so that files under include/asm and arch/$(ARCH)/include/asm/arch are added to the indexing file list.
Signed-off-by: Horst Kronstorfer hkronsto@frequentis.com
I guess I would have placed the definitions more at the beginning of the makefile but probably that's personal taste. So
Acked-by: Detlev Zundel dzu@denx.de
Thanks! Detlev
Dear hkronsto@frequentis.com,
In message 1310988078-30444-1-git-send-email-hkronsto@frequentis.com you wrote:
From: Horst Kronstorfer hkronsto@frequentis.com
Tell 'find' to follow symbolic links, so that files under include/asm and arch/$(ARCH)/include/asm/arch are added to the indexing file list.
Signed-off-by: Horst Kronstorfer hkronsto@frequentis.com
Changes for v2: - Apply this change to all source cross-reference targets Changes for v3: - Introduce FINDFLAGS
Makefile | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (5)
-
Detlev Zundel -
hkronsto＠frequentis.com -
Horst Kronstorfer
-
KRONSTORFER Horst -
Wolfgang Denk