----- "Marek Vasut" marek.vasut@gmail.com wrote:

On Friday, August 26, 2011 08:36:51 AM Ajay Bhargav wrote:

...

This patch adds support for Fast Ethernet Controller driver for Armada100 series.

Signed-off-by: Ajay Bhargav ajay.bhargav@einfochips.com

Hi, please don't forget to CC me next time ;-)

Sure, I'll do that.. you and Mike both :)

[...]

...

+static int smi_reg_read(const char *devname, u8 phy_addr, u8

phy_reg,

...

• 	u16 *value)
  

+{

• struct eth_device *dev = eth_get_dev_by_name(devname);
• struct armdfec_device *darmdfec = to_darmdfec(dev);
• struct armdfec_reg *regs = darmdfec->regs;
• u32 val, reg_data;
• if (phy_addr == PHY_ADR_REQ && phy_reg == PHY_ADR_REQ) {

• reg_data = readl(&regs->phyadr);
  

• *value = (u16) (reg_data & 0x1f);
  

Do you need this cast?

I thought I fixed most of the cast related issues :) looks like I missed one.

Unify the error reporting please.

I will do that...

It looks good, just a few nits

Cheers!

Cheers! :)

Ajay Bhargav