[U-Boot-Users] Fix endianess conversion in usb_ohci.c
I think this must be swapped (result may be equal). --- drivers/usb/usb_ohci.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/usb_ohci.c b/drivers/usb/usb_ohci.c index ee0f2e4..29fcbbe 100644 --- a/drivers/usb/usb_ohci.c +++ b/drivers/usb/usb_ohci.c @@ -1218,9 +1218,9 @@ pkt_print(NULL, dev, pipe, buffer, trans }
bmRType_bReq = cmd->requesttype | (cmd->request << 8); - wValue = cpu_to_le16 (cmd->value); - wIndex = cpu_to_le16 (cmd->index); - wLength = cpu_to_le16 (cmd->length); + wValue = le16_to_cpu (cmd->value); + wIndex = le16_to_cpu (cmd->index); + wLength = le16_to_cpu (cmd->length);
info("Root-Hub: adr: %2x cmd(%1x): %08x %04x %04x %04x", dev->devnum, 8, bmRType_bReq, wValue, wIndex, wLength);
In message 48348F72.9218.D2AA4@ceggers.gmx.de you wrote:
I think this must be swapped (result may be equal).
drivers/usb/usb_ohci.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
Markus, can you please comment on this patch?
Thanks in advance.
Best regards,
Wolfgang Denk
Dear Wolfgang,
Sorry for the delay, I was on holiday too.
Wolfgang Denk wd@denx.de writes:
In message 48348F72.9218.D2AA4@ceggers.gmx.de you wrote:
I think this must be swapped (result may be equal).
drivers/usb/usb_ohci.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
Markus, can you please comment on this patch?
I believe this was merged as commit fb63939b
Viele Grüße / Best regards
Markus Klotzbücher
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de
participants (3)
-
Christian Eggers -
Markus Klotzbücher -
Wolfgang Denk