Re: [U-Boot] kgdb: drop duplicate debugger_exception_handler
Dear Mike,
it seems your commit cbb0cab1d929839d1cf170b54b1fef05896433ea:
Author: Mike Frysinger vapier@gentoo.org Date: Mon Dec 21 18:40:43 2009 -0500
kgdb: drop duplicate debugger_exception_handler
The debugger_exception_handler definition is the same for everyone, so use the common one now.
Signed-off-by: Mike Frysinger vapier@gentoo.org
breaks building of MPC8xx based boards that have KGDB support enabled; for example:
$ ./MAKEALL RBC823 Configuring for RBC823 board... traps.c: In function 'MachineCheckException': traps.c:126: error: 'debugger_exception_handler' undeclared (first use in this function) traps.c:126: error: (Each undeclared identifier is reported only once traps.c:126: error: for each function it appears in.) traps.c: In function 'AlignmentException': traps.c:159: error: 'debugger_exception_handler' undeclared (first use in this function) traps.c: In function 'ProgramCheckException': traps.c:171: error: 'debugger_exception_handler' undeclared (first use in this function) traps.c: In function 'SoftEmuException': traps.c:183: error: 'debugger_exception_handler' undeclared (first use in this function) traps.c: In function 'UnknownException': traps.c:196: error: 'debugger_exception_handler' undeclared (first use in this function)
[Ditto for cogent_mpc8xx]
Could you please have a look?
Thanks in advance.
Best regards,
Wolfgang Denk
Commit cbb0cab1d929839d broke some platforms which used kgdb code but didn't actually include kgdb.h. So include kgdb.h in all the relevant traps code.
Signed-off-by: Mike Frysinger vapier@gentoo.org --- cpu/74xx_7xx/traps.c | 1 + cpu/mpc512x/traps.c | 1 + cpu/mpc5xx/traps.c | 1 + cpu/mpc5xxx/traps.c | 1 + cpu/mpc8220/traps.c | 1 + cpu/mpc8260/traps.c | 1 + cpu/mpc83xx/traps.c | 1 + cpu/mpc85xx/traps.c | 1 + cpu/mpc86xx/traps.c | 1 + cpu/mpc8xx/traps.c | 1 + 10 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/cpu/74xx_7xx/traps.c b/cpu/74xx_7xx/traps.c index 24e28e2..1d5dd01 100644 --- a/cpu/74xx_7xx/traps.c +++ b/cpu/74xx_7xx/traps.c @@ -34,6 +34,7 @@
#include <common.h> #include <command.h> +#include <kgdb.h> #include <asm/processor.h>
#ifdef CONFIG_AMIGAONEG3SE diff --git a/cpu/mpc512x/traps.c b/cpu/mpc512x/traps.c index 8000fab..786f4a5 100644 --- a/cpu/mpc512x/traps.c +++ b/cpu/mpc512x/traps.c @@ -28,6 +28,7 @@ */
#include <common.h> +#include <kgdb.h> #include <asm/processor.h>
DECLARE_GLOBAL_DATA_PTR; diff --git a/cpu/mpc5xx/traps.c b/cpu/mpc5xx/traps.c index cc8e091..6882c21 100644 --- a/cpu/mpc5xx/traps.c +++ b/cpu/mpc5xx/traps.c @@ -34,6 +34,7 @@
#include <common.h> #include <command.h> +#include <kgdb.h> #include <asm/processor.h>
#if defined(CONFIG_CMD_BEDBUG) diff --git a/cpu/mpc5xxx/traps.c b/cpu/mpc5xxx/traps.c index 2a09153..934a2f2 100644 --- a/cpu/mpc5xxx/traps.c +++ b/cpu/mpc5xxx/traps.c @@ -35,6 +35,7 @@
#include <common.h> #include <command.h> +#include <kgdb.h> #include <asm/processor.h>
/* Returns 0 if exception not found and fixup otherwise. */ diff --git a/cpu/mpc8220/traps.c b/cpu/mpc8220/traps.c index f98d40f..4565780 100644 --- a/cpu/mpc8220/traps.c +++ b/cpu/mpc8220/traps.c @@ -35,6 +35,7 @@
#include <common.h> #include <command.h> +#include <kgdb.h> #include <asm/processor.h>
/* Returns 0 if exception not found and fixup otherwise. */ diff --git a/cpu/mpc8260/traps.c b/cpu/mpc8260/traps.c index f9f4dea..d216f71 100644 --- a/cpu/mpc8260/traps.c +++ b/cpu/mpc8260/traps.c @@ -34,6 +34,7 @@
#include <common.h> #include <command.h> +#include <kgdb.h> #include <asm/processor.h> #include <asm/m8260_pci.h>
diff --git a/cpu/mpc83xx/traps.c b/cpu/mpc83xx/traps.c index 3b09a62..9d71b8b 100644 --- a/cpu/mpc83xx/traps.c +++ b/cpu/mpc83xx/traps.c @@ -27,6 +27,7 @@
#include <common.h> #include <command.h> +#include <kgdb.h> #include <asm/processor.h> #include <asm/mpc8349_pci.h>
diff --git a/cpu/mpc85xx/traps.c b/cpu/mpc85xx/traps.c index 241ebd5..10108d8 100644 --- a/cpu/mpc85xx/traps.c +++ b/cpu/mpc85xx/traps.c @@ -38,6 +38,7 @@
#include <common.h> #include <command.h> +#include <kgdb.h> #include <asm/processor.h>
DECLARE_GLOBAL_DATA_PTR; diff --git a/cpu/mpc86xx/traps.c b/cpu/mpc86xx/traps.c index ad005c3..406403e 100644 --- a/cpu/mpc86xx/traps.c +++ b/cpu/mpc86xx/traps.c @@ -32,6 +32,7 @@
#include <common.h> #include <command.h> +#include <kgdb.h> #include <asm/processor.h>
DECLARE_GLOBAL_DATA_PTR; diff --git a/cpu/mpc8xx/traps.c b/cpu/mpc8xx/traps.c index f357c8d..6efe8e0 100644 --- a/cpu/mpc8xx/traps.c +++ b/cpu/mpc8xx/traps.c @@ -34,6 +34,7 @@
#include <common.h> #include <command.h> +#include <kgdb.h> #include <asm/processor.h>
#if defined(CONFIG_CMD_BEDBUG)
Dear Mike Frysinger,
In message 1265661016-9444-1-git-send-email-vapier@gentoo.org you wrote:
Commit cbb0cab1d929839d broke some platforms which used kgdb code but didn't actually include kgdb.h. So include kgdb.h in all the relevant traps code.
Signed-off-by: Mike Frysinger vapier@gentoo.org
Thanks, applied.
Best regards,
Wolfgang Denk
participants (2)
-
Mike Frysinger -
Wolfgang Denk