[U-Boot] Bring tinker-rk3288 back into SPL size limit?
Hey,
With Heinrich's series to enforce a size limit on SPL and Simon Goldschmidt's enhancements on top of that, we're now seeing that tinker-rk3288 has an SPL that is too large to function. And it's now also causing the build to fail. So, good that we're catching this at least. Can you please look into what we need to do to get the image to fit within the size constraints? Thanks!
+Kever.
On 08.06.2019, at 20:05, Tom Rini trini@konsulko.com wrote:
Hey,
With Heinrich's series to enforce a size limit on SPL and Simon Goldschmidt's enhancements on top of that, we're now seeing that tinker-rk3288 has an SPL that is too large to function. And it's now also causing the build to fail. So, good that we're catching this at least. Can you please look into what we need to do to get the image to fit within the size constraints? Thanks!
-- Tom
On Sat, Jun 8, 2019 at 11:35 PM Tom Rini trini@konsulko.com wrote:
Hey,
With Heinrich's series to enforce a size limit on SPL and Simon Goldschmidt's enhancements on top of that, we're now seeing that tinker-rk3288 has an SPL that is too large to function. And it's now also causing the build to fail. So, good that we're catching this at least. Can you please look into what we need to do to get the image to fit within the size constraints? Thanks!
I have used TPL before with tinker while supporting falcon. I think we can use TPL here, what do you think?
On 06/10/2019 09:36 PM, Jagan Teki wrote:
On Sat, Jun 8, 2019 at 11:35 PM Tom Rini trini@konsulko.com wrote:
Hey,
With Heinrich's series to enforce a size limit on SPL and Simon Goldschmidt's enhancements on top of that, we're now seeing that tinker-rk3288 has an SPL that is too large to function. And it's now also causing the build to fail. So, good that we're catching this at least. Can you please look into what we need to do to get the image to fit within the size constraints? Thanks!
I have used TPL before with tinker while supporting falcon. I think we can use TPL here, what do you think?
Yes, enable TPL is a solution for this issue. Since we are not able to control the SPL size easily on upstream, and most rockchip SoCs have size limit for SRAM, so other than Tinker board, there should be many other rk3288 based boards have the similar issue.
Thanks, - Kever
Hi Tom,
I got a Tinker board today and try to boot with SD card to enable TPL.
The SPL for Tinker board is broken and the size is too big at v2019.04, and v2019.01 is OK.
Other than size limit, seems there are some other issue for Tinker board TPL,
I can't get any debug message from uart even after I enable TPL(works correctly)
and move the SPL to DDR without size limit, very strange, I need
more time to debug the SPL issue.
Thanks, - Kever On 06/18/2019 03:40 PM, Kever Yang wrote:
On 06/10/2019 09:36 PM, Jagan Teki wrote:
On Sat, Jun 8, 2019 at 11:35 PM Tom Rini trini@konsulko.com wrote:
Hey,
With Heinrich's series to enforce a size limit on SPL and Simon Goldschmidt's enhancements on top of that, we're now seeing that tinker-rk3288 has an SPL that is too large to function. And it's now also causing the build to fail. So, good that we're catching this at least. Can you please look into what we need to do to get the image to fit within the size constraints? Thanks!
I have used TPL before with tinker while supporting falcon. I think we can use TPL here, what do you think?
Yes, enable TPL is a solution for this issue. Since we are not able to control the SPL size easily on upstream, and most rockchip SoCs have size limit for SRAM, so other than Tinker board, there should be many other rk3288 based boards have the similar issue.
Thanks,
- Kever
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
On Tue, Jun 25, 2019 at 06:09:32PM +0800, Kever Yang wrote:
Hi Tom,
I got a Tinker board today and try to boot with SD card to enable TPL.
The SPL for Tinker board is broken and the size is too big at v2019.04, and v2019.01 is OK.
Other than size limit, seems there are some other issue for Tinker board TPL,
I can't get any debug message from uart even after I enable TPL(works correctly)
and move the SPL to DDR without size limit, very strange, I need
more time to debug the SPL issue.
for the SPL size issue try master, it contains the following:
commit 68b90e57bc034e237923b02acb633dc4e91d44cb Author: Heinrich Schuchardt xypron.glpk@gmx.de AuthorDate: Wed Feb 27 20:05:43 2019 +0100 Commit: Tom Rini trini@konsulko.com CommitDate: Tue Jun 11 08:13:05 2019 -0400
configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's disable it.
Suggested-by: David Wu david.wu@rock-chips.com Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de Reviewed-by: David Wu david.wu@rock-chips.com Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig index 4b48689ee8..0e8cf73fe9 100644 --- a/configs/tinker-rk3288_defconfig +++ b/configs/tinker-rk3288_defconfig @@ -20,7 +20,6 @@ CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_TEXT_BASE=0xff704000 CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 -CONFIG_SPL_I2C_SUPPORT=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y
Thanks,
- Kever
On 06/18/2019 03:40 PM, Kever Yang wrote:
On 06/10/2019 09:36 PM, Jagan Teki wrote:
On Sat, Jun 8, 2019 at 11:35 PM Tom Rini trini@konsulko.com wrote:
Hey,
With Heinrich's series to enforce a size limit on SPL and Simon Goldschmidt's enhancements on top of that, we're now seeing that tinker-rk3288 has an SPL that is too large to function. And it's now also causing the build to fail. So, good that we're catching this at least. Can you please look into what we need to do to get the image to fit within the size constraints? Thanks!
I have used TPL before with tinker while supporting falcon. I think we can use TPL here, what do you think?
Yes, enable TPL is a solution for this issue. Since we are not able to control the SPL size easily on upstream, and most rockchip SoCs have size limit for SRAM, so other than Tinker board, there should be many other rk3288 based boards have the similar issue.
Thanks,
- Kever
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
participants (5)
-
Jagan Teki -
Jonathan Gray -
Kever Yang -
Philipp Tomsich -
Tom Rini