[U-Boot] [PATCH 0/3] omap3: cm-t3517: series of non critical fixes
These patches fix non critical issues, required to sync CM-T3517 mainline U-Boot with the that, shipped with the boards.
Dmitry Lifshitz (3): omap3: cm-t3517: enable 'netretry' and setup timeout omap3: cm-t3517: fix MMC1 pinmux omap3: cm-t3517: change environment size
board/compulab/cm_t3517/mux.c | 12 ++++++------ include/configs/cm_t3517.h | 7 +++++-- 2 files changed, 11 insertions(+), 8 deletions(-)
SBC-T3517 evaluation board has two Eth interfaces. Enable network retry of another interface if the default if failed or disconnected.
Add 'netretry=yes' in the default env. Setup relevant timeout values in the board config file.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il --- include/configs/cm_t3517.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/configs/cm_t3517.h b/include/configs/cm_t3517.h index a8d0b97..2d16799 100644 --- a/include/configs/cm_t3517.h +++ b/include/configs/cm_t3517.h @@ -170,6 +170,7 @@ "loadaddr=0x82000000\0" \ "baudrate=115200\0" \ "console=ttyO2,115200n8\0" \ + "netretry=yes\0" \ "mpurate=auto\0" \ "vram=12M\0" \ "dvimode=1024x768MR-16@60\0" \ @@ -275,6 +276,8 @@ #define CONFIG_SMC911X #define CONFIG_SMC911X_32_BIT #define CONFIG_SMC911X_BASE (0x2C000000 + (16 << 20)) +#define CONFIG_ARP_TIMEOUT 200UL +#define CONFIG_NET_RETRY_COUNT 5 #endif /* CONFIG_CMD_NET */
/* additions for new relocation code, must be added to all boards */
On 09/08/15 09:50, Dmitry Lifshitz wrote:
SBC-T3517 evaluation board has two Eth interfaces. Enable network retry of another interface if the default if failed or disconnected.
Add 'netretry=yes' in the default env. Setup relevant timeout values in the board config file.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il
Acked-by: Igor Grinberg grinberg@compulab.co.il
include/configs/cm_t3517.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/configs/cm_t3517.h b/include/configs/cm_t3517.h index a8d0b97..2d16799 100644 --- a/include/configs/cm_t3517.h +++ b/include/configs/cm_t3517.h @@ -170,6 +170,7 @@ "loadaddr=0x82000000\0" \ "baudrate=115200\0" \ "console=ttyO2,115200n8\0" \
- "netretry=yes\0" \ "mpurate=auto\0" \ "vram=12M\0" \ "dvimode=1024x768MR-16@60\0" \
@@ -275,6 +276,8 @@ #define CONFIG_SMC911X #define CONFIG_SMC911X_32_BIT #define CONFIG_SMC911X_BASE (0x2C000000 + (16 << 20)) +#define CONFIG_ARP_TIMEOUT 200UL +#define CONFIG_NET_RETRY_COUNT 5 #endif /* CONFIG_CMD_NET */
/* additions for new relocation code, must be added to all boards */
On Tue, Sep 08, 2015 at 09:50:00AM +0300, Dmitry Lifshitz wrote:
SBC-T3517 evaluation board has two Eth interfaces. Enable network retry of another interface if the default if failed or disconnected.
Add 'netretry=yes' in the default env. Setup relevant timeout values in the board config file.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il Acked-by: Igor Grinberg grinberg@compulab.co.il
Applied to u-boot/master, thanks!
Fix MMC1 pinmux setup, thus enable SD/MMC card support with CM-T3517.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il --- board/compulab/cm_t3517/mux.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/board/compulab/cm_t3517/mux.c b/board/compulab/cm_t3517/mux.c index 88ce2cc..f31f19e 100644 --- a/board/compulab/cm_t3517/mux.c +++ b/board/compulab/cm_t3517/mux.c @@ -121,12 +121,12 @@ void set_muxconf_regs(void) MUX_VAL(CP(UART2_RX), (IEN | PTD | EN | M4)); /*GPIO_147*/
/* MMC1 */ - MUX_VAL(CP(MMC1_CLK), (IDIS | PTU | EN | M0)); - MUX_VAL(CP(MMC1_CMD), (IEN | PTU | EN | M0)); - MUX_VAL(CP(MMC1_DAT0), (IEN | PTU | EN | M0)); - MUX_VAL(CP(MMC1_DAT1), (IEN | PTU | EN | M0)); - MUX_VAL(CP(MMC1_DAT2), (IEN | PTU | EN | M0)); - MUX_VAL(CP(MMC1_DAT3), (IEN | PTU | EN | M0)); + MUX_VAL(CP(MMC1_CLK), (IEN | PTU | EN | M0)); + MUX_VAL(CP(MMC1_CMD), (IEN | PTU | DIS | M0)); + MUX_VAL(CP(MMC1_DAT0), (IEN | PTU | DIS | M0)); + MUX_VAL(CP(MMC1_DAT1), (IEN | PTU | DIS | M0)); + MUX_VAL(CP(MMC1_DAT2), (IEN | PTU | DIS | M0)); + MUX_VAL(CP(MMC1_DAT3), (IEN | PTU | DIS | M0));
/* DSS */ MUX_VAL(CP(DSS_PCLK), (IDIS | PTD | DIS | M0));
On 09/08/15 09:50, Dmitry Lifshitz wrote:
Fix MMC1 pinmux setup, thus enable SD/MMC card support with CM-T3517.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il
Acked-by: Igor Grinberg grinberg@compulab.co.il
board/compulab/cm_t3517/mux.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/board/compulab/cm_t3517/mux.c b/board/compulab/cm_t3517/mux.c index 88ce2cc..f31f19e 100644 --- a/board/compulab/cm_t3517/mux.c +++ b/board/compulab/cm_t3517/mux.c @@ -121,12 +121,12 @@ void set_muxconf_regs(void) MUX_VAL(CP(UART2_RX), (IEN | PTD | EN | M4)); /*GPIO_147*/
/* MMC1 */
- MUX_VAL(CP(MMC1_CLK), (IDIS | PTU | EN | M0));
- MUX_VAL(CP(MMC1_CMD), (IEN | PTU | EN | M0));
- MUX_VAL(CP(MMC1_DAT0), (IEN | PTU | EN | M0));
- MUX_VAL(CP(MMC1_DAT1), (IEN | PTU | EN | M0));
- MUX_VAL(CP(MMC1_DAT2), (IEN | PTU | EN | M0));
- MUX_VAL(CP(MMC1_DAT3), (IEN | PTU | EN | M0));
MUX_VAL(CP(MMC1_CLK), (IEN | PTU | EN | M0));
MUX_VAL(CP(MMC1_CMD), (IEN | PTU | DIS | M0));
MUX_VAL(CP(MMC1_DAT0), (IEN | PTU | DIS | M0));
MUX_VAL(CP(MMC1_DAT1), (IEN | PTU | DIS | M0));
MUX_VAL(CP(MMC1_DAT2), (IEN | PTU | DIS | M0));
MUX_VAL(CP(MMC1_DAT3), (IEN | PTU | DIS | M0));
/* DSS */ MUX_VAL(CP(DSS_PCLK), (IDIS | PTD | DIS | M0));
On Tue, Sep 08, 2015 at 09:50:01AM +0300, Dmitry Lifshitz wrote:
Fix MMC1 pinmux setup, thus enable SD/MMC card support with CM-T3517.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il Acked-by: Igor Grinberg grinberg@compulab.co.il
Applied to u-boot/master, thanks!
Mainline CM-T3517 U-Boot environment size differs from the that one shipped with CM-T3517 boards.
Update environment size, to avoid backward compatability issues.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il --- include/configs/cm_t3517.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/cm_t3517.h b/include/configs/cm_t3517.h index 2d16799..36488d7 100644 --- a/include/configs/cm_t3517.h +++ b/include/configs/cm_t3517.h @@ -66,8 +66,8 @@ /* * Size of malloc() pool */ -#define CONFIG_ENV_SIZE (16 << 10) /* 16 KiB */ -#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (128 << 10)) +#define CONFIG_ENV_SIZE (128 << 10) /* 128 KiB */ +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (512 << 10))
/* * Hardware drivers
Hi Dima,
On 09/08/15 09:50, Dmitry Lifshitz wrote:
Mainline CM-T3517 U-Boot environment size differs from the that one shipped with CM-T3517 boards.
There is some strangeness in the above sentence...
Update environment size, to avoid backward compatability issues.
s/compatability/compatibility/
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il
include/configs/cm_t3517.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/cm_t3517.h b/include/configs/cm_t3517.h index 2d16799..36488d7 100644 --- a/include/configs/cm_t3517.h +++ b/include/configs/cm_t3517.h @@ -66,8 +66,8 @@ /*
- Size of malloc() pool
*/ -#define CONFIG_ENV_SIZE (16 << 10) /* 16 KiB */ -#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (128 << 10)) +#define CONFIG_ENV_SIZE (128 << 10) /* 128 KiB */ +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (512 << 10))
Why do you change CONFIG_SYS_MALLOC_LEN? Isn't it not enough? If so, I would expect to see some explanation in the commit message.
Mainline CM-T3517 U-Boot environment size differs from that one shipped with CM-T3517 boards.
Update environment size, to avoid backward compatibility issues.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il ---
Changes in v2:
* Removed unjustified CONFIG_SYS_MALLOC_LEN change.
include/configs/cm_t3517.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/cm_t3517.h b/include/configs/cm_t3517.h index 2d16799..fbc10dd 100644 --- a/include/configs/cm_t3517.h +++ b/include/configs/cm_t3517.h @@ -66,7 +66,7 @@ /* * Size of malloc() pool */ -#define CONFIG_ENV_SIZE (16 << 10) /* 16 KiB */ +#define CONFIG_ENV_SIZE (128 << 10) /* 128 KiB */ #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (128 << 10))
/*
On 09/09/15 11:25, Dmitry Lifshitz wrote:
Mainline CM-T3517 U-Boot environment size differs from that one shipped with CM-T3517 boards.
Update environment size, to avoid backward compatibility issues.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il
Acked-by: Igor Grinberg grinberg@compulab.co.il
Changes in v2:
* Removed unjustified CONFIG_SYS_MALLOC_LEN change.include/configs/cm_t3517.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/cm_t3517.h b/include/configs/cm_t3517.h index 2d16799..fbc10dd 100644 --- a/include/configs/cm_t3517.h +++ b/include/configs/cm_t3517.h @@ -66,7 +66,7 @@ /*
- Size of malloc() pool
*/ -#define CONFIG_ENV_SIZE (16 << 10) /* 16 KiB */ +#define CONFIG_ENV_SIZE (128 << 10) /* 128 KiB */ #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (128 << 10))
/*
On Wed, Sep 09, 2015 at 11:25:39AM +0300, Dmitry Lifshitz wrote:
Mainline CM-T3517 U-Boot environment size differs from that one shipped with CM-T3517 boards.
Update environment size, to avoid backward compatibility issues.
Signed-off-by: Dmitry Lifshitz lifshitz@compulab.co.il Acked-by: Igor Grinberg grinberg@compulab.co.il
Applied to u-boot/master, thanks!
participants (3)
-
Dmitry Lifshitz -
Igor Grinberg -
Tom Rini