On Wed, Jun 09, 2004 at 02:21:24PM +0200, Wolfgang Denk wrote:

...

@@ -340,6 +343,9 @@ #define FLASH_AMDL163T 0x00B2 /* AMD AM29DL163T (2M x 16 ) */ #define FLASH_AMDL163B 0x00B3

+#define FLASH_28F128K3 0x00A7 /* Intel 28F128K3 ( 128M = 8M x 16 ) */

This is IMHO wrong. The comment a few lines above reads:

Be careful when adding new type! Odd numbers are "bottom boot sector" types!

I don't think this is a bottom boot sector type.

It's a "all sectors are created equal" type ;)

...

+#define FLASH_28F256K3 0x00A8 /* Intel 28F256K3 ( 256M = 16M x 16 ) */

Already included now.

Please fix and resubmit if needed.

I'm a little bit confused; I understand these numbers as internal U-Boot identifiers, arent' they? The list has duplicate entries. And, according to what you said above, how is this meant:

#define FLASH_28F320J3A 0x007C /* INTEL 28F320J3A ( 32M = 128K x 32) */ #define FLASH_28F640J3A 0x007D /* INTEL 28F640J3A ( 64M = 128K x 64) */ #define FLASH_28F128J3A 0x007E /* INTEL 28F128J3A (128M = 128K x 128) */

These are equal sized as well but have ascending numbers. New patch is attached.

Robert