Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
On 06/25/2013 09:29:37 PM, Zhang Ying-B40530 wrote:
-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Friday, June 21, 2013 1:38 PM To: Zhang Ying-B40530 Cc: u-boot@lists.denx.de; Wood Scott-B07421; afleming@gmail.com; Xie Xiaobo-R63061; Zhang Ying-B40530 Subject: Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
Dear ying.zhang@freescale.com,
In message 1371715468-21120-6-git-send-email-ying.zhang@freescale.com you wrote:
The functionality env_import will be used in the SPL. They had been excluded by ifndef CONFIG_SPL_BUILD. Now, put it into the SPL.
Signed-off-by: Ying Zhang b40530@freescale.com
Compared with the original version, Changed as below:
- Split from "boot from SD card/SPI flash with SPL".
- Split from "spl: Make CONFIG_SPL_BUILD contain more
functionality"
- No change.
- No change.
common/env_common.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
This affects all boards, all architectures? How well has this been tested? [Zhang Ying] May I suggest we define a new symbol CONFIG_SPL_ENV_IMPORT to contain the functionality "env_import"? So, "#ifndef CONFIG_SPL_BUILD" will be changed to "#if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_ENV_IMPORT)"
Can we figure out if the ifdef is really needed first?
-Scott
On Wed, Jun 26, 2013 at 11:12:01AM -0500, Scott Wood wrote:
On 06/25/2013 09:29:37 PM, Zhang Ying-B40530 wrote:
-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Friday, June 21, 2013 1:38 PM To: Zhang Ying-B40530 Cc: u-boot@lists.denx.de; Wood Scott-B07421; afleming@gmail.com; Xie Xiaobo-R63061; Zhang Ying-B40530 Subject: Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
Dear ying.zhang@freescale.com,
In message 1371715468-21120-6-git-send-email-ying.zhang@freescale.com you wrote:
The functionality env_import will be used in the SPL. They had been excluded by ifndef CONFIG_SPL_BUILD. Now, put it into the SPL.
Signed-off-by: Ying Zhang b40530@freescale.com
Compared with the original version, Changed as below:
- Split from "boot from SD card/SPI flash with SPL".
- Split from "spl: Make CONFIG_SPL_BUILD contain more
functionality"
- No change.
- No change.
common/env_common.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
This affects all boards, all architectures? How well has this been tested? [Zhang Ying] May I suggest we define a new symbol CONFIG_SPL_ENV_IMPORT to contain the functionality "env_import"? So, "#ifndef CONFIG_SPL_BUILD" will be changed to "#if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_ENV_IMPORT)"
Can we figure out if the ifdef is really needed first?
Building for am335x_evm and am335x_evm_usbspl should tell you if it is, or is not. Whacking network support into SPL required more than --gc-sections alone could give us and we needed to drop a few couldn't-ever-reach calls and functionality out.
-----Original Message----- From: Tom Rini [mailto:tom.rini@gmail.com] On Behalf Of Tom Rini Sent: Thursday, June 27, 2013 1:35 AM To: Wood Scott-B07421 Cc: Zhang Ying-B40530; u-boot@lists.denx.de; afleming@gmail.com; Wood Scott-B07421 Subject: Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
On Wed, Jun 26, 2013 at 11:12:01AM -0500, Scott Wood wrote:
On 06/25/2013 09:29:37 PM, Zhang Ying-B40530 wrote:
-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Friday, June 21, 2013 1:38 PM To: Zhang Ying-B40530 Cc: u-boot@lists.denx.de; Wood Scott-B07421; afleming@gmail.com; Xie Xiaobo-R63061; Zhang Ying-B40530 Subject: Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
Dear ying.zhang@freescale.com,
In message 1371715468-21120-6-git-send-email-ying.zhang@freescale.com you wrote:
The functionality env_import will be used in the SPL. They had been excluded by ifndef CONFIG_SPL_BUILD. Now, put it into the SPL.
Signed-off-by: Ying Zhang b40530@freescale.com
Compared with the original version, Changed as below:
- Split from "boot from SD card/SPI flash with SPL".
- Split from "spl: Make CONFIG_SPL_BUILD contain more
functionality"
- No change.
- No change.
common/env_common.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
This affects all boards, all architectures? How well has this been tested? [Zhang Ying] May I suggest we define a new symbol CONFIG_SPL_ENV_IMPORT to contain the functionality "env_import"? So, "#ifndef CONFIG_SPL_BUILD" will be changed to "#if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_ENV_IMPORT)"
Can we figure out if the ifdef is really needed first?
Building for am335x_evm and am335x_evm_usbspl should tell you if it is, or is not. Whacking network support into SPL required more than --gc-sections alone could give us and we needed to drop a few couldn't-ever-reach calls and functionality out. [Zhang Ying] Yes, I tried to build for am335x_evm without this ifdef, no problem. Whether it can be removed?
On Thu, Jun 27, 2013 at 02:35:34AM +0000, Zhang Ying-B40530 wrote:
-----Original Message----- From: Tom Rini [mailto:tom.rini@gmail.com] On Behalf Of Tom Rini
[snip]
Building for am335x_evm and am335x_evm_usbspl should tell you if it is, or is not. Whacking network support into SPL required more than --gc-sections alone could give us and we needed to drop a few couldn't-ever-reach calls and functionality out. [Zhang Ying] Yes, I tried to build for am335x_evm without this ifdef, no problem. Whether it can be removed?
Did you also build am335x_evm_usbspl?
On 06/27/2013 07:17:48 AM, Tom Rini wrote:
On Thu, Jun 27, 2013 at 02:35:34AM +0000, Zhang Ying-B40530 wrote:
-----Original Message----- From: Tom Rini [mailto:tom.rini@gmail.com] On Behalf Of Tom Rini
[snip]
Building for am335x_evm and am335x_evm_usbspl should tell you if it
is,
or is not. Whacking network support into SPL required more than --gc-sections alone could give us and we needed to drop a few couldn't-ever-reach calls and functionality out. [Zhang Ying] Yes, I tried to build for am335x_evm without this ifdef, no problem. Whether it can be removed?
Did you also build am335x_evm_usbspl?
It builds OK for me with the ifdef removed. It adds 81 bytes to the SPL.
-Scott
On Thu, Jun 27, 2013 at 03:16:34PM -0500, Scott Wood wrote:
On 06/27/2013 07:17:48 AM, Tom Rini wrote:
On Thu, Jun 27, 2013 at 02:35:34AM +0000, Zhang Ying-B40530 wrote:
-----Original Message----- From: Tom Rini [mailto:tom.rini@gmail.com] On Behalf Of Tom Rini
[snip]
Building for am335x_evm and am335x_evm_usbspl should tell you if
it is,
or is not. Whacking network support into SPL required more than --gc-sections alone could give us and we needed to drop a few couldn't-ever-reach calls and functionality out. [Zhang Ying] Yes, I tried to build for am335x_evm without this ifdef, no problem. Whether it can be removed?
Did you also build am335x_evm_usbspl?
It builds OK for me with the ifdef removed. It adds 81 bytes to the SPL.
I think we can live with that.
Acked-by: Tom Rini trini@ti.com
Excuse me, this patch has not been merged? Thanks.
-----Original Message----- From: Tom Rini [mailto:tom.rini@gmail.com] On Behalf Of Tom Rini Sent: Friday, June 28, 2013 5:57 AM To: Wood Scott-B07421 Cc: u-boot@lists.denx.de; Wood Scott-B07421; afleming@gmail.com; Zhang Ying-B40530 Subject: Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
On Thu, Jun 27, 2013 at 03:16:34PM -0500, Scott Wood wrote:
On 06/27/2013 07:17:48 AM, Tom Rini wrote:
On Thu, Jun 27, 2013 at 02:35:34AM +0000, Zhang Ying-B40530 wrote:
-----Original Message----- From: Tom Rini [mailto:tom.rini@gmail.com] On Behalf Of Tom Rini
[snip]
Building for am335x_evm and am335x_evm_usbspl should tell you if
it is,
or is not. Whacking network support into SPL required more than --gc-sections alone could give us and we needed to drop a few couldn't-ever-reach calls and functionality out. [Zhang Ying] Yes, I tried to build for am335x_evm without this ifdef, no problem. Whether it can be removed?
Did you also build am335x_evm_usbspl?
It builds OK for me with the ifdef removed. It adds 81 bytes to the SPL.
I think we can live with that.
Acked-by: Tom Rini trini@ti.com
-- Tom
Hi, Tom, This patch hasn't been applied? I think it should be applied early and it is needed by other patches of this set. Thanks.
-----Original Message----- From: Tom Rini [mailto:tom.rini@gmail.com] On Behalf Of Tom Rini Sent: Friday, June 28, 2013 5:57 AM To: Wood Scott-B07421 Cc: u-boot@lists.denx.de; Wood Scott-B07421; afleming@gmail.com; Zhang Ying-B40530 Subject: Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
On Thu, Jun 27, 2013 at 03:16:34PM -0500, Scott Wood wrote:
On 06/27/2013 07:17:48 AM, Tom Rini wrote:
On Thu, Jun 27, 2013 at 02:35:34AM +0000, Zhang Ying-B40530 wrote:
-----Original Message----- From: Tom Rini [mailto:tom.rini@gmail.com] On Behalf Of Tom Rini
[snip]
Building for am335x_evm and am335x_evm_usbspl should tell you if
it is,
or is not. Whacking network support into SPL required more than --gc-sections alone could give us and we needed to drop a few couldn't-ever-reach calls and functionality out. [Zhang Ying] Yes, I tried to build for am335x_evm without this ifdef, no problem. Whether it can be removed?
Did you also build am335x_evm_usbspl?
It builds OK for me with the ifdef removed. It adds 81 bytes to the SPL.
I think we can live with that.
Acked-by: Tom Rini trini@ti.com
-- Tom
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 08/13/2013 10:31 PM, Zhang Ying-B40530 wrote:
Hi, Tom, This patch hasn't been applied? I think it should be applied early and it is needed by other patches of this set. Thanks.
I expect that as part of the overall series, once ready, York will take this and include it in his pull request, which is why I've given it my acked-by.
-----Original Message----- From: Tom Rini [mailto:tom.rini@gmail.com] On Behalf Of Tom Rini Sent: Friday, June 28, 2013 5:57 AM To: Wood Scott-B07421 Cc: u-boot@lists.denx.de; Wood Scott-B07421; afleming@gmail.com; Zhang Ying-B40530 Subject: Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
On Thu, Jun 27, 2013 at 03:16:34PM -0500, Scott Wood wrote:
On 06/27/2013 07:17:48 AM, Tom Rini wrote:
On Thu, Jun 27, 2013 at 02:35:34AM +0000, Zhang Ying-B40530 wrote:
-----Original Message----- From: Tom Rini [mailto:tom.rini@gmail.com] On Behalf Of Tom Rini
[snip]
Building for am335x_evm and am335x_evm_usbspl should tell you if
it is,
or is not. Whacking network support into SPL required more than --gc-sections alone could give us and we needed to drop a few couldn't-ever-reach calls and functionality out. [Zhang Ying] Yes, I tried to build for am335x_evm without this ifdef, no problem. Whether it can be removed?
Did you also build am335x_evm_usbspl?
It builds OK for me with the ifdef removed. It adds 81 bytes to the SPL.
I think we can live with that.
Acked-by: Tom Rini trini@ti.com
-- Tom
- -- Tom
On 08/14/2013 06:48 AM, Tom Rini wrote:
On 08/13/2013 10:31 PM, Zhang Ying-B40530 wrote:
Hi, Tom, This patch hasn't been applied? I think it should be applied early and it is needed by other patches of this set. Thanks.
I expect that as part of the overall series, once ready, York will take this and include it in his pull request, which is why I've given it my acked-by.
Ying,
This patch fell through the crack. I didn't see it because it was marked as "superseded". Please check your other patches. You can delegate them to me.
York
York, I had checked all the patch and I am sure there is only this patch almost forgotten. I don't know how to do. Need I send the patch again or other way? Thanks.
-----Original Message----- From: sun york-R58495 Sent: Wednesday, August 14, 2013 11:42 PM To: Zhang Ying-B40530 Cc: Tom Rini; Wood Scott-B07421; u-boot@lists.denx.de; afleming@gmail.com Subject: Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
On 08/14/2013 06:48 AM, Tom Rini wrote:
On 08/13/2013 10:31 PM, Zhang Ying-B40530 wrote:
Hi, Tom, This patch hasn't been applied? I think it should be applied early and it is needed by other patches of this set. Thanks.
I expect that as part of the overall series, once ready, York will take this and include it in his pull request, which is why I've given it my acked-by.
Ying,
This patch fell through the crack. I didn't see it because it was marked as "superseded". Please check your other patches. You can delegate them to me.
York
On Aug 14, 2013, at 7:25 PM, Zhang Ying-B40530 wrote:
York, I had checked all the patch and I am sure there is only this patch almost forgotten. I don't know how to do. Need I send the patch again or other way? Thanks.
No need to resend. I can mark it. Just want to be sure there isn't a newer version hiding somewhere.
York
Hi, York, I see. I am sure there isn't newer version.
-----Original Message----- From: sun york-R58495 Sent: Thursday, August 15, 2013 10:42 AM To: Zhang Ying-B40530 Cc: Tom Rini; Wood Scott-B07421; u-boot@lists.denx.de; Andy Fleming; Xie Xiaobo-R63061 Subject: Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
On Aug 14, 2013, at 7:25 PM, Zhang Ying-B40530 wrote:
York, I had checked all the patch and I am sure there is only this patch almost forgotten. I don't know how to do. Need I send the patch again or other way? Thanks.
No need to resend. I can mark it. Just want to be sure there isn't a newer version hiding somewhere.
York
participants (5)
-
Scott Wood -
sun york-R58495 -
Tom Rini -
York Sun -
Zhang Ying-B40530