[U-Boot] PATCH 0/8 Multi-adapter multi-bus I2C
This is the first attempt of multi-adapter multi-bus I2C subsystem rework for U-Boot.
This batch deals with fsl_i2c and soft_i2c drivers. All (hopefully :) relevant parts are changed -- config files for all boards affected, lib_xxx, board/* etc.
Please see illustrative section of MPC8548CDS.h config file for an example for 2 soft_i2c, 2 fsl_i2c, 1 sm502_i2c adapters and 7 busses some of them connected via I2C multiplexers.
All comments, suggestions etc. are very welcome.
I'm going to move _ALL_ I2C drivers to drivers/i2c and rework all the configs and other relevant stuff in next batches. Then I will do another run to completely remove CONFIG_NEW_I2C and get rid of CONFIG_HARD_I2C.
The patches are in next 8 emails.
Signed-off-by: Sergey Kubushyn ksi@koi8.net
--- ****************************************************************** * KSI@home KOI8 Net < > The impossible we do immediately. * * Las Vegas NV, USA < > Miracles require 24-hour notice. * ******************************************************************
Hello ksi,
ksi@koi8.net wrote:
This is the first attempt of multi-adapter multi-bus I2C subsystem rework for U-Boot.
This batch deals with fsl_i2c and soft_i2c drivers. All (hopefully :)
relevant parts are changed -- config files for all boards affected, lib_xxx, board/* etc.
Please see illustrative section of MPC8548CDS.h config file for an example for 2 soft_i2c, 2 fsl_i2c, 1 sm502_i2c adapters and 7 busses some of them connected via I2C multiplexers.
All comments, suggestions etc. are very welcome.
Common comments: - you mixed Coding Style cleanup with functional changes in one patch, please don't do this - I also think, we should have a u-boot-i2c.git or something like that for this big change. So your patches go first in u-boot-i2c.git, and everybody can try out your changes. And if all goes OK, then it is ready for mainline. What Do others think?
I'm going to move _ALL_ I2C drivers to drivers/i2c and rework all the configs and other relevant stuff in next batches. Then I will do another run to completely remove CONFIG_NEW_I2C and get rid of CONFIG_HARD_I2C.
The patches are in next 8 emails.
It looks like to me, that this "8 patches" is only one big patch, that you just splitted in 8 EMails, don't do this. Please try to make real n patches from this big one (for example, the changes in fsl_i2c.c in one extra patch).
Signed-off-by: Sergey Kubushyn ksi@koi8.net
Why here a Signed-off-by? For what?
bye Heiko
On Mon, 9 Feb 2009, Heiko Schocher wrote:
Hello ksi,
ksi@koi8.net wrote:
This is the first attempt of multi-adapter multi-bus I2C subsystem rework for U-Boot.
This batch deals with fsl_i2c and soft_i2c drivers. All (hopefully :)
relevant parts are changed -- config files for all boards affected, lib_xxx, board/* etc.
Please see illustrative section of MPC8548CDS.h config file for an example for 2 soft_i2c, 2 fsl_i2c, 1 sm502_i2c adapters and 7 busses some of them connected via I2C multiplexers.
All comments, suggestions etc. are very welcome.
Common comments:
- you mixed Coding Style cleanup with functional changes in one patch,
please don't do this
I didn't try to make a cleanup, that's just a side effect :) Simply could not resist...
- I also think, we should have a u-boot-i2c.git or something like that for this big change. So your patches go first in u-boot-i2c.git, and everybody can try out your changes. And if all goes OK, then it is ready for mainline. What Do others think?
I'm going to move _ALL_ I2C drivers to drivers/i2c and rework all the configs and other relevant stuff in next batches. Then I will do another run to completely remove CONFIG_NEW_I2C and get rid of CONFIG_HARD_I2C.
The patches are in next 8 emails.
It looks like to me, that this "8 patches" is only one big patch, that you just splitted in 8 EMails, don't do this. Please try to make real n patches from this big one (for example, the changes in fsl_i2c.c in one extra patch).
OK.
--- ****************************************************************** * KSI@home KOI8 Net < > The impossible we do immediately. * * Las Vegas NV, USA < > Miracles require 24-hour notice. * ******************************************************************
Dear Heiko,
In message 49901379.2050809@denx.de you wrote:
- I also think, we should have a u-boot-i2c.git or something like that for this big change. So your patches go first in u-boot-i2c.git, and everybody can try out your changes. And if all goes OK, then it is ready for mainline. What Do others think?
That's an excellent idea.
Would you like to volunteer as I2C custodian?
Best regards,
Wolfgang Denk
Hello Wolfgang,
Wolfgang Denk wrote:
In message 49901379.2050809@denx.de you wrote:
- I also think, we should have a u-boot-i2c.git or something like that for this big change. So your patches go first in u-boot-i2c.git, and everybody can try out your changes. And if all goes OK, then it is ready for mainline. What Do others think?
That's an excellent idea.
Would you like to volunteer as I2C custodian?
Ok, I will try it.
bye heiko
On Tue, 10 Feb 2009, Heiko Schocher wrote:
Hello Wolfgang,
Wolfgang Denk wrote:
In message 49901379.2050809@denx.de you wrote:
- I also think, we should have a u-boot-i2c.git or something like that for this big change. So your patches go first in u-boot-i2c.git, and everybody can try out your changes. And if all goes OK, then it is ready for mainline. What Do others think?
That's an excellent idea.
Would you like to volunteer as I2C custodian?
Ok, I will try it.
That's fine. Please let me know when it is setup and how can I push my patches in it.
--- ****************************************************************** * KSI@home KOI8 Net < > The impossible we do immediately. * * Las Vegas NV, USA < > Miracles require 24-hour notice. * ******************************************************************
Hello ksi,
ksi@koi8.net wrote:
On Tue, 10 Feb 2009, Heiko Schocher wrote:
Hello Wolfgang,
Wolfgang Denk wrote:
In message 49901379.2050809@denx.de you wrote:
- I also think, we should have a u-boot-i2c.git or something like that for this big change. So your patches go first in u-boot-i2c.git, and everybody can try out your changes. And if all goes OK, then it is ready for mainline. What Do others think?
That's an excellent idea.
Would you like to volunteer as I2C custodian?
Ok, I will try it.
That's fine. Please let me know when it is setup and how can I push my patches in it.
I think, I do this for you. You post your patches here on the mailinglist, as usual, and all who are interested can discuss them. If we are at a point, we think they are OK, I will add them to the u-boot-i2c.git (I would like to make there a "multibus-test" branch). If your patches in there, everybody can try this new feature. After sometime nobody screams, they are then going in the "master" branch for inclusion to mainline ... so I think is the procedure.
bye heiko
On Tue, 10 Feb 2009, Heiko Schocher wrote:
Hello ksi,
ksi@koi8.net wrote:
On Tue, 10 Feb 2009, Heiko Schocher wrote:
Hello Wolfgang,
Wolfgang Denk wrote:
In message 49901379.2050809@denx.de you wrote:
- I also think, we should have a u-boot-i2c.git or something like that for this big change. So your patches go first in u-boot-i2c.git, and everybody can try out your changes. And if all goes OK, then it is ready for mainline. What Do others think?
That's an excellent idea.
Would you like to volunteer as I2C custodian?
Ok, I will try it.
That's fine. Please let me know when it is setup and how can I push my patches in it.
I think, I do this for you. You post your patches here on the mailinglist, as usual, and all who are interested can discuss them. If we are at a point, we think they are OK, I will add them to the u-boot-i2c.git (I would like to make there a "multibus-test" branch). If your patches in there, everybody can try this new feature. After sometime nobody screams, they are then going in the "master" branch for inclusion to mainline ... so I think is the procedure.
OK, thanks.
--- ****************************************************************** * KSI@home KOI8 Net < > The impossible we do immediately. * * Las Vegas NV, USA < > Miracles require 24-hour notice. * ******************************************************************
Dear ksi@koi8.net,
In message Pine.LNX.4.64ksi.0902100900510.6871@home-gw.koi8.net you wrote:
Would you like to volunteer as I2C custodian?
Ok, I will try it.
That's fine. Please let me know when it is setup and how can I push my patches in it.
You cannot. Heiko is the custodian, and he alone can push. Please submit your patches on this list as before.
Best regards,
Wolfgang Denk
On Tue, 10 Feb 2009, Wolfgang Denk wrote:
Dear ksi@koi8.net,
In message Pine.LNX.4.64ksi.0902100900510.6871@home-gw.koi8.net you wrote:
Would you like to volunteer as I2C custodian?
Ok, I will try it.
That's fine. Please let me know when it is setup and how can I push my patches in it.
You cannot. Heiko is the custodian, and he alone can push. Please submit your patches on this list as before.
OK, no problems. I did not mean "push" as in "git push", I meant it as a mechanism to somehow make them into that new repository.
--- ****************************************************************** * KSI@home KOI8 Net < > The impossible we do immediately. * * Las Vegas NV, USA < > Miracles require 24-hour notice. * ******************************************************************
Dear Heiko Schocher,
In message 49913FF3.3080000@denx.de you wrote:
Would you like to volunteer as I2C custodian?
Ok, I will try it.
Thanks a lot!
Best regards,
Wolfgang Denk
participants (3)
-
Heiko Schocher -
ksi＠koi8.net -
Wolfgang Denk