[PATCH] Makefile: Fake external blob with BINMAN_ALLOW_MISSING=1

This flag was lost by a previous change and has never been restored. Without it, binman cannot fully handle missing blobs which are themselves inputs to mkimage.
Discussion on this at [1] indicated that this was necessary but the patch was not updated.
Restore the flag so that all missing blobs are reported.
[1] https://patchwork.ozlabs.org/project/uboot/patch/ 20221206020336.315465-1-trini@konsulko.com/
Signed-off-by: Simon Glass sjg@chromium.org Fixes: 93685d0dcb9 ("Makefile: With BINMAN_ALLOW_MISSING=1 don't error") ---
Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile index 7275a02f24c..f92f46b3ab7 100644 --- a/Makefile +++ b/Makefile @@ -1398,7 +1398,8 @@ cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \ --toolpath $(objtree)/tools \ $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \ build -u -d u-boot.dtb -O . -m \ - --allow-missing $(if $(BINMAN_ALLOW_MISSING),--ignore-missing) \ + --allow-missing --fake-ext-blobs \ + $(if $(BINMAN_ALLOW_MISSING),--ignore-missing) \ -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \ $(foreach f,$(of_list_dirs),-I $(f)) -a of-list=$(of_list) \ $(foreach f,$(BINMAN_INDIRS),-I $(f)) \

On Mon, Nov 04, 2024 at 06:44:24AM -0700, Simon Glass wrote:
This flag was lost by a previous change and has never been restored. Without it, binman cannot fully handle missing blobs which are themselves inputs to mkimage.
Discussion on this at [1] indicated that this was necessary but the patch was not updated.
Restore the flag so that all missing blobs are reported.
[1] https://patchwork.ozlabs.org/project/uboot/patch/ 20221206020336.315465-1-trini@konsulko.com/
Please reword this to use Link: and not line-break the link (thus breaking the link), thanks.
participants (2)
-
Simon Glass
-
Tom Rini