[PATCH] cmd: bcb: Fix bcb compilation when CONFIG_CMD_BCB=n
commit dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields") introduced the bcb_get() function.
When CONFIG_CMD_BCB=n, that function is stubbed. The stubbed function has a wrong prototype: value_size arg is missing.
Add the missing argument to fix build when CONFIG_CMD_BCB=n.
Fixes: dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields") Signed-off-by: Mattijs Korpershoek mkorpershoek@baylibre.com --- include/bcb.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/bcb.h b/include/bcb.h index 1941d8c28b4f..a56b547595a6 100644 --- a/include/bcb.h +++ b/include/bcb.h @@ -58,7 +58,8 @@ static inline int bcb_set(enum bcb_field field, const char *value) return -EOPNOTSUPP; }
-static inline int bcb_get(enum bcb_field field, char *value_out) +static inline int bcb_get(enum bcb_field field, + char *value_out, size_t value_size) { return -EOPNOTSUPP; }
--- base-commit: ea722aa5eb33740ae77e8816aeb72b385e621cd0 change-id: 20240603-bcb-compil-d8eaf7074475
Best regards,
hi,
Le 03/06/2024 à 11:04, Mattijs Korpershoek a écrit :
commit dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields") introduced the bcb_get() function.
When CONFIG_CMD_BCB=n, that function is stubbed. The stubbed function has a wrong prototype: value_size arg is missing.
Add the missing argument to fix build when CONFIG_CMD_BCB=n.
Fixes: dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields") Signed-off-by: Mattijs Korpershoek mkorpershoek@baylibre.com
include/bcb.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/bcb.h b/include/bcb.h index 1941d8c28b4f..a56b547595a6 100644 --- a/include/bcb.h +++ b/include/bcb.h @@ -58,7 +58,8 @@ static inline int bcb_set(enum bcb_field field, const char *value) return -EOPNOTSUPP; }
-static inline int bcb_get(enum bcb_field field, char *value_out) +static inline int bcb_get(enum bcb_field field,
char *value_out, size_t value_size)
base-commit: ea722aa5eb33740ae77e8816aeb72b385e621cd0 change-id: 20240603-bcb-compil-d8eaf7074475
Best regards,
Reviewed-by: Guillaume La Roqueglaroque@baylibre.com
Regards Guillaume
Thank you and sorry for missing that
Reviewed-by: Dmitrii Merkurev dimorinny@google.com
On Mon 10 Jun 2024 at 11:45, Mattijs Korpershoek mkorpershoek@baylibre.com wrote:
commit dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields") introduced the bcb_get() function.
When CONFIG_CMD_BCB=n, that function is stubbed. The stubbed function has a wrong prototype: value_size arg is missing.
Add the missing argument to fix build when CONFIG_CMD_BCB=n.
Fixes: dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields") Signed-off-by: Mattijs Korpershoek mkorpershoek@baylibre.com
include/bcb.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/bcb.h b/include/bcb.h index 1941d8c28b4f..a56b547595a6 100644 --- a/include/bcb.h +++ b/include/bcb.h @@ -58,7 +58,8 @@ static inline int bcb_set(enum bcb_field field, const char *value) return -EOPNOTSUPP; }
-static inline int bcb_get(enum bcb_field field, char *value_out) +static inline int bcb_get(enum bcb_field field,
char *value_out, size_t value_size){ return -EOPNOTSUPP; }
base-commit: ea722aa5eb33740ae77e8816aeb72b385e621cd0 change-id: 20240603-bcb-compil-d8eaf7074475
Best regards,
Mattijs Korpershoek mkorpershoek@baylibre.com
Reviewed-by: Julien Masson jmasson@baylibre.com
On Mon, 03 Jun 2024 11:04:58 +0200, Mattijs Korpershoek wrote:
commit dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields") introduced the bcb_get() function.
When CONFIG_CMD_BCB=n, that function is stubbed. The stubbed function has a wrong prototype: value_size arg is missing.
Add the missing argument to fix build when CONFIG_CMD_BCB=n.
[...]
Applied to u-boot/master, thanks!
participants (5)
-
Dmitrii Merkurev -
Guillaume LA ROQUE -
Julien Masson -
Mattijs Korpershoek -
Tom Rini