[PATCH] cmd: efidebug: Add missing \n at the end of message
Currently message is not intended that prompt end up at the end of debug line. For example like this:
DFU alt info setting: done DFU entities configuration failed! (partition table does not match dfu_alt_info?) Firmware update failed: <NULL> Cannot handle a capsule at 10000000Zynq>
Signed-off-by: Michal Simek michal.simek@amd.com ---
cmd/efidebug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/efidebug.c b/cmd/efidebug.c index df928ce71dcf..84e6ff556508 100644 --- a/cmd/efidebug.c +++ b/cmd/efidebug.c @@ -77,7 +77,7 @@ static int do_efi_capsule_update(struct cmd_tbl *cmdtp, int flag,
ret = EFI_CALL(RT->update_capsule(&capsule, 1, 0)); if (ret) { - printf("Cannot handle a capsule at %p", capsule); + printf("Cannot handle a capsule at %p\n", capsule); return CMD_RET_FAILURE; }
On 8/9/22 16:31, Michal Simek wrote:
Currently message is not intended that prompt end up at the end of debug line. For example like this:
DFU alt info setting: done DFU entities configuration failed! (partition table does not match dfu_alt_info?) Firmware update failed: <NULL> Cannot handle a capsule at 10000000Zynq>
Signed-off-by: Michal Simek michal.simek@amd.com
Reviewed-by: Heinrich Schuchardt xypron.glpk@gmx.de
cmd/efidebug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/efidebug.c b/cmd/efidebug.c index df928ce71dcf..84e6ff556508 100644 --- a/cmd/efidebug.c +++ b/cmd/efidebug.c @@ -77,7 +77,7 @@ static int do_efi_capsule_update(struct cmd_tbl *cmdtp, int flag,
ret = EFI_CALL(RT->update_capsule(&capsule, 1, 0)); if (ret) {
printf("Cannot handle a capsule at %p", capsule);
printf("Cannot handle a capsule at %p\n", capsule);
On Wed, 10 Aug 2022 at 08:28, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 8/9/22 16:31, Michal Simek wrote:
Currently message is not intended that prompt end up at the end of debug line. For example like this:
DFU alt info setting: done DFU entities configuration failed! (partition table does not match dfu_alt_info?) Firmware update failed: <NULL> Cannot handle a capsule at 10000000Zynq>
Signed-off-by: Michal Simek michal.simek@amd.com
Reviewed-by: Heinrich Schuchardt xypron.glpk@gmx.de
Reviewed-by: Ilias Apalodimas ilias.apalodimas@linaro.org
cmd/efidebug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/efidebug.c b/cmd/efidebug.c index df928ce71dcf..84e6ff556508 100644 --- a/cmd/efidebug.c +++ b/cmd/efidebug.c @@ -77,7 +77,7 @@ static int do_efi_capsule_update(struct cmd_tbl *cmdtp, int flag,
ret = EFI_CALL(RT->update_capsule(&capsule, 1, 0)); if (ret) {
printf("Cannot handle a capsule at %p", capsule);
printf("Cannot handle a capsule at %p\n", capsule); return CMD_RET_FAILURE; }
participants (3)
-
Heinrich Schuchardt -
Ilias Apalodimas -
Michal Simek