[U-Boot] [PATCH] arm: Tidy up of PRAM init to use getenv_f()
It seems that few people use CONFIG_PRAM on ARM. The getenv_r() function has been renamed to getenv_f().
Signed-off-by: Simon Glass sjg@chromium.org --- arch/arm/lib/board.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index 1fe3751..653345f 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -317,7 +317,7 @@ void board_init_f(ulong bootflag) /* * reserve protected RAM */ - i = getenv_r("pram", (char *)tmp, sizeof(tmp)); + i = getenv_f("pram", (char *)tmp, sizeof(tmp)); reg = (i > 0) ? simple_strtoul((const char *)tmp, NULL, 10) : CONFIG_PRAM; addr -= (reg << 10); /* size is in kB */
Hi Simon,
Le 10/10/2011 22:24, Simon Glass a écrit :
It seems that few people use CONFIG_PRAM on ARM. The getenv_r() function has been renamed to getenv_f().
Please correct the commit message: it does not rename the function, it switches from callong the _r version to calling the _f version.
Signed-off-by: Simon Glasssjg@chromium.org
arch/arm/lib/board.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index 1fe3751..653345f 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -317,7 +317,7 @@ void board_init_f(ulong bootflag) /* * reserve protected RAM */
- i = getenv_r("pram", (char *)tmp, sizeof(tmp));
- i = getenv_f("pram", (char *)tmp, sizeof(tmp)); reg = (i> 0) ? simple_strtoul((const char *)tmp, NULL, 10) : CONFIG_PRAM; addr -= (reg<< 10); /* size is in kB */
Amicalement,
Hi Albert,
On Mon, Dec 19, 2011 at 2:09 AM, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi Simon,
Le 10/10/2011 22:24, Simon Glass a écrit :
It seems that few people use CONFIG_PRAM on ARM. The getenv_r() function has been renamed to getenv_f().
Please correct the commit message: it does not rename the function, it switches from callong the _r version to calling the _f version.
Please drop this patch, as it still doesn't allow PRAM to actually work on ARM.
Regards, Simon
Signed-off-by: Simon Glasssjg@chromium.org
arch/arm/lib/board.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index 1fe3751..653345f 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -317,7 +317,7 @@ void board_init_f(ulong bootflag) /* * reserve protected RAM */
- i = getenv_r("pram", (char *)tmp, sizeof(tmp));
- i = getenv_f("pram", (char *)tmp, sizeof(tmp));
reg = (i> 0) ? simple_strtoul((const char *)tmp, NULL, 10) : CONFIG_PRAM; addr -= (reg<< 10); /* size is in kB */
Amicalement,
Albert.
participants (2)
-
Albert ARIBAUD -
Simon Glass