[U-Boot] [RFC][PATCH 08/19] i2c: fix command usage help
Signed-off-by: Heiko Schocher hs@denx.de --- common/cmd_i2c.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c index a1a84a1..91e60ae 100644 --- a/common/cmd_i2c.c +++ b/common/cmd_i2c.c @@ -1297,6 +1297,11 @@ static int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]) { cmd_tbl_t *c;
+ if (argc < 2) { + cmd_usage(cmdtp); + return 1; + } + /* Strip off leading 'i2c' command argument */ argc--; argv++;
Hello Peter,
Peter Tyser wrote:
{ cmd_tbl_t *c;
- if (argc < 2) {
cmd_usage(cmdtp);return 1;- }
Wolfgang recently made cmd_usage() return 1 so the above could be simplified to: if (argc < 2) return cmd_usage(cmdtp);
Hups, missed this, sorry. I fix it in the next version. thanks.
bye Heiko
Signed-off-by: Heiko Schocher hs@denx.de --- - changes since v1 added comment from Peter Tyser - simplified this patch as cmd_usage() returns 1
common/cmd_i2c.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c index a1a84a1..48de54b 100644 --- a/common/cmd_i2c.c +++ b/common/cmd_i2c.c @@ -1297,6 +1297,9 @@ static int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]) { cmd_tbl_t *c;
+ if (argc < 2) + return cmd_usage(cmdtp); + /* Strip off leading 'i2c' command argument */ argc--; argv++;
participants (2)
-
Heiko Schocher -
Peter Tyser