[U-Boot-Users] GCC3.4.0 and board file fixes for Versatile/Integrator

newer
RE: [U-Boot-Users] GCC3.4.0 and...

older
[U-Boot-Users] patch board.c in arm

Philippe Robin

1 Jul 2004 1 Jul '04

5:02 p.m.

Greetings,

I added the following changes when compiling u-boot with gcc3.4.0 (see attached patch):

CHANGELOG Entry: * Patch by Philippe Robin, 1 Jul 2004: - fixed deprecated -mshort-load-bytes option with GCC 3.4.0 to -malignment-traps. - Added return statement at the end of smc_phy_configure() in smc91111.c. - Added initialisation for Integrator and versatile board files.

Regards Philippe -------------- Philippe Robin ARM Ltd.

Attachments:

u-boot-gcc340.diff (application/octet-stream — 3.5 KB)

Show replies by date

Wolfgang Denk

1 Jul 1 Jul

5:23 p.m.

In message 89A528FE6DB0FA44877BB2F05B846718896E5B@ZIPPY.Emea.Arm.com you wrote:

...

I added the following changes when compiling u-boot with gcc3.4.0 (see attached patch):

CHANGELOG Entry:

Patch by Philippe Robin, 1 Jul 2004:

fixed deprecated -mshort-load-bytes option with GCC 3.4.0 to -malignment-traps.

I think this is OK, but can you guarantee that this change will work with older versions of the compiler, like 2.95.3 or 2.95.4 ?

Best regards,

Wolfgang Denk

-- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd@denx.de "This isn't brain surgery; it's just television." - David Letterman

Robert Schwebel

5:40 p.m.

On Thu, Jul 01, 2004 at 05:23:32PM +0200, Wolfgang Denk wrote:

...

I think this is OK, but can you guarantee that this change will work with older versions of the compiler, like 2.95.3 or 2.95.4 ?

I don't think it will - but on the other hand the old options won't work with the new compilers any more. At some point we have to decide which compiler versions are supported by default, or we have to setup a sophisticated "options vs. compiler versions" magic.

Robert

-- Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry Handelsregister: Amtsgericht Hildesheim, HRA 2686 Hornemannstraße 12, 31137 Hildesheim, Germany Phone: +49-5121-28619-0 | Fax: +49-5121-28619-4

Wolfgang Denk

11 Jul 11 Jul

8:05 p.m.

In message 89A528FE6DB0FA44877BB2F05B846718896E5B@ZIPPY.Emea.Arm.com you wrote:

...

I added the following changes when compiling u-boot with gcc3.4.0 (see attached patch):

CHANGELOG Entry:

Patch by Philippe Robin, 1 Jul 2004:

fixed deprecated -mshort-load-bytes option with GCC 3.4.0 to -malignment-traps.

Added return statement at the end of smc_phy_configure() in smc91111.c.

Added initialisation for Integrator and versatile board files.

I added only the initialization part of the patches. I reject the other two for the following reasons:

1) Hard-coding "-malignment-traps" breaks compiling for all older compilers. I understand why you;re doing this, but please do it in a way that is compatible with older compilers as well.

Please fix and resubmit.

2) smc91111.c has been fixed before (differently).

It would have been better to submit this not in a single patch. Please note that the README explicitely requests: "A patch containing several unrelated changes ... will be returned with a request to ... split it."

Best regards,

Wolfgang Denk

-- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd@denx.de If the hours are long enough and the pay is short enough, someone will say it's women's work.

7607

Age (days ago)

7617

Last active (days ago)

List overview

Download

3 comments

3 participants

tags (0)

participants (3)

Philippe Robin
Robert Schwebel
Wolfgang Denk