[U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
Signed-off-by: Albert Aribaud albert.aribaud@free.fr --- Orion5x MPP and GPIO setting code had writel arguments the wrong way around. Fixed and tested.
arch/arm/cpu/arm926ejs/orion5x/cpu.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/orion5x/cpu.c b/arch/arm/cpu/arm926ejs/orion5x/cpu.c index c2f5253..03c6d06 100644 --- a/arch/arm/cpu/arm926ejs/orion5x/cpu.c +++ b/arch/arm/cpu/arm926ejs/orion5x/cpu.c @@ -260,10 +260,10 @@ int arch_misc_init(void)
/* Set CPIOs and MPPs - values provided by board include file */ - writel(ORION5X_MPP_BASE+0x00, ORION5X_MPP0_7); - writel(ORION5X_MPP_BASE+0x04, ORION5X_MPP8_15); - writel(ORION5X_MPP_BASE+0x50, ORION5X_MPP16_23); - writel(ORION5X_GPIO_BASE+0x04, ORION5X_GPIO_OUT_ENABLE); + writel(ORION5X_MPP0_7, ORION5X_MPP_BASE+0x00); + writel(ORION5X_MPP8_15, ORION5X_MPP_BASE+0x04); + writel(ORION5X_MPP16_23, ORION5X_MPP_BASE+0x50); + writel(ORION5X_GPIO_OUT_ENABLE, ORION5X_GPIO_BASE+0x04);
return 0; }
-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Albert Aribaud Sent: Tuesday, June 22, 2010 2:17 AM To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
Signed-off-by: Albert Aribaud albert.aribaud@free.fr
Orion5x MPP and GPIO setting code had writel arguments the wrong way around. Fixed and tested.
arch/arm/cpu/arm926ejs/orion5x/cpu.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/orion5x/cpu.c b/arch/arm/cpu/arm926ejs/orion5x/cpu.c index c2f5253..03c6d06 100644 --- a/arch/arm/cpu/arm926ejs/orion5x/cpu.c +++ b/arch/arm/cpu/arm926ejs/orion5x/cpu.c @@ -260,10 +260,10 @@ int arch_misc_init(void)
/* Set CPIOs and MPPs - values provided by board include file */
- writel(ORION5X_MPP_BASE+0x00, ORION5X_MPP0_7);
- writel(ORION5X_MPP_BASE+0x04, ORION5X_MPP8_15);
- writel(ORION5X_MPP_BASE+0x50, ORION5X_MPP16_23);
- writel(ORION5X_GPIO_BASE+0x04, ORION5X_GPIO_OUT_ENABLE);
- writel(ORION5X_MPP0_7, ORION5X_MPP_BASE+0x00);
- writel(ORION5X_MPP8_15, ORION5X_MPP_BASE+0x04);
- writel(ORION5X_MPP16_23, ORION5X_MPP_BASE+0x50);
- writel(ORION5X_GPIO_OUT_ENABLE, ORION5X_GPIO_BASE+0x04);
This means, earlier patches you posted were not tested properly. Its great trust on the developers that whatever they submit (even smallest change) is tested. Submitting untested/unused code is strongly discouraged...
I hope everyone agrees with me.
Regards.. Prafulla . .
-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Prafulla Wadaskar Sent: Tuesday, June 22, 2010 11:51 AM To: Albert Aribaud; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Albert Aribaud Sent: Tuesday, June 22, 2010 2:17 AM To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
Signed-off-by: Albert Aribaud albert.aribaud@free.fr
Orion5x MPP and GPIO setting code had writel arguments the wrong way around. Fixed and tested.
Hi Wolfgang
The same is available at http://git.denx.de/?p=u-boot/u-boot-marvell.git;a=commit;h=df33d8b1e1be61113...
Please kindly pull it from u-boot-marvell.git master branch, I have modified original patch little bit for patch comments
Regards.. Prafulla . . .
Dear Prafulla Wadaskar,
In message F766E4F80769BD478052FB6533FA745D19A4985705@SC-VEXCH4.marvell.com you wrote:
The same is available at http://git.denx.de/?p=3Du-boot/u-boot-marvell.git;a=3Dcommit;h=3Ddf33d8b1e1= be6111366a3fd51751c9419fc2df5a
Please kindly pull it from u-boot-marvell.git master branch, I have modifie= d original patch little bit for patch comments
I'm not sure if htis was a pull request - in case it was, please resend it as such.
So far, I just cherry-picked this single commit.
Applied, thanks.
Best regards,
Wolfgang Denk
Le 22/06/2010 08:20, Prafulla Wadaskar a écrit :
This means, earlier patches you posted were not tested properly. Its great trust on the developers that whatever they submit (even smallest change) is tested. Submitting untested/unused code is strongly discouraged...
I hope everyone agrees with me.
I agree and do apologize.
Amicalement,
-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Albert Aribaud Sent: Tuesday, June 22, 2010 2:17 AM To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
Signed-off-by: Albert Aribaud albert.aribaud@free.fr
Orion5x MPP and GPIO setting code had writel arguments the wrong way around. Fixed and tested.
arch/arm/cpu/arm926ejs/orion5x/cpu.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/orion5x/cpu.c b/arch/arm/cpu/arm926ejs/orion5x/cpu.c index c2f5253..03c6d06 100644 --- a/arch/arm/cpu/arm926ejs/orion5x/cpu.c +++ b/arch/arm/cpu/arm926ejs/orion5x/cpu.c @@ -260,10 +260,10 @@ int arch_misc_init(void)
/* Set CPIOs and MPPs - values provided by board include file */
- writel(ORION5X_MPP_BASE+0x00, ORION5X_MPP0_7);
- writel(ORION5X_MPP_BASE+0x04, ORION5X_MPP8_15);
- writel(ORION5X_MPP_BASE+0x50, ORION5X_MPP16_23);
- writel(ORION5X_GPIO_BASE+0x04, ORION5X_GPIO_OUT_ENABLE);
- writel(ORION5X_MPP0_7, ORION5X_MPP_BASE+0x00);
- writel(ORION5X_MPP8_15, ORION5X_MPP_BASE+0x04);
- writel(ORION5X_MPP16_23, ORION5X_MPP_BASE+0x50);
- writel(ORION5X_GPIO_OUT_ENABLE, ORION5X_GPIO_BASE+0x04);
Applied to u-boot-marvell.git master branch
Regards.. Prafulla . .
participants (4)
-
Albert ARIBAUD -
Albert Aribaud
-
Prafulla Wadaskar -
Wolfgang Denk