[U-Boot] [PATCH 1/2] warp7: Pass the UART base definition

From: Fabio Estevam fabio.estevam@nxp.com
Since commit 5d69269deed0 ("mx7dsabresd: Define serial port locally") we need to specify the UART base address in each board config file, so do this to avoid a build error.
Signed-off-by: Fabio Estevam fabio.estevam@nxp.com --- include/configs/warp7.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/include/configs/warp7.h b/include/configs/warp7.h index 0798671..5ea5512 100644 --- a/include/configs/warp7.h +++ b/include/configs/warp7.h @@ -14,6 +14,8 @@
#define PHYS_SDRAM_SIZE SZ_512M
+#define CONFIG_MXC_UART_BASE UART1_IPS_BASE_ADDR + #define CONFIG_BOARD_EARLY_INIT_F
/* MMC Config*/

From: Fabio Estevam fabio.estevam@nxp.com
Having CONFIG_SYS_MALLOC_LEN in mx7_common.h is not a good idea, because the malloc() pool size is board dependent.
For example: if a certain board has support for splashscreen or DFU, it may be necessary to adjust CONFIG_SYS_MALLOC_LEN to a larger value.
So define CONFIG_SYS_MALLOC_LEN in each board config file.
Signed-off-by: Fabio Estevam fabio.estevam@nxp.com --- include/configs/mx7_common.h | 3 --- include/configs/mx7dsabresd.h | 3 +++ include/configs/warp7.h | 4 ++++ 3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/include/configs/mx7_common.h b/include/configs/mx7_common.h index 5034464..9bd6114 100644 --- a/include/configs/mx7_common.h +++ b/include/configs/mx7_common.h @@ -28,9 +28,6 @@ /* Enable iomux-lpsr support */ #define CONFIG_IOMUX_LPSR
-/* Size of malloc() pool */ -#define CONFIG_SYS_MALLOC_LEN (32 * SZ_1M) - #define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO
diff --git a/include/configs/mx7dsabresd.h b/include/configs/mx7dsabresd.h index 988d363..25ed29d 100644 --- a/include/configs/mx7dsabresd.h +++ b/include/configs/mx7dsabresd.h @@ -16,6 +16,9 @@
#define CONFIG_MXC_UART_BASE UART1_IPS_BASE_ADDR
+/* Size of malloc() pool */ +#define CONFIG_SYS_MALLOC_LEN (32 * SZ_1M) + #define CONFIG_BOARD_EARLY_INIT_F #define CONFIG_BOARD_LATE_INIT
diff --git a/include/configs/warp7.h b/include/configs/warp7.h index 5ea5512..d1404b2 100644 --- a/include/configs/warp7.h +++ b/include/configs/warp7.h @@ -16,6 +16,10 @@
#define CONFIG_MXC_UART_BASE UART1_IPS_BASE_ADDR
+ +/* Size of malloc() pool */ +#define CONFIG_SYS_MALLOC_LEN (32 * SZ_1M) + #define CONFIG_BOARD_EARLY_INIT_F
/* MMC Config*/

On 26/03/2016 17:30, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@nxp.com
Having CONFIG_SYS_MALLOC_LEN in mx7_common.h is not a good idea, because the malloc() pool size is board dependent.
For example: if a certain board has support for splashscreen or DFU, it may be necessary to adjust CONFIG_SYS_MALLOC_LEN to a larger value.
So define CONFIG_SYS_MALLOC_LEN in each board config file.
Signed-off-by: Fabio Estevam fabio.estevam@nxp.com
include/configs/mx7_common.h | 3 --- include/configs/mx7dsabresd.h | 3 +++ include/configs/warp7.h | 4 ++++ 3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/include/configs/mx7_common.h b/include/configs/mx7_common.h index 5034464..9bd6114 100644 --- a/include/configs/mx7_common.h +++ b/include/configs/mx7_common.h @@ -28,9 +28,6 @@ /* Enable iomux-lpsr support */ #define CONFIG_IOMUX_LPSR
-/* Size of malloc() pool */ -#define CONFIG_SYS_MALLOC_LEN (32 * SZ_1M)
#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO
diff --git a/include/configs/mx7dsabresd.h b/include/configs/mx7dsabresd.h index 988d363..25ed29d 100644 --- a/include/configs/mx7dsabresd.h +++ b/include/configs/mx7dsabresd.h @@ -16,6 +16,9 @@
#define CONFIG_MXC_UART_BASE UART1_IPS_BASE_ADDR
+/* Size of malloc() pool */ +#define CONFIG_SYS_MALLOC_LEN (32 * SZ_1M)
#define CONFIG_BOARD_EARLY_INIT_F #define CONFIG_BOARD_LATE_INIT
diff --git a/include/configs/warp7.h b/include/configs/warp7.h index 5ea5512..d1404b2 100644 --- a/include/configs/warp7.h +++ b/include/configs/warp7.h @@ -16,6 +16,10 @@
#define CONFIG_MXC_UART_BASE UART1_IPS_BASE_ADDR
+/* Size of malloc() pool */ +#define CONFIG_SYS_MALLOC_LEN (32 * SZ_1M)
#define CONFIG_BOARD_EARLY_INIT_F
/* MMC Config*/
Applied to u-boot-imx, thanks !
Best regards, Stefano Babic

On 26/03/2016 17:30, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@nxp.com
Since commit 5d69269deed0 ("mx7dsabresd: Define serial port locally") we need to specify the UART base address in each board config file, so do this to avoid a build error.
Signed-off-by: Fabio Estevam fabio.estevam@nxp.com
include/configs/warp7.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/include/configs/warp7.h b/include/configs/warp7.h index 0798671..5ea5512 100644 --- a/include/configs/warp7.h +++ b/include/configs/warp7.h @@ -14,6 +14,8 @@
#define PHYS_SDRAM_SIZE SZ_512M
+#define CONFIG_MXC_UART_BASE UART1_IPS_BASE_ADDR
#define CONFIG_BOARD_EARLY_INIT_F
/* MMC Config*/
Applied to u-boot-imx, thanks !
Best regards, Stefano Babic
participants (2)
-
Fabio Estevam
-
Stefano Babic