[U-Boot] R-Car-gpio0_00-fails-with-“gpio input” command

Hi, Attached is to fix below issue: ------------------ => gpio input gpio@e60500000mailto:gpio@e60500000 gpio: requesting pin 0 failed gpio - query and control gpio pins ------------------ Fix: drivers/pinctrl/renesas/pfc.c +470 //for (i = 1; i < pfc->info->nr_pins; i++) { for (i = 0; i < pfc->info->nr_pins; i++) { -------------------
Thank you and Best Regards Tiezhuang Dong 董铁庄 ************************************************ Application Engineering Section, Technical Customer Engagement Department 3, Automotive Technical Customer Engagement Division, (ABU / ATCED / ATC3 / Application Engineering Section)
Tel: 010-82351155-6631 13552056582 URL: http://www.cn.renesas.com ************************************************

On 7/23/19 3:00 AM, Tiezhuang Dong wrote:
Hi,
Hi,
Attached is to fix below issue:
=> gpio input gpio@e60500000 mailto:gpio@e60500000 gpio: requesting pin 0 failed gpio - query and control gpio pins
Fix:
drivers/pinctrl/renesas/pfc.c +470
//for (i = 1; i < pfc->info->nr_pins; i++) {
for (i = 0; i < pfc->info->nr_pins; i++) {
sh_pfc_gpio_disable_free() needs similar change, right ?
Can you send the patch using git send-email and also add proper commit message ? Thanks

I reviewed this issue. And found that the version of u-boot is different from mine. I am not sure whether this issue will happen or not on current version. So, I can't answer about sh_pfc_gpio_disable_free()
My u-boot version is as below: "U-Boot 2018.09-00073-g479b167c7c (Jul 26 2019 - 15:09:43 +0800)"
Thanks and Best Regards
Tiezhuang Dong 董铁庄
Application Engineering Section, Technical Customer Engagement Department 3, Automotive Technical Customer Engagement Division, (ABU / ATCED / ATC3 / Application Engineering Section)
Tel: 010-82351155-6631 13552056582 URL: http://www.cn.renesas.com
-----邮件原件----- 发件人: Marek Vasut marek.vasut@gmail.com 发送时间: 2019年7月23日 18:35 收件人: Tiezhuang Dong tiezhuang.dong.yh@renesas.com; marek.vasut+renesas@gmail.com 抄送: u-boot@lists.denx.de 主题: Re: R-Car-gpio0_00-fails-with-“gpio input” command
On 7/23/19 3:00 AM, Tiezhuang Dong wrote:
Hi,
Hi,
Attached is to fix below issue:
=> gpio input gpio@e60500000 mailto:gpio@e60500000 gpio: requesting pin 0 failed gpio - query and control gpio pins
Fix:
drivers/pinctrl/renesas/pfc.c +470
//for (i = 1; i < pfc->info->nr_pins; i++) {
for (i = 0; i < pfc->info->nr_pins; i++) {
sh_pfc_gpio_disable_free() needs similar change, right ?
Can you send the patch using git send-email and also add proper commit message ? Thanks
-- Best regards, Marek Vasut

On 7/26/19 11:22 AM, Tiezhuang Dong wrote:
I reviewed this issue. And found that the version of u-boot is different from mine. I am not sure whether this issue will happen or not on current version. So, I can't answer about sh_pfc_gpio_disable_free()
It will.
My u-boot version is as below: "U-Boot 2018.09-00073-g479b167c7c (Jul 26 2019 - 15:09:43 +0800)"
Maybe that's a BSP version ?
Anyway, can you update and re-submit the patch properly ?
participants (2)
-
Marek Vasut
-
Tiezhuang Dong